Lightpanda: the headless browser designed for AI and automation
webapi: tighten DOM allocation lifetimes
Francis Bouvier50a896f4c0a2
diff --git a/src/browser/tests/events.html b/src/browser/tests/events.htmlindex 6be2ee8f3..3b451a90c 100644--- a/src/browser/tests/events.html+++ b/src/browser/tests/events.html@@ -940,3 +940,16 @@child.removeEventListener('click', listener);}</script>++<script id=beforeUnloadEventReturnValue>+ {+ const event = document.createEvent('BeforeUnloadEvent');+ testing.expectEqual('', event.returnValue);++ event.returnValue = 'first';+ testing.expectEqual('first', event.returnValue);++ event.returnValue = 'replacement';+ testing.expectEqual('replacement', event.returnValue);+ }+</script>diff --git a/src/browser/webapi/AbortSignal.zig b/src/browser/webapi/AbortSignal.zigindex 5ad2f9758..7b13a22c5 100644--- a/src/browser/webapi/AbortSignal.zig+++ b/src/browser/webapi/AbortSignal.zig@@ -106,7 +106,7 @@ pub fn abort(self: *AbortSignal, reason_: ?Reason, exec: *const Execution) !voidvar to_dispatch: std.ArrayList(Dependend) = .{};for (self._dependents.items) |dep| {if (try dep.markAborted(self._reason, exec)) {- try to_dispatch.append(exec.arena, dep);+ try to_dispatch.append(exec.call_arena, dep);}}diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zigindex d55396311..c2776a1f0 100644--- a/src/browser/webapi/element/Html.zig+++ b/src/browser/webapi/element/Html.zig@@ -380,7 +380,7 @@ pub fn getAccessKeyLabel(self: *HtmlElement, frame: *Frame) ![]const u8 {if (codepoints != 1) {return "";}- return std.fmt.allocPrint(frame.call_arena, "Alt+{s}", .{value});+ return std.fmt.allocPrint(frame.local_arena, "Alt+{s}", .{value});}pub fn getPopover(self: *HtmlElement) ?[]const u8 {diff --git a/src/browser/webapi/event/BeforeUnloadEvent.zig b/src/browser/webapi/event/BeforeUnloadEvent.zigindex 00b2fdbff..4c1372cf6 100644--- a/src/browser/webapi/event/BeforeUnloadEvent.zig+++ b/src/browser/webapi/event/BeforeUnloadEvent.zig@@ -71,8 +71,8 @@ pub fn getReturnValue(self: *const BeforeUnloadEvent) []const u8 {return self._return_value;}-pub fn setReturnValue(self: *BeforeUnloadEvent, value: []const u8, frame: *Frame) !void {- self._return_value = try frame.dupeString(value);+pub fn setReturnValue(self: *BeforeUnloadEvent, value: []const u8) !void {+ self._return_value = try self._proto._arena.dupe(u8, value);}pub const JsApi = struct {