Skip to content

Lightpanda: the headless browser designed for AI and automation

Merge pull request #2791 from rohitsux/feat/cdp-viewport-browser-level

Pierre Tachoire55568907ba23
diff --cc src/cdp/domains/emulation.zig
index ab2681b97,5ecccbbb1..de14cd7eb
--- a/src/cdp/domains/emulation.zig
+++ b/src/cdp/domains/emulation.zig
@@@ -79,43 -79,24 +79,44 @@@ fn setDeviceMetricsOverride(cmd: *CDP.C
// Not-yet-emulated parameters: accept them but warn so the caller knows
// they are ignored.
if (params.deviceScaleFactor) |v| {
- if (v != 0) log.warn(.not_implemented, "Emulation.setDeviceMetricsOverride", .{ .param = "deviceScaleFactor", .value = v });
+ if (v != 0) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ .cdp_cmd = "Emulation.setDeviceMetricsOverride",
+ .param = "deviceScaleFactor",
+ .value = v,
+ });
}
if (params.mobile) |v| {
- if (v) log.warn(.not_implemented, "Emulation.setDeviceMetricsOverride", .{ .param = "mobile", .value = v });
+ if (v) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ .cdp_cmd = "Emulation.setDeviceMetricsOverride",
+ .param = "mobile",
+ .value = v,
+ });
}
if (params.scale) |v| {
- if (v != 0) log.warn(.not_implemented, "Emulation.setDeviceMetricsOverride", .{ .param = "scale", .value = v });
+ if (v != 0) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ .cdp_cmd = "Emulation.setDeviceMetricsOverride",
+ .param = "scale",
+ .value = v,
+ });
}
if (params.screenWidth) |v| {
- if (v != 0) log.warn(.not_implemented, "Emulation.setDeviceMetricsOverride", .{ .param = "screenWidth", .value = v });
+ if (v != 0) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ .cdp_cmd = "Emulation.setDeviceMetricsOverride",
+ .param = "screenWidth",
+ .value = v,
+ });
}
if (params.screenHeight) |v| {
- if (v != 0) log.warn(.not_implemented, "Emulation.setDeviceMetricsOverride", .{ .param = "screenHeight", .value = v });
+ if (v != 0) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ .cdp_cmd = "Emulation.setDeviceMetricsOverride",
+ .param = "screenHeight",
+ .value = v,
+ });
}
- const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
- const page = bc.session.currentPage() orelse return error.FrameNotLoaded;
+ // The override is stored on the Browser so it persists across page
+ // navigations for the whole CDP connection.
+ const browser = &cmd.cdp.browser;
// CDP convention: a 0 width/height means "don't override that dimension",
// so keep the current value for any dimension passed as 0.