Skip to content

Lightpanda: the headless browser designed for AI and automation

check for boundaries on `Frame.buf` access

Halil Durak56bac28ac05f
diff --git a/src/browser/frame/node_factory.zig b/src/browser/frame/node_factory.zig
index b0c45aa75..ddbc33df2 100644
--- a/src/browser/frame/node_factory.zig
+++ b/src/browser/frame/node_factory.zig
@@ -946,8 +946,11 @@ pub fn createElementNS(document: *const Node.Document, namespace: Element.Namesp
else => {},
}
- const lower = std.ascii.lowerString(&frame.buf, name);
- const tag = std.meta.stringToEnum(Element.Tag, lower) orelse .unknown;
+ // No known tag name is longer than frame.buf.
+ const tag: Element.Tag = if (name.len > frame.buf.len)
+ .unknown
+ else
+ std.meta.stringToEnum(Element.Tag, std.ascii.lowerString(&frame.buf, name)) orelse .unknown;
return createSvgElementT(document, Element.Svg.Generic, name, attribute_iterator, .{ ._tag = tag });
},
else => {
diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zig
index 9c4614289..691add6b4 100644
--- a/src/browser/webapi/Document.zig
+++ b/src/browser/webapi/Document.zig
@@ -359,7 +359,11 @@ pub fn createElement(self: *Document, name: []const u8, options_: ?CreateElement
try validateElementName(name);
const ns: Element.Namespace, const normalized_name = blk: {
if (self._type == .html) {
- break :blk .{ .html, std.ascii.lowerString(&frame.buf, name) };
+ const lower = if (name.len <= frame.buf.len)
+ std.ascii.lowerString(&frame.buf, name)
+ else
+ try std.ascii.allocLowerString(frame.local_arena, name);
+ break :blk .{ .html, lower };
}
// Generic and XML documents create elements with null namespace
break :blk .{ .null, name };