Skip to content

Lightpanda: the headless browser designed for AI and automation

add a Build.connected callback to hook node's connected

Pierre Tachoire5c388c89d0bc
diff --git a/src/browser/Frame.zig b/src/browser/Frame.zig
index f445c9e46..2897471f6 100644
--- a/src/browser/Frame.zig
+++ b/src/browser/Frame.zig
@@ -3109,6 +3109,12 @@ fn _insertNodeRelative(self: *Frame, comptime from_parser: bool, parent: *Node,
try self.addElementIdWithMaps(id_maps, el, id);
}
if (rootIsConnected(root)) {
+ // Build.connected, parser side (JS side is in nodeIsReady).
+ // Called here, not on pop, so void elements get it too.
+ // The document may have no frame (DOMParser).
+ _ = Element.Build.call(el, "connected", .{ el, self }) catch |err| {
+ log.err(.bug, "build.connected", .{ .tag = el.getTag(), .err = err, .type = self._type, .url = self.url });
+ };
try Element.Html.Custom.enqueueConnectedCallbackOnElement(true, el, self);
}
}
@@ -3388,6 +3394,15 @@ fn nodeIsReady(self: *Frame, comptime from_parser: bool, node: *Node) !void {
}
}
+ // Build.connected, JS side. The parser calls it in _insertNodeRelative.
+ if (comptime from_parser == false) {
+ if (node.is(Element)) |el| {
+ _ = Element.Build.call(el, "connected", .{ el, self }) catch |err| {
+ log.err(.bug, "build.connected", .{ .tag = el.getTag(), .err = err, .type = self._type, .url = self.url });
+ };
+ }
+ }
+
if (node.is(Element.Html.Script)) |script| {
if ((comptime from_parser == false) and script._src.len == 0) {
// Script was added via JavaScript without a src attribute.
diff --git a/src/browser/webapi/element/html/Base.zig b/src/browser/webapi/element/html/Base.zig
index 95ef472df..6b467723a 100644
--- a/src/browser/webapi/element/html/Base.zig
+++ b/src/browser/webapi/element/html/Base.zig
@@ -53,12 +53,9 @@ pub fn getHref(self: *Base, frame: *Frame) ![]const u8 {
return URL.resolve(frame.local_arena, doc.getURL(frame), href, .{});
}
+// Build.attributeChange updates the document base URL.
pub fn setHref(self: *Base, value: []const u8, frame: *Frame) !void {
- const element = self.asElement();
- try element.setAttributeSafe(comptime .wrap("href"), .wrap(value), frame);
-
- if (element.asNode().isConnected() == false) return;
- try self.baseAddedCallback(frame);
+ try self.asElement().setAttributeSafe(comptime .wrap("href"), .wrap(value), frame);
}
fn baseAddedCallback(self: *Base, frame: *Frame) !void {
@@ -98,13 +95,8 @@ pub const JsApi = struct {
};
pub const Build = struct {
- pub const parser_created_on_insert = true;
-
- pub fn created(node: *Node, frame: *Frame) !void {
- if (node.isConnected() == false) return;
-
- const self = node.as(Base);
- try self.baseAddedCallback(frame);
+ pub fn connected(element: *Element, frame: *Frame) !void {
+ return element.as(Base).baseAddedCallback(frame);
}
pub fn attributeChange(element: *Element, name: String, _: String, frame: *Frame) !void {