Lightpanda: the headless browser designed for AI and automation
option: add HTMLOptionElement.index
Jay Hemnani5cf7dc91c9a5
diff --git a/src/browser/tests/element/html/option.html b/src/browser/tests/element/html/option.htmlindex 420f48402..af45c6ba1 100644--- a/src/browser/tests/element/html/option.html+++ b/src/browser/tests/element/html/option.html@@ -292,6 +292,28 @@}</script>+<script id="index">+ {+ testing.expectEqual(0, new Option().index)++ const select = document.createElement('select')+ select.innerHTML = '<option>a</option><optgroup><option>b</option><option>c</option></optgroup><option>d</option>'+ testing.expectEqual([0, 1, 2, 3], Array.from(select.options, (o) => o.index))++ const d = select.options[3]+ select.insertBefore(new Option('z'), select.firstChild)+ testing.expectEqual(4, d.index)++ d.remove()+ testing.expectEqual(0, d.index)++ // Options in a datalist are not in a list of options.+ const list = document.createElement('datalist')+ list.innerHTML = '<option>x</option><option>y</option>'+ testing.expectEqual(0, list.children[1].index)+ }+</script>+<script id="legacy_factory_function">// https://webidl.spec.whatwg.org/#legacy-factory-functionstesting.expectEqual(true, Option !== HTMLOptionElement)diff --git a/src/browser/webapi/element/html/Option.zig b/src/browser/webapi/element/html/Option.zigindex 34ae46975..a23bd58ad 100644--- a/src/browser/webapi/element/html/Option.zig+++ b/src/browser/webapi/element/html/Option.zig@@ -175,6 +175,12 @@ fn setDefaultSelected(self: *Option, value: bool, frame: *Frame) !void {// On getting, return the `label` content attribute if present (verbatim, even// when empty), otherwise the value of the `text` IDL attribute. On setting,// reflect to the `label` content attribute.+// https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-index+fn getIndex(self: *Option) u32 {+ const select = self.ownerSelect() orelse return 0;+ return select.optionIndex(self) orelse 0;+}+fn getLabel(self: *Option, frame: *Frame) []const u8 {return self.asElement().getAttributeSafe(comptime .wrap("label")) orelse self.getText(frame);}@@ -201,6 +207,7 @@ pub const JsApi = struct {pub const selected = bridge.accessor(Option.getSelected, Option.setSelected, .{});pub const defaultSelected = bridge.accessor(Option.getDefaultSelected, Option.setDefaultSelected, .{ .ce_reactions = true });pub const disabled = reflect.boolean("disabled");+ pub const index = bridge.accessor(Option.getIndex, null, .{});};pub const Build = struct {diff --git a/src/browser/webapi/element/html/Select.zig b/src/browser/webapi/element/html/Select.zigindex d9f76172b..e2f15607d 100644--- a/src/browser/webapi/element/html/Select.zig+++ b/src/browser/webapi/element/html/Select.zig@@ -305,6 +305,17 @@ pub fn setValue(self: *Select, value: []const u8, frame: *Frame) !void {frame.domChanged();}+/// The position of `option` in the list of options, or null when the option+/// is not in it.+pub fn optionIndex(self: *const Select, option: *const Option) ?u32 {+ var index: u32 = 0;+ var it = OptionIterator.init(self);+ while (it.next()) |o| : (index += 1) {+ if (o == option) return index;+ }+ return null;+}+pub fn getSelectedIndex(self: *Select) i32 {var index: i32 = 0;var it = OptionIterator.init(self);