Skip to content

Lightpanda: the headless browser designed for AI and automation

ops: downgrade many warn/err logs -> debug

Karl Seguin5eaebc923544
diff --git a/src/browser/EventManager.zig b/src/browser/EventManager.zig
index 187462d3d..02aae6236 100644
--- a/src/browser/EventManager.zig
+++ b/src/browser/EventManager.zig
@@ -237,17 +237,17 @@ fn dispatchNode(self: *EventManager, target: *Node, event: *Event) !void {
if (event.is(@import("webapi/event/MouseEvent.zig")) != null) {
if (Frame.user_input.findClickActivationTarget(target, event._bubbles)) |activation_target| {
Frame.user_input.handleClick(frame, activation_target, target) catch |err| {
- log.warn(.event, "frame.click", .{ .err = err });
+ log.debug(.event, "frame.click", .{ .err = err });
};
}
}
} else if (event._type_string.eql(comptime .wrap("keydown"))) {
Frame.user_input.handleKeydown(frame, target, event) catch |err| {
- log.warn(.event, "frame.keydown", .{ .err = err });
+ log.debug(.event, "frame.keydown", .{ .err = err });
};
} else if (event._type_string.eql(comptime .wrap("keyup"))) {
Frame.user_input.handleKeyup(frame, target, event) catch |err| {
- log.warn(.event, "frame.keyup", .{ .err = err });
+ log.debug(.event, "frame.keyup", .{ .err = err });
};
}
}
@@ -338,7 +338,7 @@ fn dispatchNode(self: *EventManager, target: *Node, event: *Event) !void {
return error.ExecutionTerminated;
}
frame.page.recordJsError(err);
- log.warn(.event, "inline handler", .{ .err = err, .caught = caught });
+ log.debug(.event, "inline handler", .{ .err = err, .caught = caught });
break :ret null;
};
processHandlerReturnValue(event, handler_return);
@@ -399,7 +399,7 @@ fn dispatchNode(self: *EventManager, target: *Node, event: *Event) !void {
return error.ExecutionTerminated;
}
frame.page.recordJsError(err);
- log.warn(.event, "inline handler", .{ .err = err, .caught = caught });
+ log.debug(.event, "inline handler", .{ .err = err, .caught = caught });
break :ret null;
};
processHandlerReturnValue(event, handler_return);
@@ -603,7 +603,7 @@ fn getInlineHandler(self: *EventManager, target: *EventTarget, event: *Event) ?j
};
return html_element.getAttributeFunction(handler_type, self.frame) catch |err| {
- log.warn(.event, "inline html callback", .{ .type = handler_type, .err = err });
+ log.debug(.event, "inline html callback", .{ .type = handler_type, .err = err });
return null;
};
}
@@ -849,10 +849,10 @@ const ActivationState = struct {
const state_changed = (input._input_type == .checkbox) or !self.old_checked;
if (state_changed and input.asElement().asNode().isConnected()) {
fireEvent(frame, input, "input") catch |err| {
- log.warn(.event, "input event", .{ .err = err });
+ log.debug(.event, "input event", .{ .err = err });
};
fireEvent(frame, input, "change") catch |err| {
- log.warn(.event, "change event", .{ .err = err });
+ log.debug(.event, "change event", .{ .err = err });
};
}
}
diff --git a/src/browser/EventManagerBase.zig b/src/browser/EventManagerBase.zig
index e5609b01b..f15d26646 100644
--- a/src/browser/EventManagerBase.zig
+++ b/src/browser/EventManagerBase.zig
@@ -317,7 +317,7 @@ pub fn dispatchDirect(
if (err == error.JsException) {
event._listeners_did_throw = true;
} else {
- log.warn(.event, opts.context, .{ .err = err, .caught = caught });
+ log.debug(.event, opts.context, .{ .err = err, .caught = caught });
}
};
}
@@ -472,7 +472,7 @@ pub const Listener = struct {
reportException(&try_catch, local);
},
error.ExecutionTerminated => return error.ExecutionTerminated,
- else => log.warn(.event, context, .{ .err = err }),
+ else => log.debug(.event, context, .{ .err = err }),
};
},
.string => |string| {
@@ -485,7 +485,7 @@ pub const Listener = struct {
if (err == error.JsException) {
event._listeners_did_throw = true;
} else {
- log.warn(.event, context, .{ .err = err });
+ log.debug(.event, context, .{ .err = err });
}
};
},
@@ -503,7 +503,7 @@ pub const Listener = struct {
event._listeners_did_throw = true;
reportException(&try_catch, local);
} else {
- log.warn(.event, context, .{ .err = err });
+ log.debug(.event, context, .{ .err = err });
}
return;
};
@@ -529,7 +529,7 @@ pub const Listener = struct {
reportException(&try_catch, local);
},
error.ExecutionTerminated => return error.ExecutionTerminated,
- else => log.warn(.event, context, .{ .err = err }),
+ else => log.debug(.event, context, .{ .err = err }),
};
},
}
@@ -545,7 +545,7 @@ pub const Listener = struct {
fn reportExceptionValue(local: *const js.Local, exc: js.Value) void {
switch (local.ctx.global) {
.frame => |frame| frame.window.reportError(exc, frame) catch |err| {
- log.warn(.event, "listener report error", .{ .err = err });
+ log.debug(.event, "listener report error", .{ .err = err });
},
// No worker error-event plumbing here (yet); still count it.
.worker => local.ctx.page.recordJsError(error.JsException),
diff --git a/src/browser/Frame.zig b/src/browser/Frame.zig
index 90a84cd54..7d44d3268 100644
--- a/src/browser/Frame.zig
+++ b/src/browser/Frame.zig
@@ -685,7 +685,7 @@ pub fn navigate(self: *Frame, request_url: [:0]const u8, opts: NavigateOpts) !vo
if (is_about_blank or is_srcdoc or is_blob) {
if (is_blob) {
if (!Blob.urlBelongsToOrigin(request_url, opts.initiator_origin)) {
- log.warn(.js, "invalid blob", .{ .url = request_url });
+ log.debug(.js, "invalid blob", .{ .url = request_url });
return error.BlobNotFound;
}
}
@@ -737,7 +737,7 @@ pub fn navigate(self: *Frame, request_url: [:0]const u8, opts: NavigateOpts) !vo
if (is_blob) {
const blob = blk: {
if (self.page.blob_urls.get(request_url)) |entry| break :blk entry.blob;
- log.warn(.js, "invalid blob", .{ .url = request_url });
+ log.debug(.js, "invalid blob", .{ .url = request_url });
return error.BlobNotFound;
};
const parse_arena = try self.getArena(.medium, "Frame.parseBlob");
@@ -759,7 +759,7 @@ pub fn navigate(self: *Frame, request_url: [:0]const u8, opts: NavigateOpts) !vo
// the parser emits nothing for an empty input; commit the
// same html/head/body scaffolding an empty srcdoc implies
self.document.injectBlank(self) catch |err| {
- log.err(.browser, "inject blank", .{ .err = err });
+ log.debug(.browser, "inject blank", .{ .err = err });
return error.InjectBlankFailed;
};
} else {
@@ -773,7 +773,7 @@ pub fn navigate(self: *Frame, request_url: [:0]const u8, opts: NavigateOpts) !vo
}
} else {
self.document.injectBlank(self) catch |err| {
- log.err(.browser, "inject blank", .{ .err = err });
+ log.debug(.browser, "inject blank", .{ .err = err });
return error.InjectBlankFailed;
};
}
@@ -906,7 +906,7 @@ pub fn navigate(self: *Frame, request_url: [:0]const u8, opts: NavigateOpts) !vo
session.navigation._current_navigation_kind = opts.kind;
transfer.submit() catch |err| {
- log.err(.frame, "navigate request", .{ .url = self.url, .err = err, .type = self._type });
+ log.debug(.frame, "navigate request", .{ .url = self.url, .err = err, .type = self._type });
return err;
};
}
@@ -1319,7 +1319,7 @@ fn iframeCompletedLoading(self: *Frame, iframe: *IFrame, delays_load: bool) void
break :blk;
};
self._event_manager.dispatch(iframe.asNode().asEventTarget(), event) catch |err| {
- log.warn(.js, "iframe onload", .{ .err = err, .url = iframe._src });
+ log.debug(.js, "iframe onload", .{ .err = err, .url = iframe._src });
};
}
@@ -1431,7 +1431,7 @@ fn metaRefreshOnLoad(self: *Frame) void {
const meta = node.is(Element.Html.Meta) orelse continue;
const target = meta.refreshTarget() orelse continue;
return self.metaRefresh(target) catch |err| {
- log.err(.frame, "meta refresh", .{ .err = err, .type = self._type, .url = self.url });
+ log.debug(.frame, "meta refresh", .{ .err = err, .type = self._type, .url = self.url });
};
}
}
@@ -1467,7 +1467,7 @@ fn frameHeaderDoneCallback(transfer: *HttpClient.Transfer) !HttpClient.Transfer.
}
if (self.parent != null and framing.allowed(self, transfer) == false) {
- log.warn(.frame, "x-frame-options blocked", .{ .url = self.url });
+ log.debug(.frame, "x-frame-options blocked", .{ .url = self.url });
// give this an opaque origin so that any request to the error page
// is treated as being cross-origin
self.origin = null;
@@ -1941,8 +1941,7 @@ fn frameErrorCallback(ctx: *anyopaque, err: anyerror) void {
var self: *Frame = @ptrCast(@alignCast(ctx));
self._last_navigate_error = err;
- const level: log.Level = if (err == error.TransferCanceled) .info else .err;
- log.log(.frame, level, "navigate failed", .{ .err = err, .type = self._type, .url = self.url });
+ log.debug(.frame, "navigate failed", .{ .err = err, .type = self._type, .url = self.url });
// A navigation that fails before any response headers arrive never
// reaches the frame_navigated dispatch in frameHeaderCallback, so the
@@ -2008,11 +2007,7 @@ pub fn scriptAddedCallback(self: *Frame, comptime from_parser: bool, script: *El
}
self._script_manager.addFromElement(from_parser, script, "parsing") catch |err| {
- const level: log.Level = switch (err) {
- error.UrlBlocked, error.RobotsBlocked => .warn,
- else => .err,
- };
- log.log(.frame, level, "frame.scriptAddedCallback", .{
+ log.debug(.frame, "frame.scriptAddedCallback", .{
.err = err,
.url = self.url,
.src = script.asElement().getAttributeInterned("src"),
@@ -2134,7 +2129,7 @@ pub fn iframeAddedCallback(self: *Frame, iframe: *IFrame) !void {
if (std.mem.indexOfScalar(*Frame, self.child_frames.items, new_frame)) |idx| {
_ = self.child_frames.swapRemove(idx);
}
- log.warn(.frame, "iframe navigate failure", .{ .url = url, .err = err });
+ log.debug(.frame, "iframe navigate failure", .{ .url = url, .err = err });
if (delays_load) {
self._pending_loads -= 1;
}
@@ -2227,7 +2222,7 @@ pub fn openPopup(self: *Frame, opts: OpenPopupOpts) !*Frame {
errdefer _ = page.popups.swapRemove(popup_index);
popup.navigate(resolved_url, .{ .reason = .script, .initiator_origin = self.origin }) catch |err| {
- log.warn(.frame, "popup navigate failure", .{ .url = resolved_url, .err = err });
+ log.debug(.frame, "popup navigate failure", .{ .url = resolved_url, .err = err });
return err;
};
@@ -2488,7 +2483,7 @@ pub fn loadExternalStylesheet(self: *Frame, link: *Element.Html.Link, href: []co
defer arena.release();
const resolved = URL.resolve(arena.allocator(), self.base(), href, .{ .encoding = self.charset }) catch |err| {
- log.warn(.http, "external stylesheet resolve", .{ .err = err, .href = href });
+ log.debug(.http, "external stylesheet resolve", .{ .err = err, .href = href });
try self.fireElementEvent(element, comptime .wrap("error"));
return;
};
@@ -2509,7 +2504,7 @@ pub fn loadExternalStylesheet(self: *Frame, link: *Element.Html.Link, href: []co
.resource_type = .stylesheet,
.shutdown_callback = HttpClient.noopShutdown, // syncRequest installs its own
}, &self._http_owner) catch |err| {
- log.warn(.http, "external stylesheet fetch", .{ .err = err, .url = resolved });
+ log.debug(.http, "external stylesheet fetch", .{ .err = err, .url = resolved });
return self.fireElementEvent(element, comptime .wrap("error"));
};
{
@@ -2531,7 +2526,7 @@ pub fn loadExternalStylesheet(self: *Frame, link: *Element.Html.Link, href: []co
defer sm.endEvaluationWindow(was_evaluating);
var response = transfer.submitSync(.{}) catch |err| {
- log.warn(.http, "external stylesheet fetch", .{ .err = err, .url = resolved });
+ log.debug(.http, "external stylesheet fetch", .{ .err = err, .url = resolved });
return self.fireElementEvent(element, comptime .wrap("error"));
};
defer response.deinit();
@@ -2542,7 +2537,7 @@ pub fn loadExternalStylesheet(self: *Frame, link: *Element.Html.Link, href: []co
}
if (response.body.items.len > MAX_STYLESHEET_BYTES) {
- log.warn(.http, "external stylesheet too large", .{
+ log.debug(.http, "external stylesheet too large", .{
.bytes = response.body.items.len,
.max = MAX_STYLESHEET_BYTES,
.url = resolved,
@@ -2575,7 +2570,7 @@ pub fn loadExternalStylesheet(self: *Frame, link: *Element.Html.Link, href: []co
// `_href` consistent with what the sheet actually contains is the
// minimum.
sheet.replaceSync(response.body.items, self) catch |err| {
- log.warn(.http, "external stylesheet parse", .{ .err = err, .url = resolved });
+ log.debug(.http, "external stylesheet parse", .{ .err = err, .url = resolved });
return self.fireElementEvent(element, comptime .wrap("error"));
};
sheet._href = try self.arena.dupe(u8, resolved);
@@ -3363,31 +3358,31 @@ fn nodeIsReady(self: *Frame, comptime from_parser: bool, node: *Node) !void {
const frame = if (comptime from_parser) self else (node.ownerFrame(self) orelse return);
frame.scriptAddedCallback(from_parser, script) catch |err| {
- log.err(.frame, "frame.nodeIsReady", .{ .err = err, .element = "script", .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.nodeIsReady", .{ .err = err, .element = "script", .type = frame._type, .url = frame.url });
return err;
};
} else if (node.is(IFrame)) |iframe| {
const frame = if (comptime from_parser) self else (node.ownerFrame(self) orelse return);
frame.iframeAddedCallback(iframe) catch |err| {
- log.err(.frame, "frame.nodeIsReady", .{ .err = err, .element = "iframe", .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.nodeIsReady", .{ .err = err, .element = "iframe", .type = frame._type, .url = frame.url });
return err;
};
} else if (node.is(Element.Html.Meta)) |meta| {
const frame = if (comptime from_parser) self else (node.ownerFrame(self) orelse return);
meta.processRefresh(frame) catch |err| {
- log.err(.frame, "frame.nodeIsReady", .{ .err = err, .element = "meta", .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.nodeIsReady", .{ .err = err, .element = "meta", .type = frame._type, .url = frame.url });
return err;
};
} else if (node.is(Element.Html.Link)) |link| {
const frame = if (comptime from_parser) self else (node.ownerFrame(self) orelse return);
link.linkAddedCallback(frame) catch |err| {
- log.err(.frame, "frame.nodeIsReady", .{ .err = err, .element = "link", .type = frame._type });
+ log.debug(.frame, "frame.nodeIsReady", .{ .err = err, .element = "link", .type = frame._type });
return error.LinkLoadError;
};
} else if (node.is(Element.Html.Style)) |style| {
const frame = if (comptime from_parser) self else (node.ownerFrame(self) orelse return);
style.styleAddedCallback(frame) catch |err| {
- log.err(.frame, "frame.nodeIsReady", .{ .err = err, .element = "style", .type = frame._type });
+ log.debug(.frame, "frame.nodeIsReady", .{ .err = err, .element = "style", .type = frame._type });
return error.StyleLoadError;
};
}
@@ -4273,8 +4268,6 @@ fn appendMetaRefresh(frame: *Frame, content: []const u8) !*Element {
}
test "Frame: httpMetadata after navigation" {
- testing.expectLog(&.{.http});
-
const page = try testing.pageTest("page/meta.html", .{});
defer page.close();
diff --git a/src/browser/ImportMap.zig b/src/browser/ImportMap.zig
index 355d28216..66e62cc6f 100644
--- a/src/browser/ImportMap.zig
+++ b/src/browser/ImportMap.zig
@@ -136,7 +136,7 @@ fn parse(arena: Allocator, base: [:0]const u8, json_content: []const u8) !Import
imports: ?SpecifierMap = null,
scopes: ?std.json.ArrayHashMap(SpecifierMap) = null,
}, arena, json_content, .{ .ignore_unknown_fields = true }) catch |err| {
- log.warn(.js, "importmap json parse", .{ .err = err });
+ log.debug(.js, "importmap json parse", .{ .err = err });
return error.InvalidImportMap;
};
@@ -165,13 +165,13 @@ fn sortedNormalizedSpecifierMap(arena: Allocator, base: [:0]const u8, obj: Speci
const resolved: ?[:0]const u8 = blk: {
const url = kv.value_ptr.* orelse break :blk null;
const resolved_url = parseIfLikeURL(arena, base, url) orelse {
- log.warn(.js, "importmap bad address", .{ .specifier = key, .address = url });
+ log.debug(.js, "importmap bad address", .{ .specifier = key, .address = url });
break :blk null;
};
// Spec: if the key ends with "/" the address must end with "/" too.
if (endsWithSlash(normalized_key) and !endsWithSlash(resolved_url)) {
- log.warn(.js, "importmap slash mismatch", .{ .specifier = key, .address = url });
+ log.debug(.js, "importmap slash mismatch", .{ .specifier = key, .address = url });
break :blk null;
}
break :blk resolved_url;
@@ -200,7 +200,7 @@ fn sortedNormalizedScopes(arena: Allocator, base: [:0]const u8, obj: std.json.Ar
// URL-like specifiers — bare strings without ./, ../, /, or a scheme
// are still allowed if they resolve against the base.
const prefix = parseScopeKey(arena, base, scope_key) catch |err| {
- log.warn(.js, "importmap bad scope key", .{ .scope = scope_key, .err = err });
+ log.debug(.js, "importmap bad scope key", .{ .scope = scope_key, .err = err });
continue;
};
diff --git a/src/browser/Page.zig b/src/browser/Page.zig
index f1c6900c4..63c165473 100644
--- a/src/browser/Page.zig
+++ b/src/browser/Page.zig
@@ -537,7 +537,6 @@ fn appendFrameExecutions(frame: *Frame, origin: []const u8, arena: Allocator, li
const testing = @import("../testing.zig");
test "Page: js_error_count" {
- testing.expectLog(&.{ .js, .js, .js });
// One uncaught top-level script exception, one uncaught timer-callback
// exception.
diff --git a/src/browser/ScriptManager.zig b/src/browser/ScriptManager.zig
index b60d34223..824c7c2d4 100644
--- a/src/browser/ScriptManager.zig
+++ b/src/browser/ScriptManager.zig
@@ -581,7 +581,7 @@ const PreloadedScript = struct {
if (script.status == 404) {
log.info(.http, "script 404", .{ .req = script.url, .extra = "preload" });
} else {
- log.warn(.http, "script fetch error", .{ .err = err, .req = script.url, .extra = "preload", .status = script.status });
+ log.debug(.http, "script fetch error", .{ .err = err, .req = script.url, .extra = "preload", .status = script.status });
}
script.status = 0; // status == 0 is correctly treated as an error throughout
@@ -695,9 +695,6 @@ test "ScriptManager: async script whose submit fails synchronously releases its
client.test_fail_submit = error.TestSubmitFailure;
defer client.test_fail_submit = null;
- // Script.errorCallback logs the fetch error.
- testing.expectLog(&.{.http});
-
var ls: js.Local.Scope = undefined;
frame.js.localScope(&ls);
defer ls.deinit();
@@ -723,9 +720,6 @@ test "ScriptManager: preload whose submit fails synchronously releases its arena
client.test_fail_submit = error.TestSubmitFailure;
defer client.test_fail_submit = null;
- // PreloadedScript.errorCallback logs the fetch error.
- testing.expectLog(&.{.http});
-
const url = "http://127.0.0.1:9582/fails-at-submit.js";
// A fetch was started (and failed), so the hint's error event fires.
try testing.expectEqual(true, try sm.preloadScript(null, url));
@@ -742,9 +736,6 @@ test "ScriptManager: a failed preload is consumed, not refetched" {
try client.setBlockedUrls(&.{ "*/preload_failed.js", "*/preload_failed_module.js" });
defer client.setBlockedUrls(&.{}) catch unreachable;
- // Both hints' fetch errors, and nothing else.
- testing.expectLog(&.{ .http, .http });
-
const page = try testing.pageTest("fixtures/preload_failed.html", .{});
defer page.close();
try client.setBlockedUrls(&.{});
diff --git a/src/browser/ScriptManagerBase.zig b/src/browser/ScriptManagerBase.zig
index 6dbdab3f8..9910b6ed7 100644
--- a/src/browser/ScriptManagerBase.zig
+++ b/src/browser/ScriptManagerBase.zig
@@ -764,7 +764,7 @@ pub const Script = struct {
pub fn dataCallback(transfer: *HttpClient.Transfer, data: []const u8) !void {
const self: *Script = @ptrCast(@alignCast(transfer.req.ctx));
self._dataCallback(transfer, data) catch |err| {
- log.err(.http, "SM.dataCallback", .{ .err = err, .transfer = transfer, .len = data.len });
+ log.debug(.http, "SM.dataCallback", .{ .err = err, .transfer = transfer, .len = data.len });
return err;
};
}
@@ -814,7 +814,7 @@ pub const Script = struct {
.extra = std.meta.activeTag(self.extra),
});
} else {
- log.warn(.http, "script fetch error", .{
+ log.debug(.http, "script fetch error", .{
.err = err,
.req = self.url,
.extra = std.meta.activeTag(self.extra),
@@ -923,7 +923,7 @@ pub const Script = struct {
// Multiple <script type="importmap"> elements merge with first-wins semantics.
if (fe.kind == .importmap) {
self.manager.importmap.merge(frame.arena, frame.base(), self.source.content()) catch |err| {
- log.err(.browser, "parse importmap script", .{
+ log.debug(.browser, "parse importmap script", .{
.err = err,
.src = url,
.kind = fe.kind,
@@ -981,14 +981,14 @@ pub const Script = struct {
const caught = try_catch.caughtOrError(frame.local_arena, error.Unknown);
lp.metrics.script_errors.incr();
- log.warn(.js, "eval script", .{
+ log.debug(.js, "eval script", .{
.url = url,
.caught = caught,
});
if (try_catch.exceptionValue()) |exc| {
frame.window.reportError(exc, frame) catch |err| {
- log.warn(.js, "eval script report error", .{ .url = url, .err = err });
+ log.debug(.js, "eval script report error", .{ .url = url, .err = err });
};
}
@@ -1013,7 +1013,7 @@ pub const Script = struct {
const frame = fe.frame;
const Event = @import("webapi/Event.zig");
const event = Event.initTrusted(typ, .{}, frame.page) catch |err| {
- log.warn(.js, "script internal callback", .{
+ log.debug(.js, "script internal callback", .{
.url = self.url,
.type = typ,
.err = err,
@@ -1021,7 +1021,7 @@ pub const Script = struct {
return;
};
frame._event_manager.dispatch(fe.script_element.asNode().asEventTarget(), event) catch |err| {
- log.warn(.js, "script callback", .{
+ log.debug(.js, "script callback", .{
.url = self.url,
.type = typ,
.err = err,
@@ -1040,7 +1040,7 @@ pub const Script = struct {
// hints only originate from a <link> in a frame, never from a worker
const frame = self.manager.owner.frame;
frame.queueElementEvent(element, kind) catch |err| {
- log.warn(.js, "script hint event", .{ .url = self.url, .kind = kind, .err = err });
+ log.debug(.js, "script hint event", .{ .url = self.url, .kind = kind, .err = err });
};
}
};
@@ -1135,9 +1135,6 @@ test "ScriptManagerBase: import whose submit fails synchronously releases its ar
client.test_fail_submit = error.TestSubmitFailure;
defer client.test_fail_submit = null;
- // Script.errorCallback logs the fetch error.
- testing.expectLog(&.{.http});
-
const url: [:0]const u8 = "http://127.0.0.1:9582/fails-at-submit.js";
try sm.preloadImport(url, frame.url, .{});
@@ -1157,9 +1154,6 @@ test "ScriptManagerBase: dynamic import whose submit fails synchronously rejects
client.test_fail_submit = error.TestSubmitFailure;
defer client.test_fail_submit = null;
- // Script.errorCallback logs the fetch error.
- testing.expectLog(&.{.http});
-
var ls: js.Local.Scope = undefined;
frame.js.localScope(&ls);
defer ls.deinit();
diff --git a/src/browser/Session.zig b/src/browser/Session.zig
index c74dd7b7d..31d0c2732 100644
--- a/src/browser/Session.zig
+++ b/src/browser/Session.zig
@@ -677,7 +677,7 @@ fn processPageQueuedNavigation(self: *Session, page: *Page) !void {
continue;
};
self.processFrameNavigation(frame, qn) catch |err| {
- log.warn(.frame, "frame navigation", .{ .url = qn.url, .err = err });
+ log.debug(.frame, "frame navigation", .{ .url = qn.url, .err = err });
};
}
@@ -690,7 +690,7 @@ fn processPageQueuedNavigation(self: *Session, page: *Page) !void {
const frame = new_navigations.items[i];
if (frame._queued_navigation) |qn| {
if (qn.is_about_something) {
- log.warn(.frame, "recursive about blank", .{});
+ log.debug(.frame, "recursive about blank", .{});
_ = page.queued_navigation.swapRemove(i);
continue;
}
@@ -713,7 +713,7 @@ fn processFrameNavigation(self: *Session, frame: *Frame, qn: *QueuedNavigation)
}
self._processFrameNavigation(frame, qn) catch |err| {
- log.warn(.frame, "frame navigation", .{ .url = qn.url, .err = err });
+ log.debug(.frame, "frame navigation", .{ .url = qn.url, .err = err });
return err;
};
}
@@ -778,7 +778,7 @@ fn _processFrameNavigation(self: *Session, frame: *Frame, qn: *QueuedNavigation)
iframe._window = frame.window;
frame.navigate(qn.url, qn.opts) catch |err| {
- log.err(.browser, "queued frame navigation error", .{ .err = err });
+ log.debug(.browser, "queued frame navigation error", .{ .err = err });
return err;
};
}
@@ -816,7 +816,7 @@ fn processPopupNavigation(_: *Session, frame: *Frame, qn: *QueuedNavigation) !vo
frame.window._opener = saved_opener;
frame.navigate(qn.url, qn.opts) catch |err| {
- log.err(.browser, "queued popup navigation error", .{ .err = err });
+ log.debug(.browser, "queued popup navigation error", .{ .err = err });
return err;
};
}
@@ -861,7 +861,7 @@ fn replaceRootImmediate(self: *Session, frame_id: u32, url: [:0]const u8, opts:
const new_frame = try self.installNewActivePage(frame_id);
new_frame.navigate(url, opts) catch |err| {
- log.err(.browser, "synthetic navigation error", .{ .err = err, .url = url });
+ log.debug(.browser, "synthetic navigation error", .{ .err = err, .url = url });
return err;
};
}
@@ -914,7 +914,7 @@ pub fn initiateRootNavigation(self: *Session, frame_id: u32, url: [:0]const u8,
// commit, after frame_remove tears down the OLD page's context group.
page.frame.navigate(url, opts) catch |err| {
- log.err(.browser, "pending navigation start", .{ .err = err, .url = url });
+ log.debug(.browser, "pending navigation start", .{ .err = err, .url = url });
return err;
};
diff --git a/src/browser/actions.zig b/src/browser/actions.zig
index e7c3384e8..2e1dbce1c 100644
--- a/src/browser/actions.zig
+++ b/src/browser/actions.zig
@@ -29,12 +29,12 @@ const Session = @import("Session.zig");
pub fn dispatchInputAndChangeEvents(el: *Element, frame: *Frame) !void {
const input_evt: *Event = try .initTrusted(comptime .wrap("input"), .{ .bubbles = true }, frame.page);
frame._event_manager.dispatch(el.asEventTarget(), input_evt) catch |err| {
- lp.log.err(.app, "dispatch input event failed", .{ .err = err });
+ lp.log.debug(.app, "dispatch input event failed", .{ .err = err });
};
const change_evt: *Event = try .initTrusted(comptime .wrap("change"), .{ .bubbles = true }, frame.page);
frame._event_manager.dispatch(el.asEventTarget(), change_evt) catch |err| {
- lp.log.err(.app, "dispatch change event failed", .{ .err = err });
+ lp.log.debug(.app, "dispatch change event failed", .{ .err = err });
};
}
@@ -48,7 +48,7 @@ pub fn click(node: *DOMNode, frame: *Frame) !void {
Frame.user_input.updateHoverTarget(frame, el, .{ .with_pointer = true });
Frame.user_input.triggerClick(frame, el, .{}) catch |err| {
- lp.log.err(.app, "click failed", .{ .err = err });
+ lp.log.debug(.app, "click failed", .{ .err = err });
return error.ActionFailed;
};
}
@@ -63,7 +63,7 @@ pub fn hover(node: *DOMNode, frame: *Frame) !void {
}, frame);
frame._event_manager.dispatch(el.asEventTarget(), mouseover_event.asEvent()) catch |err| {
- lp.log.err(.app, "hover mouseover failed", .{ .err = err });
+ lp.log.debug(.app, "hover mouseover failed", .{ .err = err });
return error.ActionFailed;
};
@@ -72,7 +72,7 @@ pub fn hover(node: *DOMNode, frame: *Frame) !void {
}, frame);
frame._event_manager.dispatch(el.asEventTarget(), mouseenter_event.asEvent()) catch |err| {
- lp.log.err(.app, "hover mouseenter failed", .{ .err = err });
+ lp.log.debug(.app, "hover mouseenter failed", .{ .err = err });
return error.ActionFailed;
};
}
@@ -92,7 +92,7 @@ pub fn press(node: ?*DOMNode, key: []const u8, frame: *Frame) !void {
}, frame);
_ = Frame.user_input.pressKey(frame, target, keydown_event, Frame.user_input.textForKey(keydown_event)) catch |err| {
- lp.log.err(.app, "press keydown failed", .{ .err = err });
+ lp.log.debug(.app, "press keydown failed", .{ .err = err });
return error.ActionFailed;
};
@@ -104,7 +104,7 @@ pub fn press(node: ?*DOMNode, key: []const u8, frame: *Frame) !void {
}, frame);
frame._event_manager.dispatch(target.asEventTarget(), keyup_event.asEvent()) catch |err| {
- lp.log.err(.app, "press keyup failed", .{ .err = err });
+ lp.log.debug(.app, "press keyup failed", .{ .err = err });
return error.ActionFailed;
};
}
@@ -141,7 +141,7 @@ pub fn selectOption(node: *DOMNode, value: []const u8, frame: *Frame) !void {
const select = el.is(Element.Html.Select) orelse return error.InvalidNodeType;
select.setValue(value, frame) catch |err| {
- lp.log.err(.app, "select setValue failed", .{ .err = err });
+ lp.log.debug(.app, "select setValue failed", .{ .err = err });
return error.ActionFailed;
};
@@ -171,7 +171,7 @@ pub fn setChecked(node: *DOMNode, checked: bool, frame: *Frame) !void {
try click(node, frame);
if (input.getChecked() != checked) {
- lp.log.err(.app, "setChecked click prevented", .{});
+ lp.log.debug(.app, "setChecked click prevented", .{});
return error.ActionFailed;
}
}
@@ -180,22 +180,22 @@ pub fn fill(node: *DOMNode, text: []const u8, frame: *Frame) !void {
const el = node.is(Element) orelse return error.InvalidNodeType;
el.focus(frame) catch |err| {
- lp.log.err(.app, "fill focus failed", .{ .err = err });
+ lp.log.debug(.app, "fill focus failed", .{ .err = err });
};
if (el.is(Element.Html.Input)) |input| {
input.setValue(text, frame) catch |err| {
- lp.log.err(.app, "fill input failed", .{ .err = err });
+ lp.log.debug(.app, "fill input failed", .{ .err = err });
return error.ActionFailed;
};
} else if (el.is(Element.Html.TextArea)) |textarea| {
textarea.setValue(text, frame) catch |err| {
- lp.log.err(.app, "fill textarea failed", .{ .err = err });
+ lp.log.debug(.app, "fill textarea failed", .{ .err = err });
return error.ActionFailed;
};
} else if (el.is(Element.Html.Select)) |select| {
select.setValue(text, frame) catch |err| {
- lp.log.err(.app, "fill select failed", .{ .err = err });
+ lp.log.debug(.app, "fill select failed", .{ .err = err });
return error.ActionFailed;
};
} else {
@@ -220,7 +220,7 @@ pub const ScrollResult = struct {
pub fn scroll(node: ?*DOMNode, x: ?i32, y: ?i32, frame: *Frame) !ScrollResult {
const n = node orelse {
frame.window.scrollTo(.{ .opts = .{ .left = x, .top = y } }, null, frame) catch |err| {
- lp.log.err(.app, "scroll failed", .{ .err = err });
+ lp.log.debug(.app, "scroll failed", .{ .err = err });
return error.ActionFailed;
};
return .{ .target = .window, .x = frame.window.getScrollX(), .y = frame.window.getScrollY() };
@@ -234,7 +234,7 @@ pub fn scroll(node: ?*DOMNode, x: ?i32, y: ?i32, frame: *Frame) !ScrollResult {
.viewport => el,
};
target.scrollTo(.{ .opts = .{ .left = x, .top = y } }, null, frame) catch |err| {
- lp.log.err(.app, "scroll failed", .{ .err = err });
+ lp.log.debug(.app, "scroll failed", .{ .err = err });
return error.ActionFailed;
};
return .{
diff --git a/src/browser/frame/node_factory.zig b/src/browser/frame/node_factory.zig
index 8774c7d07..41cf0dfab 100644
--- a/src/browser/frame/node_factory.zig
+++ b/src/browser/frame/node_factory.zig
@@ -771,7 +771,7 @@ pub fn createElementNS(document: *const Node.Document, namespace: Element.Namesp
),
asUint("frameset") => {
if (comptime from_parser) {
- log.warn(.not_implemented, "framset", .{ .note = "<framset>...</frameset> in html is not handled properly" });
+ log.debug(.not_implemented, "framset", .{ .note = "<framset>...</frameset> in html is not handled properly" });
}
return createHtmlElementT(
document,
@@ -1005,7 +1005,7 @@ fn constructForToken(frame: *Frame, definition: *CustomElementDefinition, tag_na
const object = ls.toLocal(definition.constructor).newInstanceThrow() catch |err| {
if (err != error.ExecutionTerminated) {
- log.warn(.js, "custom element constructor", .{ .name = name, .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.js, "custom element constructor", .{ .name = name, .err = err, .type = frame._type, .url = frame.url });
if (try_catch.exceptionValue()) |exc| {
// Spec: report the exception
frame.window.reportError(exc, frame) catch {};
@@ -1040,7 +1040,7 @@ fn constructForToken(frame: *Frame, definition: *CustomElementDefinition, tag_na
return element;
};
- log.warn(.js, "custom element not usable", .{ .name = name, .reason = reason, .type = frame._type, .url = frame.url });
+ log.debug(.js, "custom element not usable", .{ .name = name, .reason = reason, .type = frame._type, .url = frame.url });
frame.window.reportError(exc, frame) catch {};
return error.CustomElementConstructionFailed;
}
@@ -1076,7 +1076,7 @@ fn createHtmlElementT(document: *const Node.Document, comptime E: type, namespac
return node;
}
@call(.auto, @field(E.Build, "created"), .{ node, frame }) catch |err| {
- log.err(.frame, "build.created", .{ .tag = node.getNodeName(&frame.buf), .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.frame, "build.created", .{ .tag = node.getNodeName(&frame.buf), .err = err, .type = frame._type, .url = frame.url });
return err;
};
}
diff --git a/src/browser/frame/observers.zig b/src/browser/frame/observers.zig
index 6c1a8fb13..132e6b6d4 100644
--- a/src/browser/frame/observers.zig
+++ b/src/browser/frame/observers.zig
@@ -277,7 +277,7 @@ pub fn deliverResizes(frame: *Frame) void {
frame._resize.delivery_depth = 0;
};
if (frame._resize.delivery_depth > 16) {
- log.warn(.frame, "frame.ResizeLimit", .{ .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.ResizeLimit", .{ .type = frame._type, .url = frame.url });
frame._resize.delivery_depth = 0;
return;
}
@@ -291,7 +291,7 @@ pub fn deliverResizes(frame: *Frame) void {
}
const observer = frame._resize.observers.items[i];
observer.deliverEntries(frame) catch |err| {
- log.err(.frame, "frame.deliverResizes", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.deliverResizes", .{ .err = err, .type = frame._type, .url = frame.url });
if (err == error.ExecutionTerminated) {
return;
}
@@ -338,7 +338,7 @@ fn disconnectRunawayIntersectionObservers(frame: *Frame) void {
// only the crossing itself is logged.
if (!frame._intersection.runaway) {
frame._intersection.runaway = true;
- log.err(.frame, "frame.IntersectionRunaway", .{ .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.IntersectionRunaway", .{ .type = frame._type, .url = frame.url });
}
for (frame._intersection.observers.items) |observer| {
@@ -378,7 +378,7 @@ pub fn deliverIntersections(frame: *Frame) void {
}
const observer = frame._intersection.observers.items[i];
observer.deliverEntries(frame) catch |err| {
- log.err(.frame, "frame.deliverIntersections", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.deliverIntersections", .{ .err = err, .type = frame._type, .url = frame.url });
if (err == error.ExecutionTerminated) {
return;
}
@@ -388,7 +388,7 @@ pub fn deliverIntersections(frame: *Frame) void {
// No observer on the frame can make progress once this path is reached.
fn disconnectRunawayMutationObservers(frame: *Frame) void {
- log.err(.frame, "frame.MutationRunaway", .{ .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.MutationRunaway", .{ .type = frame._type, .url = frame.url });
var node: ?*std.DoublyLinkedList.Node = frame._mutation.observers.first;
while (node) |n| {
@@ -423,7 +423,7 @@ pub fn deliverMutations(frame: *Frame) void {
};
if (frame._mutation.delivery_depth > 16) {
- log.err(.frame, "frame.MutationLimit", .{ .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.MutationLimit", .{ .type = frame._type, .url = frame.url });
frame._mutation.delivery_depth = 0;
capped = true;
return;
@@ -456,7 +456,7 @@ pub fn deliverMutations(frame: *Frame) void {
for (notify.items) |observer| {
observer.deliverRecords(frame) catch |err| {
- log.err(.frame, "frame.deliverMutations", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.frame, "frame.deliverMutations", .{ .err = err, .type = frame._type, .url = frame.url });
if (err == error.ExecutionTerminated) {
return;
}
@@ -471,7 +471,7 @@ pub fn deliverMutations(frame: *Frame) void {
};
const target = slot.asNode().asEventTarget();
frame._event_manager.dispatch(target, event) catch |err| {
- log.err(.frame, "deliverSlotchange.dispatch", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.frame, "deliverSlotchange.dispatch", .{ .err = err, .type = frame._type, .url = frame.url });
if (err == error.ExecutionTerminated) {
return;
}
diff --git a/src/browser/frame/resource_load.zig b/src/browser/frame/resource_load.zig
index 3edae3cfa..e05c2b17b 100644
--- a/src/browser/frame/resource_load.zig
+++ b/src/browser/frame/resource_load.zig
@@ -105,7 +105,7 @@ pub fn image(frame: *Frame, img: *Element.Html.Image, src: []const u8) !void {
// already routed the failure through error_callback, which settles the
// ImageLoad and gives the pending-load slot back.
transfer.submit() catch |err| {
- log.warn(.http, "image fetch", .{ .err = err, .url = resolved });
+ log.debug(.http, "image fetch", .{ .err = err, .url = resolved });
};
}
diff --git a/src/browser/frame/user_input.zig b/src/browser/frame/user_input.zig
index b42241d46..1d17412bd 100644
--- a/src/browser/frame/user_input.zig
+++ b/src/browser/frame/user_input.zig
@@ -151,11 +151,11 @@ fn dispatchBoundaryEvent(frame: *Frame, target: *Element, comptime mouse_typ: []
.altKey = modifiers.alt,
.metaKey = modifiers.meta,
}, frame) catch |err| {
- log.warn(.frame, "boundary pointer event", .{ .err = err, .type = pointer_typ });
+ log.debug(.frame, "boundary pointer event", .{ .err = err, .type = pointer_typ });
return;
};
frame._event_manager.dispatch(target.asEventTarget(), pointer_event.asEvent()) catch |err| {
- log.warn(.frame, "boundary pointer dispatch", .{ .err = err, .type = pointer_typ });
+ log.debug(.frame, "boundary pointer dispatch", .{ .err = err, .type = pointer_typ });
};
}
@@ -172,11 +172,11 @@ fn dispatchBoundaryEvent(frame: *Frame, target: *Element, comptime mouse_typ: []
.altKey = modifiers.alt,
.metaKey = modifiers.meta,
}, frame) catch |err| {
- log.warn(.frame, "boundary mouse event", .{ .err = err, .type = mouse_typ });
+ log.debug(.frame, "boundary mouse event", .{ .err = err, .type = mouse_typ });
return;
};
frame._event_manager.dispatch(target.asEventTarget(), mouse_event.asEvent()) catch |err| {
- log.warn(.frame, "boundary mouse dispatch", .{ .err = err, .type = mouse_typ });
+ log.debug(.frame, "boundary mouse dispatch", .{ .err = err, .type = mouse_typ });
};
}
@@ -320,7 +320,7 @@ fn dispatchPointerRelease(frame: *Frame, target: *Element, in: PointerInput, sup
pub fn triggerClick(frame: *Frame, target: *Element, modifiers: Modifiers) !void {
const press = try dispatchPointerPress(frame, target, .{ .x = 0, .y = 0, .buttons = 1, .detail = 1, .modifiers = modifiers });
if (press.suppress_focus == false) {
- focusForMouseDown(frame, target) catch |err| log.warn(.app, "click mousedown focus", .{ .err = err });
+ focusForMouseDown(frame, target) catch |err| log.debug(.app, "click mousedown focus", .{ .err = err });
}
const up: PointerInput = .{ .x = 0, .y = 0, .detail = 1, .modifiers = modifiers };
@@ -656,11 +656,11 @@ const JavascriptUrlTask = struct {
defer ls.deinit();
const script = ls.local.compile(self.source, "javascript:") catch |err| {
- log.warn(.browser, "javascript-url compile", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.browser, "javascript-url compile", .{ .err = err, .type = frame._type, .url = frame.url });
return null;
};
_ = script.run() catch |err| {
- log.warn(.browser, "javascript-url run", .{ .err = err, .type = frame._type, .url = frame.url });
+ log.debug(.browser, "javascript-url run", .{ .err = err, .type = frame._type, .url = frame.url });
};
return null;
}
@@ -767,7 +767,7 @@ fn followLink(frame: *Frame, target: *Node, element: *Element, href: []const u8,
}
if (try element.hasAttribute(comptime .wrap("download"), frame)) {
- log.warn(.browser, "a.download", .{ .type = frame._type, .url = frame.url });
+ log.debug(.browser, "a.download", .{ .type = frame._type, .url = frame.url });
return;
}
@@ -838,7 +838,7 @@ pub fn pressKey(frame: *Frame, target: *Element, keydown: *KeyboardEvent, text:
}
// logged like a default action's failure, not the key event's
typeChar(frame, target, try keypressFor(frame, keydown), t) catch |err| {
- log.warn(.frame, "frame.keypress", .{ .err = err });
+ log.debug(.frame, "frame.keypress", .{ .err = err });
};
return false;
}
diff --git a/src/browser/js/Context.zig b/src/browser/js/Context.zig
index d3ef6154b..7469f240e 100644
--- a/src/browser/js/Context.zig
+++ b/src/browser/js/Context.zig
@@ -423,7 +423,7 @@ fn evaluateModule(self: *Context, comptime want_result: bool, mod: js.Module, ur
break :blk buf.written();
};
- log.warn(.js, "evaluate module", .{
+ log.debug(.js, "evaluate module", .{
.stack = stack,
.specifier = url,
.message = message,
@@ -582,7 +582,7 @@ fn resolveModuleCallback(
if (err == error.SpecifierResolutionFailed) {
_ = self.isolate.throwException(self.isolate.createTypeError("Failed to resolve module specifier"));
}
- log.err(.js, "resolve module", .{
+ log.debug(.js, "resolve module", .{
.err = err,
.specifier = specifier,
});
@@ -638,7 +638,7 @@ pub fn dynamicModuleCallback(
};
const promise = self._dynamicModuleCallback(normalized_specifier, resource, &local) catch |err| blk: {
- log.err(.js, "dynamic module callback", .{
+ log.debug(.js, "dynamic module callback", .{
.err = err,
});
break :blk local.rejectPromise(.{ .generic_error = "Out of memory" });
@@ -941,7 +941,7 @@ fn dynamicModuleSourceCallback(ctx: *anyopaque, module_source_: anyerror!ScriptM
break :blk self.module(true, local, ms.src(), state.specifier, true) catch |err| {
const caught = try_catch.caughtOrError(self.local_arena, err);
- log.err(.js, "module compilation failed", .{
+ log.debug(.js, "module compilation failed", .{
.caught = caught,
.specifier = state.specifier,
});
diff --git a/src/browser/js/Env.zig b/src/browser/js/Env.zig
index 676214657..eea42d88f 100644
--- a/src/browser/js/Env.zig
+++ b/src/browser/js/Env.zig
@@ -749,7 +749,7 @@ fn promiseRejectCallback(message_handle: v8.PromiseRejectMessage) callconv(.c) v
.local = &local,
.handle = &message_handle,
}, frame) catch |err| {
- log.warn(.browser, "unhandled rejection handler", .{ .err = err, .target = "window" });
+ log.debug(.browser, "unhandled rejection handler", .{ .err = err, .target = "window" });
};
},
.worker => |wsg| {
@@ -757,7 +757,7 @@ fn promiseRejectCallback(message_handle: v8.PromiseRejectMessage) callconv(.c) v
.local = &local,
.handle = &message_handle,
}) catch |err| {
- log.warn(.browser, "unhandled rejection handler", .{ .err = err, .target = "worker" });
+ log.debug(.browser, "unhandled rejection handler", .{ .err = err, .target = "worker" });
};
},
}
diff --git a/src/browser/js/Function.zig b/src/browser/js/Function.zig
index 4deb9336a..4d08c5524 100644
--- a/src/browser/js/Function.zig
+++ b/src/browser/js/Function.zig
@@ -103,7 +103,7 @@ pub fn newInstanceThrow(self: *const Function) !js.Object {
pub fn call(self: *const Function, comptime T: type, args: anytype) !T {
var caught: js.TryCatch.Caught = .{};
return self._tryCallWithThis(T, self.getThis(), args, &caught, .{}) catch |err| {
- log.warn(.js, "call caught", .{ .err = err, .caught = caught });
+ log.debug(.js, "call caught", .{ .err = err, .caught = caught });
return err;
};
}
@@ -114,7 +114,7 @@ pub fn callRethrow(self: *const Function, comptime T: type, args: anytype) !T {
if (err != error.TryCatchRethrow) {
// error.TryCatchRethrow is a control flow (sorry!), not an actual
// error we want to log
- log.warn(.js, "call caught", .{ .err = err, .caught = caught });
+ log.debug(.js, "call caught", .{ .err = err, .caught = caught });
}
return err;
};
@@ -123,7 +123,7 @@ pub fn callRethrow(self: *const Function, comptime T: type, args: anytype) !T {
pub fn callWithThis(self: *const Function, comptime T: type, this: anytype, args: anytype) !T {
var caught: js.TryCatch.Caught = .{};
return self._tryCallWithThis(T, this, args, &caught, .{}) catch |err| {
- log.warn(.js, "callWithThis caught", .{ .err = err, .caught = caught });
+ log.debug(.js, "callWithThis caught", .{ .err = err, .caught = caught });
return err;
};
}
diff --git a/src/browser/js/Scheduler.zig b/src/browser/js/Scheduler.zig
index ae86e05a4..9e918f043 100644
--- a/src/browser/js/Scheduler.zig
+++ b/src/browser/js/Scheduler.zig
@@ -127,7 +127,7 @@ pub fn run(self: *Scheduler) !void {
self.generation +%= 1;
const repeat_in_ms = task.callback(task.ctx) catch |err| {
- log.warn(.scheduler, "task.callback", .{ .name = task.name, .err = err });
+ log.debug(.scheduler, "task.callback", .{ .name = task.name, .err = err });
continue;
};
diff --git a/src/browser/js/WasmStreaming.zig b/src/browser/js/WasmStreaming.zig
index 38d4bb9e1..94cb495fd 100644
--- a/src/browser/js/WasmStreaming.zig
+++ b/src/browser/js/WasmStreaming.zig
@@ -128,7 +128,7 @@ fn abortZigError(self: *WasmStreaming, local: *const js.Local, err: anyerror) vo
env.error_message = null;
},
else => {
- log.err(.js, "wasm streaming", .{ .err = err });
+ log.debug(.js, "wasm streaming", .{ .err = err });
self.abort(local.isolate.createError(@errorName(err)));
},
}
diff --git a/src/browser/links.zig b/src/browser/links.zig
index e9ef4a39d..b2d2b36ad 100644
--- a/src/browser/links.zig
+++ b/src/browser/links.zig
@@ -73,7 +73,7 @@ pub fn collectLinks(arena: Allocator, root: *Node, frame: *Frame) ![]Link {
if (!el.isVisible(frame)) continue;
const href = anchor.getHref(frame) catch |err| {
- log.err(.app, "resolve href failed", .{ .err = err });
+ log.debug(.app, "resolve href failed", .{ .err = err });
continue;
};
if (href.len == 0) continue;
@@ -90,7 +90,7 @@ pub fn collectLinks(arena: Allocator, root: *Node, frame: *Frame) ![]Link {
};
}
} else |err| {
- log.err(.app, "query links failed", .{ .err = err });
+ log.debug(.app, "query links failed", .{ .err = err });
return err;
}
diff --git a/src/browser/parser/Parser.zig b/src/browser/parser/Parser.zig
index 286b2d7cb..f33dcbd53 100644
--- a/src/browser/parser/Parser.zig
+++ b/src/browser/parser/Parser.zig
@@ -454,7 +454,7 @@ pub const Streaming = struct {
h5e.html5ever_streaming_parser_finish(handle);
if (self.pending_input.items.len != 0) {
- lp.log.warn(.dom, "write during finish dropped", .{ .len = self.pending_input.items.len });
+ lp.log.debug(.dom, "write during finish dropped", .{ .len = self.pending_input.items.len });
self.pending_input.clearRetainingCapacity();
}
try self.parser.flushPendingText();
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index 7de1f3263..87fe70a2a 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -1213,7 +1213,7 @@ fn execSearch(arena: std.mem.Allocator, arguments: ?std.json.Value) ToolError!To
last_err = err;
last_label = @tagName(engine.tag);
last_detail = detail;
- log.warn(.browser, @tagName(engine.tag) ++ " fallback", .{ .err = err });
+ log.debug(.browser, @tagName(engine.tag) ++ " fallback", .{ .err = err });
}
} else |_| {}
}
@@ -1292,7 +1292,7 @@ fn apiSearch(
var response = client.search(query, engine.options) catch |err| {
if (client.last_error.status) |status| {
- log.warn(.browser, @tagName(engine.tag) ++ " non-2xx", .{
+ log.debug(.browser, @tagName(engine.tag) ++ " non-2xx", .{
.status = status,
.message = client.last_error.message,
});
@@ -2309,7 +2309,7 @@ fn lookupLpEnv(name: []const u8) ?[:0]const u8 {
if (!std.mem.startsWith(u8, name, "LP_")) return null;
var name_buf: [256]u8 = undefined;
if (name.len >= name_buf.len) {
- log.warn(.browser, "getEnv name too long", .{ .name_len = name.len, .limit = name_buf.len - 1 });
+ log.debug(.browser, "getEnv name too long", .{ .name_len = name.len, .limit = name_buf.len - 1 });
return null;
}
@memcpy(name_buf[0..name.len], name);
@@ -3029,7 +3029,6 @@ test "isPathSafe: absolute paths and traversal are rejected" {
}
test "markdown: a same-url page whose navigation failed is navigated again" {
- testing.expectLog(&.{ .frame, .frame });
var registry: NodeRegistry = .init(std.testing.allocator);
defer registry.deinit();
diff --git a/src/browser/webapi/AbortSignal.zig b/src/browser/webapi/AbortSignal.zig
index 30e569726..82d1c16d7 100644
--- a/src/browser/webapi/AbortSignal.zig
+++ b/src/browser/webapi/AbortSignal.zig
@@ -126,7 +126,7 @@ pub fn abort(self: *AbortSignal, reason_: ?Reason, exec: *const Execution) !void
try self.dispatchAbortEvent(exec);
for (to_dispatch.items) |dep| {
dep.dispatchAbortEvent(exec) catch |err| {
- log.warn(.app, "abort dependent dispatch", .{ .err = err });
+ log.debug(.app, "abort dependent dispatch", .{ .err = err });
};
}
}
@@ -272,7 +272,7 @@ const TimeoutCallback = struct {
fn run(ctx: *anyopaque) !?u32 {
const self: *TimeoutCallback = @ptrCast(@alignCast(ctx));
self.timeoutAbort() catch |err| {
- log.warn(.app, "abort signal timeout", .{ .err = err });
+ log.debug(.app, "abort signal timeout", .{ .err = err });
};
return null;
}
diff --git a/src/browser/webapi/BroadcastChannel.zig b/src/browser/webapi/BroadcastChannel.zig
index 22c53f14a..0b956c77d 100644
--- a/src/browser/webapi/BroadcastChannel.zig
+++ b/src/browser/webapi/BroadcastChannel.zig
@@ -218,12 +218,12 @@ const PostMessageCallback = struct {
// MessageEvent, which releases it on teardown — so each receiver
// frees only its own handle.
const cloned = snapshot.structuredCloneTo(&ls.local) catch |err| {
- log.err(.dom, "BroadcastChannel.postMessage", .{ .err = err });
+ log.debug(.dom, "BroadcastChannel.postMessage", .{ .err = err });
continue;
};
const cloned_temp = cloned.persist() catch |err| {
- log.err(.dom, "BroadcastChannel.postMessage", .{ .err = err });
+ log.debug(.dom, "BroadcastChannel.postMessage", .{ .err = err });
continue;
};
@@ -233,12 +233,12 @@ const PostMessageCallback = struct {
.source = null,
}, exec.page) catch |err| {
cloned_temp.release();
- log.err(.dom, "BroadcastChannel.postMessage", .{ .err = err });
+ log.debug(.dom, "BroadcastChannel.postMessage", .{ .err = err });
continue;
}).asEvent();
exec.dispatch(target, event, channel._on_message, .{ .context = "BroadcastChannel message" }) catch |err| {
- log.err(.dom, "BroadcastChannel.postMessage", .{ .err = err });
+ log.debug(.dom, "BroadcastChannel.postMessage", .{ .err = err });
};
}
}
diff --git a/src/browser/webapi/CustomElementRegistry.zig b/src/browser/webapi/CustomElementRegistry.zig
index 4472f2813..cfa534545 100644
--- a/src/browser/webapi/CustomElementRegistry.zig
+++ b/src/browser/webapi/CustomElementRegistry.zig
@@ -249,7 +249,7 @@ pub fn upgradeCustomElement(custom: *Custom, definition: *CustomElementDefinitio
custom._definition = null;
return err;
}
- log.warn(.js, "custom element upgrade", .{ .name = definition.name, .err = err });
+ log.debug(.js, "custom element upgrade", .{ .name = definition.name, .err = err });
upgradeFailed(custom);
if (try_catch.exceptionValue()) |exc| {
frame.window.reportError(exc, frame) catch {};
@@ -260,7 +260,7 @@ pub fn upgradeCustomElement(custom: *Custom, definition: *CustomElementDefinitio
const same = if (object.toZig(*Node)) |result| result == node else |_| false;
if (!same) {
// the construction result must be the element being upgraded.
- log.warn(.js, "custom element upgrade", .{ .name = definition.name, .reason = "constructor returned another value" });
+ log.debug(.js, "custom element upgrade", .{ .name = definition.name, .reason = "constructor returned another value" });
upgradeFailed(custom);
const exc: js.Value = .{
.local = local,
@@ -344,6 +344,5 @@ pub const JsApi = struct {
const testing = @import("../../testing.zig");
test "WebApi: CustomElementRegistry" {
- testing.expectLog(&.{ .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js, .js });
try testing.htmlRunner("custom_elements", .{});
}
diff --git a/src/browser/webapi/DedicatedWorkerGlobalScope.zig b/src/browser/webapi/DedicatedWorkerGlobalScope.zig
index c333d6c38..a8318c1e7 100644
--- a/src/browser/webapi/DedicatedWorkerGlobalScope.zig
+++ b/src/browser/webapi/DedicatedWorkerGlobalScope.zig
@@ -172,7 +172,7 @@ fn scheduleMessage(self: *DedicatedWorkerGlobalScope, cloned_data: ?js.Value.Glo
pub fn drainPendingMessages(self: *DedicatedWorkerGlobalScope) void {
for (self._pending_messages.items) |cloned_data| {
self.scheduleMessage(cloned_data) catch |err| {
- lp.log.warn(.browser, "worker drain msg failed", .{ .err = err });
+ lp.log.debug(.browser, "worker drain msg failed", .{ .err = err });
if (cloned_data) |d| d.release();
};
}
diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zig
index c2d6b30c9..bdc09cca3 100644
--- a/src/browser/webapi/Document.zig
+++ b/src/browser/webapi/Document.zig
@@ -431,7 +431,7 @@ fn createAttribute(self: *const Document, name: String.Global, frame: *Frame) !?
pub fn createAttributeNS(self: *const Document, namespace: []const u8, name: String.Global, frame: *Frame) !?*Element.Attribute {
if (std.mem.eql(u8, namespace, "http://www.w3.org/1999/xhtml") == false) {
- log.warn(.not_implemented, "document.createAttributeNS", .{ .namespace = namespace });
+ log.debug(.not_implemented, "document.createAttributeNS", .{ .namespace = namespace });
}
try Element.Attribute.validateAttributeName(name.str);
diff --git a/src/browser/webapi/Element.zig b/src/browser/webapi/Element.zig
index 9f7462331..7b963a227 100644
--- a/src/browser/webapi/Element.zig
+++ b/src/browser/webapi/Element.zig
@@ -2232,11 +2232,11 @@ const ScrollEventTask = struct {
fn dispatchEvent(self: *ScrollEventTask, comptime event_type: String) void {
const Event = @import("Event.zig");
const event = Event.initTrusted(event_type, .{ .bubbles = self.bubbles() }, self.frame.page) catch |err| {
- log.warn(.dom, "element.scroll.event", .{ .err = err });
+ log.debug(.dom, "element.scroll.event", .{ .err = err });
return;
};
self.frame._event_manager.dispatch(self.eventTarget(), event) catch |err| {
- log.warn(.dom, "element.scroll.dispatch", .{ .err = err });
+ log.debug(.dom, "element.scroll.dispatch", .{ .err = err });
};
}
};
diff --git a/src/browser/webapi/IntersectionObserver.zig b/src/browser/webapi/IntersectionObserver.zig
index 169ff0dfd..4907702bb 100644
--- a/src/browser/webapi/IntersectionObserver.zig
+++ b/src/browser/webapi/IntersectionObserver.zig
@@ -326,7 +326,7 @@ pub fn deliverEntries(self: *IntersectionObserver, frame: *Frame) !void {
defer ls.deinit();
ls.toLocal(self._callback).tryCall(void, .{ entries, self }, &caught) catch |err| {
- log.err(.frame, "IntsctObserver.deliverEntries", .{ .err = err, .caught = caught });
+ log.debug(.frame, "IntsctObserver.deliverEntries", .{ .err = err, .caught = caught });
return err;
};
}
diff --git a/src/browser/webapi/MessagePort.zig b/src/browser/webapi/MessagePort.zig
index b9b4e8bde..86aea188f 100644
--- a/src/browser/webapi/MessagePort.zig
+++ b/src/browser/webapi/MessagePort.zig
@@ -116,7 +116,7 @@ pub fn start(self: *MessagePort) void {
for (self._pending.items) |message| {
self.scheduleDelivery(message) catch |err| {
- log.warn(.dom, "MessagePort.start drain", .{ .err = err });
+ log.debug(.dom, "MessagePort.start drain", .{ .err = err });
message.release();
};
}
@@ -219,12 +219,12 @@ const DeliverCallback = struct {
.source = null,
}, exec.page) catch |err| {
self.message.release();
- log.err(.dom, "MessagePort.postMessage", .{ .err = err });
+ log.debug(.dom, "MessagePort.postMessage", .{ .err = err });
return null;
}).asEvent();
exec.dispatch(target, event, port._on_message, .{ .context = "MessagePort message" }) catch |err| {
- log.err(.dom, "MessagePort.postMessage", .{ .err = err });
+ log.debug(.dom, "MessagePort.postMessage", .{ .err = err });
};
return null;
diff --git a/src/browser/webapi/MutationObserver.zig b/src/browser/webapi/MutationObserver.zig
index ccc690718..41b3e3167 100644
--- a/src/browser/webapi/MutationObserver.zig
+++ b/src/browser/webapi/MutationObserver.zig
@@ -364,7 +364,7 @@ pub fn deliverRecords(self: *MutationObserver, frame: *Frame) !void {
var caught: js.TryCatch.Caught = .{};
ls.toLocal(self._callback).tryCallWithThis(void, self, .{ records, self }, &caught) catch |err| {
- log.err(.frame, "MutObserver.deliverRecords", .{ .err = err, .caught = caught });
+ log.debug(.frame, "MutObserver.deliverRecords", .{ .err = err, .caught = caught });
return err;
};
}
@@ -481,7 +481,6 @@ pub const JsApi = struct {
const testing = @import("../../testing.zig");
test "WebApi: MutationObserver" {
- testing.expectLog(&.{ .frame, .frame });
try testing.htmlRunner("mutation_observer", .{});
}
@@ -527,7 +526,6 @@ test "WebApi: runaway MutationObserver delivery is disconnected" {
// and leave the observer machinery usable after a top-level cancel.
test "WebApi: MutationObserver requested termination unwinds delivery" {
const v8 = js.v8;
- testing.expectLog(&.{ .frame, .frame });
const frame = try testing.createFrame();
defer testing.test_session.closeAllPages();
@@ -588,8 +586,6 @@ test "WebApi: MutationObserver requested termination unwinds delivery" {
}
test "WebApi: MutationObserver terminate requested between observers releases records" {
- testing.expectLog(&.{ .frame, .frame });
-
const frame = try testing.createFrame();
defer testing.test_session.closeAllPages();
@@ -627,8 +623,6 @@ test "WebApi: MutationObserver terminate requested between observers releases re
}
test "WebApi: MutationObserver terminated page tears down" {
- testing.expectLog(&.{ .frame, .frame });
-
const frame = try testing.createFrame();
const env = frame.js.env;
defer env.cancelTerminate();
diff --git a/src/browser/webapi/Performance.zig b/src/browser/webapi/Performance.zig
index 16ce09cf2..a4bc5d509 100644
--- a/src/browser/webapi/Performance.zig
+++ b/src/browser/webapi/Performance.zig
@@ -576,7 +576,7 @@ fn notifyObservers(self: *Performance, entry: *Entry) !void {
for (self._observers.items) |observer| {
if (observer.interested(entry)) {
observer._entries.append(observer._arena, entry) catch |err| {
- lp.log.err(.frame, "Performance.notifyObservers", .{ .err = err });
+ lp.log.debug(.frame, "Performance.notifyObservers", .{ .err = err });
};
}
}
diff --git a/src/browser/webapi/PerformanceObserver.zig b/src/browser/webapi/PerformanceObserver.zig
index d7a44c5b6..b8d49f809 100644
--- a/src/browser/webapi/PerformanceObserver.zig
+++ b/src/browser/webapi/PerformanceObserver.zig
@@ -200,7 +200,7 @@ pub fn dispatch(self: *PerformanceObserver) !void {
var caught: js.TryCatch.Caught = .{};
ls.toLocal(self._callback).tryCall(void, .{ EntryList{ ._entries = records }, self }, &caught) catch |err| {
- log.err(.frame, "PerfObserver.dispatch", .{ .err = err, .caught = caught });
+ log.debug(.frame, "PerfObserver.dispatch", .{ .err = err, .caught = caught });
return err;
};
}
diff --git a/src/browser/webapi/ResizeObserver.zig b/src/browser/webapi/ResizeObserver.zig
index 14f33caab..b839ce157 100644
--- a/src/browser/webapi/ResizeObserver.zig
+++ b/src/browser/webapi/ResizeObserver.zig
@@ -190,7 +190,7 @@ pub fn deliverEntries(self: *ResizeObserver, frame: *Frame) !void {
defer ls.deinit();
ls.toLocal(self._callback).tryCall(void, .{ entries.items, self }, &caught) catch |err| {
- log.err(.frame, "ResizeObserver.deliverEntries", .{ .err = err, .caught = caught });
+ log.debug(.frame, "ResizeObserver.deliverEntries", .{ .err = err, .caught = caught });
return err;
};
}
diff --git a/src/browser/webapi/Sanitizer.zig b/src/browser/webapi/Sanitizer.zig
index bff530f86..2472f91d9 100644
--- a/src/browser/webapi/Sanitizer.zig
+++ b/src/browser/webapi/Sanitizer.zig
@@ -1425,6 +1425,5 @@ pub const JsApi = struct {
const testing = @import("../../testing.zig");
test "WebApi: Sanitizer" {
- testing.expectLog(&.{.js});
try testing.htmlRunner("sanitizer.html", .{});
}
diff --git a/src/browser/webapi/ServiceWorker.zig b/src/browser/webapi/ServiceWorker.zig
index e236e11f4..601cac38e 100644
--- a/src/browser/webapi/ServiceWorker.zig
+++ b/src/browser/webapi/ServiceWorker.zig
@@ -101,7 +101,7 @@ pub fn stateChanged(self: *ServiceWorker) void {
}
self.scheduleStateChange() catch |err| {
- log.warn(.browser, "SW statechange", .{ .err = err });
+ log.debug(.browser, "SW statechange", .{ .err = err });
};
}
diff --git a/src/browser/webapi/ServiceWorkerContainer.zig b/src/browser/webapi/ServiceWorkerContainer.zig
index cb133629f..d60a4279d 100644
--- a/src/browser/webapi/ServiceWorkerContainer.zig
+++ b/src/browser/webapi/ServiceWorkerContainer.zig
@@ -88,7 +88,7 @@ pub fn workerActivated(self: *ServiceWorkerContainer) void {
}
self.scheduleReady() catch |err| {
- log.warn(.browser, "SWC ready", .{ .err = err });
+ log.debug(.browser, "SWC ready", .{ .err = err });
};
}
@@ -139,7 +139,7 @@ pub fn register(self: *ServiceWorkerContainer, url: []const u8, options: ?Regist
};
const scope = ServiceWorkerGlobalScope.getOrCreate(frame, script_url, scope_url, opts.type) catch |err| {
- log.err(.browser, "SWC register", .{ .url = script_url, .err = err });
+ log.debug(.browser, "SWC register", .{ .url = script_url, .err = err });
resolver.rejectError("ServiceWorkerContainer.register", .{ .type_error = "Failed to register a ServiceWorker" });
return resolver.promise();
};
diff --git a/src/browser/webapi/ServiceWorkerGlobalScope.zig b/src/browser/webapi/ServiceWorkerGlobalScope.zig
index 0417624b9..a88091470 100644
--- a/src/browser/webapi/ServiceWorkerGlobalScope.zig
+++ b/src/browser/webapi/ServiceWorkerGlobalScope.zig
@@ -131,12 +131,12 @@ fn init(
.error_callback = httpErrorCallback,
.shutdown_callback = httpShutdownCallback,
}) catch |err| {
- log.err(.browser, "SWGS request", .{ .url = owned_url, .err = err });
+ log.debug(.browser, "SWGS request", .{ .url = owned_url, .err = err });
return err;
};
self._script_load.?.transfer = transfer;
transfer.submit() catch |err| {
- log.err(.browser, "SWGS request", .{ .url = owned_url, .err = err });
+ log.debug(.browser, "SWGS request", .{ .url = owned_url, .err = err });
return err;
};
return self;
@@ -224,7 +224,7 @@ fn httpHeaderCallback(transfer: *Transfer) !Transfer.HeaderResult {
const status = transfer.responseStatus() orelse return .abort;
if (status < 200 or status >= 300) {
- log.warn(.browser, "SWGS status", .{ .url = self._proto.url, .status = status });
+ log.debug(.browser, "SWGS status", .{ .url = self._proto.url, .status = status });
return .abort;
}
@@ -266,7 +266,7 @@ fn httpErrorCallback(ctx: *anyopaque, err: anyerror) void {
self.releaseScriptLoad();
if (err != error.TransferCanceled) {
- log.err(.browser, "SWGS fetch error", .{ .url = self._proto.url, .err = err });
+ log.debug(.browser, "SWGS fetch error", .{ .url = self._proto.url, .err = err });
}
self.setState(.redundant);
@@ -303,7 +303,7 @@ fn loadInitialScript(self: *ServiceWorkerGlobalScope, script: []const u8) !void
}
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_load.?.arena.allocator(), err);
- log.err(.browser, "SWGS module error", .{ .url = url, .caught = caught });
+ log.debug(.browser, "SWGS module error", .{ .url = url, .caught = caught });
evaluated = false;
};
} else {
@@ -313,7 +313,7 @@ fn loadInitialScript(self: *ServiceWorkerGlobalScope, script: []const u8) !void
}
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_load.?.arena.allocator(), err);
- log.err(.browser, "SWGS script error", .{ .url = url, .caught = caught });
+ log.debug(.browser, "SWGS script error", .{ .url = url, .caught = caught });
evaluated = false;
};
}
@@ -347,7 +347,7 @@ fn beginInstall(self: *ServiceWorkerGlobalScope) void {
s.beginActivate();
}
}.done) catch |err| {
- log.warn(.browser, "SWGS install", .{ .url = self._proto.url, .err = err });
+ log.debug(.browser, "SWGS install", .{ .url = self._proto.url, .err = err });
self.beginActivate();
};
}
@@ -365,7 +365,7 @@ fn beginActivate(self: *ServiceWorkerGlobalScope) void {
s.finishActivation();
}
}.done) catch |err| {
- log.warn(.browser, "SWGS activate", .{ .url = self._proto.url, .err = err });
+ log.debug(.browser, "SWGS activate", .{ .url = self._proto.url, .err = err });
self.finishActivation();
};
}
@@ -480,7 +480,7 @@ fn scheduleMessage(self: *ServiceWorkerGlobalScope, cloned_data: ?js.Value.Globa
fn drainPendingMessages(self: *ServiceWorkerGlobalScope) void {
for (self._pending_messages.items) |cloned_data| {
self.scheduleMessage(cloned_data) catch |err| {
- log.warn(.browser, "SWGS drain msg failed", .{ .err = err });
+ log.debug(.browser, "SWGS drain msg failed", .{ .err = err });
if (cloned_data) |d| {
d.release();
}
diff --git a/src/browser/webapi/ServiceWorkerRegistration.zig b/src/browser/webapi/ServiceWorkerRegistration.zig
index 60fd42079..56b5fae6c 100644
--- a/src/browser/webapi/ServiceWorkerRegistration.zig
+++ b/src/browser/webapi/ServiceWorkerRegistration.zig
@@ -119,7 +119,7 @@ pub fn getUpdateViaCache(_: *const ServiceWorkerRegistration) []const u8 {
}
pub fn update(_: *ServiceWorkerRegistration, exec: *const Execution) !js.Promise {
- log.warn(.not_implemented, "SWR.update", .{});
+ log.debug(.not_implemented, "SWR.update", .{});
const resolver = exec.js.local.?.createPromiseResolver();
resolver.resolve("ServiceWorkerRegistration.update", {});
return resolver.promise();
diff --git a/src/browser/webapi/SharedWorkerGlobalScope.zig b/src/browser/webapi/SharedWorkerGlobalScope.zig
index 3e6ff0cb6..06a8e1bed 100644
--- a/src/browser/webapi/SharedWorkerGlobalScope.zig
+++ b/src/browser/webapi/SharedWorkerGlobalScope.zig
@@ -107,7 +107,7 @@ pub fn init(frame: *Frame, url: [:0]const u8, name: []const u8, worker_type: Wor
.error_callback = httpErrorCallback,
.shutdown_callback = httpShutdownCallback,
}) catch |err| {
- log.err(.browser, "SharedWorker request", .{ .url = owned_url, .err = err });
+ log.debug(.browser, "SharedWorker request", .{ .url = owned_url, .err = err });
return err;
};
@@ -117,7 +117,7 @@ pub fn init(frame: *Frame, url: [:0]const u8, name: []const u8, worker_type: Wor
self._http_transfer = transfer;
transfer.submit() catch |err| {
- log.err(.browser, "SharedWorker request", .{ .url = owned_url, .err = err });
+ log.debug(.browser, "SharedWorker request", .{ .url = owned_url, .err = err });
return err;
};
return self;
@@ -195,7 +195,7 @@ fn httpHeaderCallback(transfer: *Transfer) !Transfer.HeaderResult {
const status = transfer.responseStatus() orelse return .abort;
if (status < 200 or status >= 300) {
- log.warn(.browser, "SharedWorker status", .{
+ log.debug(.browser, "SharedWorker status", .{
.url = self._url,
.status = status,
});
@@ -244,7 +244,7 @@ fn httpErrorCallback(ctx: *anyopaque, err: anyerror) void {
// TransferCanceled is teardown cancelling a still-inflight script fetch,
// not a load failure.
if (err != error.TransferCanceled) {
- log.err(.browser, "shared worker fetch error", .{
+ log.debug(.browser, "shared worker fetch error", .{
.url = self._url,
.err = err,
});
@@ -289,7 +289,7 @@ fn loadInitialScript(self: *SharedWorkerGlobalScope, script: []const u8) !void {
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);
- log.err(.browser, "shared worker script error", .{ .url = self._url, .caught = caught });
+ log.debug(.browser, "shared worker script error", .{ .url = self._url, .caught = caught });
return;
},
.module => js_context.module(false, &ls.local, script, self._url, true) catch |err| {
@@ -299,7 +299,7 @@ fn loadInitialScript(self: *SharedWorkerGlobalScope, script: []const u8) !void {
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);
- log.err(.browser, "shared worker module error", .{ .url = self._url, .caught = caught });
+ log.debug(.browser, "shared worker module error", .{ .url = self._url, .caught = caught });
return;
},
}
@@ -319,7 +319,7 @@ fn releaseScriptArena(self: *SharedWorkerGlobalScope) void {
fn drainPendingConnects(self: *SharedWorkerGlobalScope) void {
for (self._pending_connects.items) |port| {
self.scheduleConnect(port) catch |err| {
- log.warn(.browser, "shared worker drain failed", .{ .err = err });
+ log.debug(.browser, "shared worker drain failed", .{ .err = err });
};
}
self._pending_connects.clearRetainingCapacity();
diff --git a/src/browser/webapi/SubtleCrypto.zig b/src/browser/webapi/SubtleCrypto.zig
index dbf84dd89..1c4118e5c 100644
--- a/src/browser/webapi/SubtleCrypto.zig
+++ b/src/browser/webapi/SubtleCrypto.zig
@@ -60,7 +60,7 @@ pub fn generateKey(
.ec_key_gen => |params| return EC.generate(params, extractable, key_usages, exec),
.rsa_hashed_key_gen => |params| {
try RSA.validate(params, key_usages);
- log.warn(.not_implemented, "generateKey", .{ .name = params.name });
+ log.debug(.not_implemented, "generateKey", .{ .name = params.name });
},
.name => |js_name| return generateKeyFromName(try js_name.toSSO(false), extractable, key_usages, exec),
.object => |object| return generateKeyFromName(try object.name.toSSO(false), extractable, key_usages, exec),
@@ -114,7 +114,7 @@ fn generateKeyFromName(
}
}
- log.warn(.not_implemented, "generateKey", .{ .name = name });
+ log.debug(.not_implemented, "generateKey", .{ .name = name });
return error.NotSupported;
}
@@ -145,7 +145,7 @@ pub fn importKey(
};
return EC.import(name, algo.namedCurve(), format, der, is_private, extractable, mask, exec);
}
- log.warn(.not_implemented, "SubtleCrypto.importKey", .{ .name = name });
+ log.debug(.not_implemented, "SubtleCrypto.importKey", .{ .name = name });
return error.NotSupported;
}
@@ -205,7 +205,7 @@ pub fn importKey(
return HMAC.import(hash_name, raw, extractable, key_usages, exec);
}
- log.warn(.not_implemented, "SubtleCrypto.importKey", .{ .name = name });
+ log.debug(.not_implemented, "SubtleCrypto.importKey", .{ .name = name });
return error.NotSupported;
}
@@ -265,7 +265,7 @@ pub fn exportKey(
const is_unsupported = std.mem.eql(u8, format, "pkcs8") or std.mem.eql(u8, format, "spki");
if (is_unsupported) {
- log.warn(.not_implemented, "SubtleCrypto.exportKey", .{ .format = format });
+ log.debug(.not_implemented, "SubtleCrypto.exportKey", .{ .format = format });
return error.NotSupported;
}
@@ -295,7 +295,7 @@ fn exportJwk(key: *CryptoKey, exec: *const Execution) !js.Promise {
break :blk try std.fmt.allocPrint(exec.local_arena, "HS{s}", .{hash[4..]}); // strip "SHA-"
},
else => {
- log.warn(.not_implemented, "SubtleCrypto.exportKey", .{ .format = "jwk", .type = key._type });
+ log.debug(.not_implemented, "SubtleCrypto.exportKey", .{ .format = "jwk", .type = key._type });
return error.NotSupported;
},
};
@@ -353,7 +353,7 @@ pub fn deriveKey(
return HMAC.import(hash_name, bits, extractable, key_usages, exec);
},
.object, .name => {
- log.warn(.not_implemented, "SubtleCrypto.deriveKey", .{});
+ log.debug(.not_implemented, "SubtleCrypto.deriveKey", .{});
return error.NotSupported;
},
}
@@ -448,7 +448,7 @@ pub fn sign(
// Call sign for HMAC.
.hmac => return HMAC.sign(algo, key, data, exec),
else => {
- log.warn(.not_implemented, "SubtleCrypto.sign", .{ .key_type = key._type });
+ log.debug(.not_implemented, "SubtleCrypto.sign", .{ .key_type = key._type });
return error.InvalidAccessError;
},
};
diff --git a/src/browser/webapi/Timers.zig b/src/browser/webapi/Timers.zig
index a0abaa571..26dc3dda2 100644
--- a/src/browser/webapi/Timers.zig
+++ b/src/browser/webapi/Timers.zig
@@ -235,7 +235,7 @@ const ScheduleCallback = struct {
const IdleDeadline = @import("IdleDeadline.zig");
ls.toLocal(self.cb).call(void, .{IdleDeadline{}}) catch |err| {
self.exec.page.recordJsError(err);
- log.warn(.js, "idleCallback", .{ .name = self.name, .err = err });
+ log.debug(.js, "idleCallback", .{ .name = self.name, .err = err });
};
},
.animation_frame => {
@@ -245,13 +245,13 @@ const ScheduleCallback = struct {
};
ls.toLocal(self.cb).call(void, .{now}) catch |err| {
self.exec.page.recordJsError(err);
- log.warn(.js, "RAF", .{ .name = self.name, .err = err });
+ log.debug(.js, "RAF", .{ .name = self.name, .err = err });
};
},
.normal => {
ls.toLocal(self.cb).call(void, self.params) catch |err| {
self.exec.page.recordJsError(err);
- log.warn(.js, "timer", .{ .name = self.name, .err = err });
+ log.debug(.js, "timer", .{ .name = self.name, .err = err });
};
},
}
diff --git a/src/browser/webapi/WebDriver.zig b/src/browser/webapi/WebDriver.zig
index e111b81fb..0e472abcb 100644
--- a/src/browser/webapi/WebDriver.zig
+++ b/src/browser/webapi/WebDriver.zig
@@ -69,7 +69,7 @@ pub fn click(_: *const WebDriver, element: *Element, frame: *Frame) !void {
// A dispatch error must never reject the testdriver command.
Frame.user_input.triggerClick(frame, element, frame.page.input_modifiers) catch |err| {
- log.warn(.app, "webdriver click", .{ .err = err });
+ log.debug(.app, "webdriver click", .{ .err = err });
};
}
@@ -294,7 +294,7 @@ fn performPointerSource(source: js.Object, frame: *Frame) !void {
const suppressed = dispatchMouse(el, "mousedown", button, Frame.user_input.buttonsBitmask(button), click_count, frame);
if (!suppressed) {
Frame.user_input.focusForMouseDown(frame, el) catch |err| {
- log.warn(.app, "webdriver mousedown focus", .{ .err = err });
+ log.debug(.app, "webdriver mousedown focus", .{ .err = err });
};
}
}
@@ -509,16 +509,16 @@ fn dispatchKey(is_down: bool, key: []const u8, frame: *Frame) void {
.altKey = modifiers.alt,
.metaKey = modifiers.meta,
}, frame) catch |err| {
- log.warn(.app, "webdriver key event", .{ .err = err });
+ log.debug(.app, "webdriver key event", .{ .err = err });
return;
};
if (is_down) {
_ = Frame.user_input.triggerKeyDown(frame, event, Frame.user_input.textForKey(event)) catch |err| {
- log.warn(.app, "webdriver dispatch", .{ .err = err, .type = typ.str() });
+ log.debug(.app, "webdriver dispatch", .{ .err = err, .type = typ.str() });
};
} else {
Frame.user_input.triggerKeyUp(frame, event) catch |err| {
- log.warn(.app, "webdriver dispatch", .{ .err = err, .type = typ.str() });
+ log.debug(.app, "webdriver dispatch", .{ .err = err, .type = typ.str() });
};
}
}
@@ -547,7 +547,7 @@ fn dispatchPointer(el: *Element, comptime typ: []const u8, button: i32, buttons:
.altKey = modifiers.alt,
.metaKey = modifiers.meta,
}, frame) catch |err| {
- log.warn(.app, "webdriver pointer event", .{ .err = err, .type = typ });
+ log.debug(.app, "webdriver pointer event", .{ .err = err, .type = typ });
return;
};
dispatch(el.asEventTarget(), event.asEvent(), frame, typ);
@@ -567,11 +567,11 @@ fn dispatchMouse(el: *Element, comptime typ: []const u8, button: i32, buttons: u
.altKey = modifiers.alt,
.metaKey = modifiers.meta,
}, frame) catch |err| {
- log.warn(.app, "webdriver mouse event", .{ .err = err, .type = typ });
+ log.debug(.app, "webdriver mouse event", .{ .err = err, .type = typ });
return false;
};
return frame._event_manager.dispatchCancelable(el.asEventTarget(), event.asEvent()) catch |err| {
- log.warn(.app, "webdriver dispatch", .{ .err = err, .type = typ });
+ log.debug(.app, "webdriver dispatch", .{ .err = err, .type = typ });
return false;
};
}
@@ -581,13 +581,13 @@ fn dispatchMouse(el: *Element, comptime typ: []const u8, button: i32, buttons: u
// no center worth computing.
fn dispatchWheel(el: *Element, x: i32, y: i32, delta_x: i32, delta_y: i32, frame: *Frame) void {
Frame.user_input.wheel(frame, el, @floatFromInt(x), @floatFromInt(y), @floatFromInt(delta_x), @floatFromInt(delta_y)) catch |err| {
- log.warn(.app, "webdriver wheel", .{ .err = err });
+ log.debug(.app, "webdriver wheel", .{ .err = err });
};
}
fn dispatch(target: *EventTarget, event: *Event, frame: *Frame, typ: []const u8) void {
frame._event_manager.dispatch(target, event) catch |err| {
- log.warn(.app, "webdriver dispatch", .{ .err = err, .type = typ });
+ log.debug(.app, "webdriver dispatch", .{ .err = err, .type = typ });
};
}
@@ -597,7 +597,7 @@ fn dispatchTouch(el: *Element, comptime typ: []const u8, frame: *Frame) void {
.bubbles = true,
.composed = true,
}, owner) catch |err| {
- log.warn(.app, "webdriver touch event", .{ .err = err });
+ log.debug(.app, "webdriver touch event", .{ .err = err });
return;
};
event.asEvent()._cancelable_unless_passive = true;
diff --git a/src/browser/webapi/Window.zig b/src/browser/webapi/Window.zig
index 38216d106..6205956b5 100644
--- a/src/browser/webapi/Window.zig
+++ b/src/browser/webapi/Window.zig
@@ -488,7 +488,7 @@ pub fn setWindowReflectingHandlerFromAttribute(self: *Window, name: lp.String, v
if (frame.js.stringToPersistedFunction(expr, &.{"event"}, &.{})) |func| {
slot.* = func;
} else |err| {
- log.err(.js, "window reflecting handler", .{ .err = err, .str = expr });
+ log.debug(.js, "window reflecting handler", .{ .err = err, .str = expr });
slot.* = null;
}
}
@@ -607,7 +607,7 @@ pub fn reportError(self: *Window, err: js.Value, frame: *Frame) !void {
const target = self.asEventTarget();
if (!frame._event_manager.hasDirectListeners(target, "error", self._on_error)) {
if (comptime lp.IS_TEST == false) {
- log.warn(.js, "window.reportError", .{
+ log.debug(.js, "window.reportError", .{
.message = err.toStringSlice() catch "Unknown error",
});
}
@@ -662,7 +662,7 @@ pub fn reportError(self: *Window, err: js.Value, frame: *Frame) !void {
if (comptime lp.IS_TEST == false) {
if (!event._prevent_default) {
- log.warn(.js, "window.reportError", .{
+ log.debug(.js, "window.reportError", .{
.message = error_event._message,
.filename = error_event._filename,
.line_number = error_event._line_number,
@@ -685,7 +685,7 @@ pub fn getComputedStyle(_: *const Window, element: *Element, pseudo_element: ?[]
const gop = try page.element_computed_styles.getOrPut(page.frame_arena, .{ .element = element, .pseudo = pseudo });
if (!gop.found_existing) {
if (pseudo == .other) {
- log.warn(.not_implemented, "window.GetComputedStyle", .{ .pseudo_element = pseudo_element.? });
+ log.debug(.not_implemented, "window.GetComputedStyle", .{ .pseudo_element = pseudo_element.? });
}
gop.value_ptr.* = try CSSStyleProperties.init(element, true, frame);
}
@@ -1387,7 +1387,6 @@ const CrossOriginWindow = struct {
const testing = @import("../../testing.zig");
test "WebApi: Window" {
- testing.expectLog(&.{.http}); // stop aborts
try testing.htmlRunner("window", .{});
}
diff --git a/src/browser/webapi/Worker.zig b/src/browser/webapi/Worker.zig
index 114ce559d..fa946eeb1 100644
--- a/src/browser/webapi/Worker.zig
+++ b/src/browser/webapi/Worker.zig
@@ -115,7 +115,7 @@ pub fn init(url: []const u8, options: ?WorkerOptions, frame: *Frame) !*Worker {
.error_callback = httpErrorCallback,
.shutdown_callback = httpShutdownCallback,
}) catch |err| {
- log.err(.browser, "Worker request", .{ .url = resolved_url, .err = err });
+ log.debug(.browser, "Worker request", .{ .url = resolved_url, .err = err });
frame.removeWorker(self);
return err;
};
@@ -127,7 +127,7 @@ pub fn init(url: []const u8, options: ?WorkerOptions, frame: *Frame) !*Worker {
self._http_transfer = transfer;
transfer.submit() catch |err| {
- log.err(.browser, "Worker request", .{ .url = resolved_url, .err = err });
+ log.debug(.browser, "Worker request", .{ .url = resolved_url, .err = err });
frame.removeWorker(self);
return err;
};
@@ -156,7 +156,7 @@ fn httpHeaderCallback(transfer: *Transfer) !Transfer.HeaderResult {
const status = transfer.responseStatus() orelse return .abort;
if (status < 200 or status >= 300) {
- log.warn(.browser, "Worker status", .{
+ log.debug(.browser, "Worker status", .{
.url = self._url,
.status = status,
});
@@ -235,7 +235,7 @@ fn loadInitialScript(self: *Worker, script: []const u8) !void {
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);
- log.err(.browser, "worker script error", .{ .url = self._url, .caught = caught });
+ log.debug(.browser, "worker script error", .{ .url = self._url, .caught = caught });
self.fireErrorEvent(caught.exception orelse @errorName(err), null);
return;
},
@@ -246,7 +246,7 @@ fn loadInitialScript(self: *Worker, script: []const u8) !void {
js_context.page.recordJsError(err);
const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);
- log.err(.browser, "worker module error", .{ .url = self._url, .caught = caught });
+ log.debug(.browser, "worker module error", .{ .url = self._url, .caught = caught });
self.fireErrorEvent(caught.exception orelse @errorName(err), null);
return;
},
@@ -271,7 +271,7 @@ fn httpErrorCallback(ctx: *anyopaque, err: anyerror) void {
// (or bother logging)
const canceled = err == error.TransferCanceled;
if (!canceled) {
- log.err(.browser, "worker fetch error", .{
+ log.debug(.browser, "worker fetch error", .{
.url = self._url,
.err = err,
});
@@ -299,7 +299,7 @@ fn releaseScriptArena(self: *Worker) void {
// Fire an error event on the Worker object (parent context)
fn fireErrorEvent(self: *Worker, message: []const u8, error_value: ?js.Value.Global) void {
self._fireErrorEvent(message, error_value) catch |err| {
- log.warn(.browser, "worker fire error", .{ .err = err, .message = message });
+ log.debug(.browser, "worker fire error", .{ .err = err, .message = message });
};
}
diff --git a/src/browser/webapi/WorkerGlobalScope.zig b/src/browser/webapi/WorkerGlobalScope.zig
index 2a371fd50..79a98b0aa 100644
--- a/src/browser/webapi/WorkerGlobalScope.zig
+++ b/src/browser/webapi/WorkerGlobalScope.zig
@@ -429,7 +429,7 @@ fn importScript(self: *WorkerGlobalScope, arena: Allocator, url: [:0]const u8) !
.credentials_mode = .same_origin,
.shutdown_callback = HttpClient.noopShutdown, // syncRequest installs its own
}, &self._http_owner) catch |err| {
- log.warn(.http, "importScript", .{ .url = resolved_url, .err = err });
+ log.debug(.http, "importScript", .{ .url = resolved_url, .err = err });
return error.NetworkError;
};
{
@@ -438,13 +438,13 @@ fn importScript(self: *WorkerGlobalScope, arena: Allocator, url: [:0]const u8) !
}
var response = transfer.submitSync(.{}) catch |err| {
- log.warn(.http, "importScript", .{ .url = resolved_url, .err = err });
+ log.debug(.http, "importScript", .{ .url = resolved_url, .err = err });
return error.NetworkError;
};
defer response.deinit();
if (response.status != 200) {
- log.warn(.http, "importScript", .{ .url = resolved_url, .status = response.status });
+ log.debug(.http, "importScript", .{ .url = resolved_url, .status = response.status });
return error.NetworkError;
}
@@ -459,7 +459,7 @@ fn importScript(self: *WorkerGlobalScope, arena: Allocator, url: [:0]const u8) !
_ = ls.local.eval(response.body.items, url) catch |err| {
self.page.recordJsError(err);
const caught = try_catch.caughtOrError(arena, err);
- log.err(.browser, "importScript", .{ .url = resolved_url, .caught = caught });
+ log.debug(.browser, "importScript", .{ .url = resolved_url, .caught = caught });
return;
};
@@ -512,7 +512,7 @@ pub fn reportError(self: *WorkerGlobalScope, err: JS.Value) !void {
if (comptime lp.IS_TEST == false) {
if (!event._prevent_default) {
- log.warn(.js, "worker.reportError", .{
+ log.debug(.js, "worker.reportError", .{
.message = error_event._message,
.filename = error_event._filename,
.line_number = error_event._line_number,
diff --git a/src/browser/webapi/animation/Animation.zig b/src/browser/webapi/animation/Animation.zig
index b16a91c05..be4ab00ce 100644
--- a/src/browser/webapi/animation/Animation.zig
+++ b/src/browser/webapi/animation/Animation.zig
@@ -125,13 +125,13 @@ pub fn finish(self: *Animation, frame: *Frame) void {
// call onfinish
if (self._onFinish) |func| {
frame.js.local.?.toLocal(func).call(void, .{}) catch |err| {
- log.warn(.js, "Animation._onFinish", .{ .err = err });
+ log.debug(.js, "Animation._onFinish", .{ .err = err });
};
}
}
pub fn reverse(_: *Animation) void {
- log.warn(.not_implemented, "Animation.reverse", .{});
+ log.debug(.not_implemented, "Animation.reverse", .{});
}
pub fn getFinished(self: *Animation, frame: *Frame) !js.Promise {
@@ -209,7 +209,7 @@ fn update(ctx: *anyopaque) !?u32 {
// call onfinish
if (self._onFinish) |func| {
ls.toLocal(func).call(void, .{}) catch |err| {
- log.warn(.js, "Animation._onFinish", .{ .err = err });
+ log.debug(.js, "Animation._onFinish", .{ .err = err });
};
}
},
diff --git a/src/browser/webapi/cache/Cache.zig b/src/browser/webapi/cache/Cache.zig
index ca26e1551..7180f02bd 100644
--- a/src/browser/webapi/cache/Cache.zig
+++ b/src/browser/webapi/cache/Cache.zig
@@ -152,7 +152,7 @@ fn addAll(self: *Cache, inputs: []const Request.Input, exec: *const Execution) !
for (requests, batch.slots) |request, *slot| {
batch.pending += 1;
Fetch.start(request, .{ .ctx = slot, .callback = Batch.fetched }, exec) catch |err| {
- log.warn(.http, "Cache.add fetch", .{ .err = err, .url = request._url });
+ log.debug(.http, "Cache.add fetch", .{ .err = err, .url = request._url });
batch.pending -= 1;
batch.outcome = .failed;
break;
diff --git a/src/browser/webapi/collections/HTMLOptionsCollection.zig b/src/browser/webapi/collections/HTMLOptionsCollection.zig
index 9a05f06d4..3d0a38849 100644
--- a/src/browser/webapi/collections/HTMLOptionsCollection.zig
+++ b/src/browser/webapi/collections/HTMLOptionsCollection.zig
@@ -130,7 +130,7 @@ fn setAtIndex(self: *HTMLOptionsCollection, index: u32, option_: ?*Option, frame
}
if (index >= max_list_items) {
- lp.log.warn(.js, "select overflow", .{ .max_list_items = max_list_items, .request = index });
+ lp.log.debug(.js, "select overflow", .{ .max_list_items = max_list_items, .request = index });
return;
}
diff --git a/src/browser/webapi/css/MediaQueryList.zig b/src/browser/webapi/css/MediaQueryList.zig
index bd38efffb..1b3ee9901 100644
--- a/src/browser/webapi/css/MediaQueryList.zig
+++ b/src/browser/webapi/css/MediaQueryList.zig
@@ -73,7 +73,7 @@ pub fn viewportChanged(self: *MediaQueryList) void {
const frame = self._frame;
if (!frame.hasDirectListeners(self.asEventTarget(), "change", self._on_change)) return;
self.dispatchChange(matches) catch |err| {
- log.warn(.browser, "matchMedia change", .{ .err = err, .media = self._media });
+ log.debug(.browser, "matchMedia change", .{ .err = err, .media = self._media });
};
}
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index a671386f0..ee30dcacb 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -674,7 +674,7 @@ pub fn getAttributeFunction(
const attr = element.getAttributeSafe(.wrap(@tagName(listener_type))) orelse return null;
const function = frame.js.stringToPersistedFunction(attr, &.{"event"}, &.{}) catch |err| {
// Not a valid expression; log this to find out if its something we should be supporting.
- log.warn(.js, "Html.getAttributeFunction", .{
+ log.debug(.js, "Html.getAttributeFunction", .{
.expression = attr,
.err = err,
});
diff --git a/src/browser/webapi/element/html/Canvas.zig b/src/browser/webapi/element/html/Canvas.zig
index fc035a2a3..4518e9636 100644
--- a/src/browser/webapi/element/html/Canvas.zig
+++ b/src/browser/webapi/element/html/Canvas.zig
@@ -170,7 +170,7 @@ const ToBlobCallback = struct {
ls.toLocal(self.callback).call(void, .{blob}) catch |err| {
exec.page.recordJsError(err);
- log.warn(.js, "canvas.toBlob", .{ .err = err });
+ log.debug(.js, "canvas.toBlob", .{ .err = err });
};
ls.local.runMicrotasks();
return null;
diff --git a/src/browser/webapi/element/html/Custom.zig b/src/browser/webapi/element/html/Custom.zig
index 386eacd5d..60ef4cd21 100644
--- a/src/browser/webapi/element/html/Custom.zig
+++ b/src/browser/webapi/element/html/Custom.zig
@@ -339,7 +339,7 @@ pub fn checkAndAttachBuiltIn(element: *Element, frame: *Frame) !void {
var caught: js.TryCatch.Caught = .{};
_ = local.toLocal(definition.constructor).newInstance(&caught) catch |err| {
- log.warn(.js, "custom builtin ctor", .{ .name = is_value, .err = err, .caught = caught });
+ log.debug(.js, "custom builtin ctor", .{ .name = is_value, .err = err, .caught = caught });
return;
};
}
diff --git a/src/browser/webapi/element/html/Image.zig b/src/browser/webapi/element/html/Image.zig
index 946428f37..37dcbd21e 100644
--- a/src/browser/webapi/element/html/Image.zig
+++ b/src/browser/webapi/element/html/Image.zig
@@ -151,7 +151,7 @@ fn imageAddedCallback(self: *Image, frame: *Frame) !void {
}
Frame.resource_load.image(frame, self, src) catch |err| {
- log.warn(.http, "image fetch", .{ .err = err, .src = src });
+ log.debug(.http, "image fetch", .{ .err = err, .src = src });
return frame.queueElementEvent(Factory.protoOf(self), .@"error");
};
}
diff --git a/src/browser/webapi/element/html/Picture.zig b/src/browser/webapi/element/html/Picture.zig
index 005c2e107..e15f666ac 100644
--- a/src/browser/webapi/element/html/Picture.zig
+++ b/src/browser/webapi/element/html/Picture.zig
@@ -68,7 +68,7 @@ pub fn childRemoved(parent: *Node, child: *Node, next_sibling: ?*Node, frame: *F
return;
result catch |err| {
- log.warn(.frame, "picture child removed", .{ .err = err });
+ log.debug(.frame, "picture child removed", .{ .err = err });
};
}
diff --git a/src/browser/webapi/element/html/Script.zig b/src/browser/webapi/element/html/Script.zig
index 142358e78..36d5023f6 100644
--- a/src/browser/webapi/element/html/Script.zig
+++ b/src/browser/webapi/element/html/Script.zig
@@ -162,6 +162,5 @@ pub const Build = struct {
const testing = @import("../../../../testing.zig");
test "WebApi: Script" {
testing.silenceLog(&.{.http});
- testing.expectLog(&.{ .js, .js });
try testing.htmlRunner("element/html/script", .{});
}
diff --git a/src/browser/webapi/geolocation/Geolocation.zig b/src/browser/webapi/geolocation/Geolocation.zig
index b64569ab5..0d70fe223 100644
--- a/src/browser/webapi/geolocation/Geolocation.zig
+++ b/src/browser/webapi/geolocation/Geolocation.zig
@@ -182,7 +182,7 @@ const Request = struct {
fn deliverPosition(self: *Request, override: Override) void {
const exec = self.exec;
const position = GeolocationPosition.init(exec, override) catch |err| {
- log.err(.js, "geolocation.position", .{ .err = err });
+ log.debug(.js, "geolocation.position", .{ .err = err });
return;
};
@@ -199,7 +199,7 @@ const Request = struct {
const exec = self.exec;
const position_error = GeolocationPositionError.init(exec, code) catch |err| {
- log.err(.js, "geolocation.error", .{ .err = err });
+ log.debug(.js, "geolocation.error", .{ .err = err });
return;
};
position_error.acquireRef();
@@ -217,7 +217,7 @@ const Request = struct {
ls.toLocal(callback).call(void, .{arg}) catch |err| {
exec.page.recordJsError(err);
- log.warn(.js, "geolocation", .{ .err = err });
+ log.debug(.js, "geolocation", .{ .err = err });
};
ls.local.runMicrotasks();
}
diff --git a/src/browser/webapi/navigation/Navigation.zig b/src/browser/webapi/navigation/Navigation.zig
index 6699cc460..3dda744da 100644
--- a/src/browser/webapi/navigation/Navigation.zig
+++ b/src/browser/webapi/navigation/Navigation.zig
@@ -233,7 +233,7 @@ pub fn pushEntry(
// entry's failure skip the others.
defer for (disposed) |d| {
d.fireDispose(frame) catch |err| {
- log.warn(.event, "NavigationHistoryEntry.dispose", .{ .err = err });
+ log.debug(.event, "NavigationHistoryEntry.dispose", .{ .err = err });
};
};
@@ -302,7 +302,7 @@ pub fn replaceEntry(
// Per spec, dispose fires last, after currententrychange. old_entry is
// already out of _entries, so fire even if the dispatch below fails.
defer old_entry.fireDispose(frame) catch |err| {
- log.warn(.event, "NavigationHistoryEntry.dispose", .{ .err = err });
+ log.debug(.event, "NavigationHistoryEntry.dispose", .{ .err = err });
};
if (should_dispatch) {
@@ -326,7 +326,7 @@ fn fireNavigateSuccess(self: *Navigation, frame: *Frame) !void {
null,
frame.page,
) catch |err| {
- log.warn(.event, "Navigation.navigatesuccess", .{ .err = err });
+ log.debug(.event, "Navigation.navigatesuccess", .{ .err = err });
return;
};
@@ -356,7 +356,7 @@ fn fireCurrentEntryChangeEvent(
},
frame,
) catch |err| {
- log.warn(.event, "Navigation.currententrychange", .{ .err = err });
+ log.debug(.event, "Navigation.currententrychange", .{ .err = err });
return;
};
@@ -509,7 +509,7 @@ const TraverseToOptions = struct {
pub fn traverseTo(self: *Navigation, key: []const u8, _opts: ?TraverseToOptions, frame: *Frame) !NavigationReturn {
if (_opts != null) {
- log.warn(.not_implemented, "Navigation.traverseTo", .{ .has_options = true });
+ log.debug(.not_implemented, "Navigation.traverseTo", .{ .has_options = true });
}
for (self._entries.items, 0..) |entry, i| {
diff --git a/src/browser/webapi/net/EventSource.zig b/src/browser/webapi/net/EventSource.zig
index 14371d1d7..b74257353 100644
--- a/src/browser/webapi/net/EventSource.zig
+++ b/src/browser/webapi/net/EventSource.zig
@@ -216,7 +216,7 @@ fn reconnectTask(self: *EventSource) void {
return;
}
self.connect() catch |err| {
- log.warn(.http, "EventSource reconnect", .{ .err = err, .url = self._url });
+ log.debug(.http, "EventSource reconnect", .{ .err = err, .url = self._url });
self.failConnection();
};
}
@@ -247,7 +247,7 @@ fn failConnection(self: *EventSource) void {
}
self._ready_state = .closed;
self.dispatchEvent("error", self._on_error) catch |err| {
- log.err(.http, "EventSource error event", .{ .err = err, .url = self._url });
+ log.debug(.http, "EventSource error event", .{ .err = err, .url = self._url });
};
self.deactivate();
}
@@ -258,7 +258,7 @@ fn reestablish(self: *EventSource) void {
}
self._ready_state = .connecting;
self.dispatchEvent("error", self._on_error) catch |err| {
- log.err(.http, "EventSource error event", .{ .err = err, .url = self._url });
+ log.debug(.http, "EventSource error event", .{ .err = err, .url = self._url });
};
// the error handler may have close()d us
if (self._ready_state == .closed) {
diff --git a/src/browser/webapi/net/Fetch.zig b/src/browser/webapi/net/Fetch.zig
index 059cc48bf..be9e9c12b 100644
--- a/src/browser/webapi/net/Fetch.zig
+++ b/src/browser/webapi/net/Fetch.zig
@@ -397,7 +397,6 @@ fn httpShutdownCallback(ctx: *anyopaque) void {
const testing = @import("../../../testing.zig");
test "WebApi: fetch" {
- testing.expectLog(&.{.http});
try testing.htmlRunner("net/fetch.html", .{});
try testing.htmlRunner("net/fetch_hash_route.html", .{});
}
diff --git a/src/browser/webapi/net/FormData.zig b/src/browser/webapi/net/FormData.zig
index 6eeb18caf..5e3b3470d 100644
--- a/src/browser/webapi/net/FormData.zig
+++ b/src/browser/webapi/net/FormData.zig
@@ -319,7 +319,7 @@ pub fn forEach(self: *FormData, cb_: js.Function, js_this_: ?js.Object) !void {
for (self._entries.items) |*entry| {
cb.call(void, .{ entry.value.asString(), entry.name.str(), self }) catch |err| {
// this is a non-JS error
- log.warn(.js, "FormData.forEach", .{ .err = err });
+ log.debug(.js, "FormData.forEach", .{ .err = err });
};
}
}
diff --git a/src/browser/webapi/net/URLSearchParams.zig b/src/browser/webapi/net/URLSearchParams.zig
index 98169c64b..377bf1b16 100644
--- a/src/browser/webapi/net/URLSearchParams.zig
+++ b/src/browser/webapi/net/URLSearchParams.zig
@@ -171,7 +171,7 @@ pub fn forEach(self: *URLSearchParams, cb_: js.Function, js_this_: ?js.Object) !
const entry = self._params._entries.items[i];
cb.call(void, .{ entry.value.str(), entry.name.str(), self }) catch |err| {
// this is a non-JS error
- log.warn(.js, "URLSearchParams.forEach", .{ .err = err });
+ log.debug(.js, "URLSearchParams.forEach", .{ .err = err });
};
}
}
diff --git a/src/browser/webapi/net/WebSocket.zig b/src/browser/webapi/net/WebSocket.zig
index 463778e66..75b5b8021 100644
--- a/src/browser/webapi/net/WebSocket.zig
+++ b/src/browser/webapi/net/WebSocket.zig
@@ -339,7 +339,7 @@ pub fn kill(self: *WebSocket) void {
pub fn transportClosed(self: *WebSocket, err: ?anyerror) void {
self.releaseTransport();
self.bufferEvent(.{ .disconnected = err }) catch |err2| {
- log.err(.websocket, "close failure", .{ .err = err2 });
+ log.debug(.websocket, "close failure", .{ .err = err2 });
// Can't buffer. Drop the socket without running JS.
self.kill();
};
@@ -371,7 +371,7 @@ pub fn deliverEvents(self: *WebSocket) void {
.open => {
self._ready_state = .open;
self.dispatchOpenEvent() catch |err| {
- log.err(.websocket, "open event fail", .{ .err = err });
+ log.debug(.websocket, "open event fail", .{ .err = err });
};
},
.message => |msg| {
@@ -379,14 +379,14 @@ pub fn deliverEvents(self: *WebSocket) void {
// events after that
if (self._ready_state == .open) {
self.dispatchMessageEvent(msg.data, msg.frame_type) catch |err| {
- log.err(.websocket, "message event dispatch failed", .{ .err = err });
+ log.debug(.websocket, "message event dispatch failed", .{ .err = err });
};
}
},
.close_frame => self.handleCloseFrame(),
.local_close => {
self.dispatchCloseEvent(self._close_code, self._close_reason, false) catch |err| {
- log.err(.websocket, "close event dispatch failed", .{ .err = err });
+ log.debug(.websocket, "close event dispatch failed", .{ .err = err });
};
self.deactivate();
},
@@ -410,7 +410,7 @@ fn handleCloseFrame(self: *WebSocket) void {
// (.disconnected follows).
self._ready_state = .closing;
self.queueMessage(.close) catch |err| {
- log.err(.websocket, "reciprocal close", .{ .err = err, .url = self._url });
+ log.debug(.websocket, "reciprocal close", .{ .err = err, .url = self._url });
};
}
@@ -419,7 +419,7 @@ fn disconnected(self: *WebSocket, err_: ?anyerror) void {
self._ready_state = .closed;
if (err_) |err| {
- log.warn(.websocket, "disconnected", .{ .err = err, .url = self._url });
+ log.debug(.websocket, "disconnected", .{ .err = err, .url = self._url });
} else {
log.info(.websocket, "disconnected", .{ .url = self._url, .reason = "closed" });
}
@@ -433,12 +433,12 @@ fn disconnected(self: *WebSocket, err_: ?anyerror) void {
// Spec requires error event before close on abnormal closure.
if (!was_clean) {
self.dispatchErrorEvent() catch |err| {
- log.err(.websocket, "error event dispatch failed", .{ .err = err });
+ log.debug(.websocket, "error event dispatch failed", .{ .err = err });
};
}
self.dispatchCloseEvent(code, reason, was_clean) catch |err| {
- log.err(.websocket, "close event dispatch failed", .{ .err = err });
+ log.debug(.websocket, "close event dispatch failed", .{ .err = err });
};
}
@@ -804,7 +804,7 @@ fn sendDataCallback(buffer: [*]u8, buf_count: usize, buf_len: usize, data: *anyo
}
const conn: *http.Connection = @ptrCast(@alignCast(data));
return _sendDataCallback(conn, buffer[0..buf_len]) catch |err| {
- log.warn(.websocket, "send callback", .{ .err = err });
+ log.debug(.websocket, "send callback", .{ .err = err });
return http.readfunc_pause;
};
}
@@ -890,7 +890,7 @@ fn receivedDataCallback(buffer: [*]const u8, buf_count: usize, buf_len: usize, d
}
const conn: *http.Connection = @ptrCast(@alignCast(data));
_receivedDataCallback(conn, buffer[0..buf_len]) catch |err| {
- log.warn(.websocket, "receive callback", .{ .err = err });
+ log.debug(.websocket, "receive callback", .{ .err = err });
// TODO: are there errors, like an invalid frame, that we shouldn't treat
// as an error?
return http.writefunc_error;
@@ -1055,7 +1055,6 @@ pub const JsApi = struct {
const testing = @import("../../../testing.zig");
test "WebApi: WebSocket" {
- testing.expectLog(&.{.websocket});
try testing.htmlRunner("net/websocket.html", .{});
}
diff --git a/src/browser/webapi/net/XMLHttpRequest.zig b/src/browser/webapi/net/XMLHttpRequest.zig
index 535181286..a7fa1bc55 100644
--- a/src/browser/webapi/net/XMLHttpRequest.zig
+++ b/src/browser/webapi/net/XMLHttpRequest.zig
@@ -385,7 +385,7 @@ pub fn send(self: *XMLHttpRequest, body_: ?BodyInit, exec_: *const Execution) !v
}
var resp = transfer.submitSync(.{ .copy_headers = true }) catch |err| {
- log.err(.http, "sync request failed", .{
+ log.debug(.http, "sync request failed", .{
.source = "xhr",
.url = self._url,
.err = err,
@@ -778,7 +778,7 @@ pub fn abort(self: *XMLHttpRequest) void {
fn handleError(self: *XMLHttpRequest, err: anyerror) void {
self._handleError(err) catch |inner| {
- log.err(.http, "handle error error", .{
+ log.debug(.http, "handle error error", .{
.original = err,
.err = inner,
});
@@ -804,12 +804,7 @@ fn _handleError(self: *XMLHttpRequest, err: anyerror) !void {
try self._proto.dispatch(.load_end, null, exec);
}
- const level: log.Level = switch (err) {
- error.TransferCanceled => .debug,
- error.UrlBlocked => .warn,
- else => .err,
- };
- log.log(.http, level, "error", .{
+ log.debug(.http, "error", .{
.url = self._url,
.err = err,
.source = "xhr.handleError",
@@ -894,7 +889,6 @@ test "parseMethod: accepts known methods case-insensitively" {
}
test "WebApi: XHR" {
- testing.expectLog(&.{ .http, .http });
try testing.htmlRunner("net/xhr.html", .{});
}
diff --git a/src/browser/webapi/storage/Cookie.zig b/src/browser/webapi/storage/Cookie.zig
index 698e89ebb..f3ccf19c2 100644
--- a/src/browser/webapi/storage/Cookie.zig
+++ b/src/browser/webapi/storage/Cookie.zig
@@ -685,7 +685,7 @@ pub const Jar = struct {
pub fn populateFromResponse(self: *Jar, url: [:0]const u8, set_cookie: []const u8) !void {
const c = Cookie.parse(self.allocator, url, set_cookie) catch |err| {
- log.warn(.frame, "cookie parse failed", .{ .raw = set_cookie, .err = err });
+ log.debug(.frame, "cookie parse failed", .{ .raw = set_cookie, .err = err });
return;
};
diff --git a/src/browser/webapi/storage/idb/IDBFactory.zig b/src/browser/webapi/storage/idb/IDBFactory.zig
index 0c49df116..7bb039016 100644
--- a/src/browser/webapi/storage/idb/IDBFactory.zig
+++ b/src/browser/webapi/storage/idb/IDBFactory.zig
@@ -202,7 +202,7 @@ const OpenContext = struct {
}) catch |err| {
// We were handed the gate; if we can't reschedule, hand it off so the
// waiters behind us aren't stranded.
- log.warn(.storage, "idb resume open", .{ .err = err });
+ log.debug(.storage, "idb resume open", .{ .err = err });
if (self.resolveEngine()) |engine| _ = engine.releaseGate(&self._gate_waiter) else |_| {}
self.exec._factory.destroy(self);
};
@@ -377,7 +377,7 @@ const DeleteContext = struct {
}) catch |err| {
// We were handed the gate; if we can't reschedule, hand it off so the
// waiters behind us aren't stranded.
- log.warn(.storage, "idb resume delete", .{ .err = err });
+ log.debug(.storage, "idb resume delete", .{ .err = err });
if (self.resolveEngine()) |engine| _ = engine.releaseGate(&self._gate_waiter) else |_| {}
self.exec._factory.destroy(self);
};
diff --git a/src/browser/webapi/storage/idb/IDBRequest.zig b/src/browser/webapi/storage/idb/IDBRequest.zig
index 4334b3135..06a2889c0 100644
--- a/src/browser/webapi/storage/idb/IDBRequest.zig
+++ b/src/browser/webapi/storage/idb/IDBRequest.zig
@@ -239,7 +239,7 @@ pub fn fireUpgradeNeeded(self: *IDBRequest, exec: *Execution, old_version: u64,
switch (self._txn) {
.borrowed => |txn| if (!txn.aborted()) {
txn.abortWith(exec, error.AbortError) catch |err| {
- log.warn(.storage, "idb upgradeneeded abort", .{ .err = err });
+ log.debug(.storage, "idb upgradeneeded abort", .{ .err = err });
};
},
.owned, .none => {},
@@ -265,7 +265,7 @@ pub fn fireSuccess(self: *IDBRequest, exec: *Execution) !void {
if (!txn._settled and !txn._committing) {
txn.abortWith(exec, error.AbortError) catch |err| {
- log.warn(.storage, "idb success-event abort", .{ .err = err });
+ log.debug(.storage, "idb success-event abort", .{ .err = err });
};
}
}
@@ -311,7 +311,7 @@ fn fireError(self: *IDBRequest, exec: *Execution) !void {
// can re-enter here, so keeping the error set out of deliver's
// recursion is both simpler and avoids an unresolvable inferred set.
tx.abortWith(exec, reason) catch |err| {
- log.warn(.storage, "idb error-event abort", .{ .err = err });
+ log.debug(.storage, "idb error-event abort", .{ .err = err });
};
}
}
diff --git a/src/browser/webapi/storage/idb/IDBTransaction.zig b/src/browser/webapi/storage/idb/IDBTransaction.zig
index 54e5c0562..f48f4bf8c 100644
--- a/src/browser/webapi/storage/idb/IDBTransaction.zig
+++ b/src/browser/webapi/storage/idb/IDBTransaction.zig
@@ -333,7 +333,7 @@ pub fn abortWith(self: *IDBTransaction, exec: *Execution, reason: ?anyerror) err
// which itself isn't an abort).
request.failWithAbort();
self._abort_requests.append(self._arena.allocator(), request) catch |err| {
- log.warn(.storage, "idb abort collect", .{ .err = err });
+ log.debug(.storage, "idb abort collect", .{ .err = err });
};
}
}
@@ -351,7 +351,7 @@ fn scheduleAbortDelivery(self: *IDBTransaction, exec: *Execution) void {
.name = "IDBTransaction.abort",
.finalizer = abortFinalize,
}) catch |err| {
- log.warn(.storage, "idb schedule abort", .{ .err = err });
+ log.debug(.storage, "idb schedule abort", .{ .err = err });
self.releaseRef(exec.page);
return;
};
@@ -375,7 +375,7 @@ fn deliverAbort(ctx: *anyopaque) !?u32 {
for (self._abort_requests.items) |request| {
request.deliver(exec) catch |err| {
- log.warn(.storage, "idb abort deliver", .{ .err = err });
+ log.debug(.storage, "idb abort deliver", .{ .err = err });
};
}
self._abort_requests.clearRetainingCapacity();
@@ -394,7 +394,7 @@ fn abortFinalize(ctx: *anyopaque) void {
// The abort event bubbles from the transaction to its connection.
fn fireAbort(self: *IDBTransaction, exec: *Execution) void {
const event = Event.initTrusted(comptime .wrap("abort"), .{ .bubbles = true }, exec.page) catch |err| {
- log.warn(.storage, "idb abort event", .{ .err = err });
+ log.debug(.storage, "idb abort event", .{ .err = err });
return;
};
event.acquireRef();
@@ -404,14 +404,14 @@ fn fireAbort(self: *IDBTransaction, exec: *Execution) void {
event._target = et;
event._dispatch_target = et;
exec.dispatch(et, event, self._on_abort, .{ .context = "IDBTransaction.abort", .inject_target = false }) catch |err| {
- log.warn(.storage, "idb abort dispatch", .{ .err = err });
+ log.debug(.storage, "idb abort dispatch", .{ .err = err });
};
if (event._stop_propagation) {
return;
}
const db = self._db;
exec.dispatch(db.asEventTarget(), event, db._on_abort, .{ .context = "IDBDatabase.abort", .inject_target = false }) catch |err| {
- log.warn(.storage, "idb abort dispatch", .{ .err = err });
+ log.debug(.storage, "idb abort dispatch", .{ .err = err });
};
}
@@ -629,11 +629,11 @@ fn getFunctionFromSetter(setter: ?FunctionSetter) ?js.Function.Global {
fn fire(self: *IDBTransaction, exec: *Execution, typ: lp.String, handler: ?js.Function.Global) void {
self._settled = true;
const event = Event.initTrusted(typ, null, exec.page) catch |err| {
- log.warn(.storage, "idb transaction event", .{ .err = err });
+ log.debug(.storage, "idb transaction event", .{ .err = err });
return;
};
exec.dispatch(self.asEventTarget(), event, handler, .{ .context = "IDBTransaction" }) catch |err| {
- log.warn(.storage, "idb transaction dispatch", .{ .err = err });
+ log.debug(.storage, "idb transaction dispatch", .{ .err = err });
};
}
@@ -714,7 +714,7 @@ fn resumeDrain(waiter: *Engine.GateWaiter) void {
self.scheduleDrain() catch |err| {
// We were handed the gate; if we can't reschedule, hand it off so the
// waiters behind us aren't stranded. Unpark may free self — last touch.
- log.warn(.storage, "idb resume drain", .{ .err = err });
+ log.debug(.storage, "idb resume drain", .{ .err = err });
_ = self._engine.releaseGate(&self._gate_waiter);
};
}
@@ -789,11 +789,11 @@ fn deliverBatch(self: *IDBTransaction, exec: *Execution) void {
return;
}
request.execute(exec) catch |err| {
- log.warn(.storage, "idb request execute", .{ .err = err });
+ log.debug(.storage, "idb request execute", .{ .err = err });
request.setError(err);
};
request.deliver(exec) catch |err| {
- log.warn(.storage, "idb request deliver", .{ .err = err });
+ log.debug(.storage, "idb request deliver", .{ .err = err });
};
}
}
diff --git a/src/log.zig b/src/log.zig
index 0c03c5836..f5fc35092 100644
--- a/src/log.zig
+++ b/src/log.zig
@@ -227,12 +227,6 @@ pub fn logKVs(scope: Scope, level: Level, msg: []const u8, kvs: []const KV) void
return;
}
- if (current_page) |page| {
- if (level != .note and @intFromEnum(level) > @intFromEnum(page.max_level)) {
- page.max_level = level;
- }
- }
-
if (comptime lp.IS_TEST) {
const expected = &expected_logs[@intFromEnum(scope)];
if (expected.* > 0) {
@@ -241,6 +235,12 @@ pub fn logKVs(scope: Scope, level: Level, msg: []const u8, kvs: []const KV) void
}
}
+ if (current_page) |page| {
+ if (level != .note and @intFromEnum(level) > @intFromEnum(page.max_level)) {
+ page.max_level = level;
+ }
+ }
+
if (sink) |s| {
var buf: [4096]u8 = undefined;
var w: std.Io.Writer = .fixed(&buf);
@@ -328,9 +328,6 @@ fn logLogFmtPrefix(scope: Scope, level: Level, msg: []const u8, writer: *std.Io.
fn logPretty(scope: Scope, level: Level, msg: []const u8, kvs: []const KV, writer: *std.Io.Writer) !void {
try logPrettyPrefix(scope, level, msg, writer);
- if (current_page) |page| {
- try writer.print(" $page = {d}\n", .{page.id});
- }
for (kvs) |kv| {
try writer.print(" {s} = ", .{kv.key});
try writeErased(.pretty, kv.value, writer);
@@ -358,16 +355,21 @@ fn logPrettyPrefix(scope: Scope, level: Level, msg: []const u8, writer: *std.Io.
try writer.writeAll(msg);
{
- // msg.len cannot be > 30, and @tagName(scope).len cannot be > 15
- // so this is safe
- const prefix_len = @tagName(scope).len + msg.len + 2;
- const padding = 55 - prefix_len;
+ // msg.len cannot be > 30, and @tagName(scope).len cannot be > 15.
+ // The page tag eats into the dot leaders so the elapsed column stays
+ // aligned and the line stays within 80 columns.
+ const page_len = if (current_page) |page| std.fmt.count(" page={d}", .{page.id}) else 0;
+ const prefix_len = @tagName(scope).len + msg.len + 2 + page_len;
+ const padding = 55 -| prefix_len;
for (0..padding / 2) |_| {
try writer.writeAll(" .");
}
if (@mod(padding, 2) == 1) {
try writer.writeByte(' ');
}
+ if (current_page) |page| {
+ try writer.print(" page={d}", .{page.id});
+ }
const el = elapsed();
try writer.print(" \x1b[0m[+{d}{s}]", .{ el.time, el.unit });
try writer.writeByte('\n');
@@ -769,7 +771,12 @@ test "log: page context" {
}
{
- expectLog(&.{ .http, .http });
+ // Not expectLog: an expected line is consumed before it can raise
+ // max_level. Discard the output instead.
+ sink = struct {
+ fn discard(_: []const u8) void {}
+ }.discard;
+ defer sink = null;
err(.http, "first", .{});
warn(.http, "second", .{});
try testing.expectEqual(.err, page.max_level);
diff --git a/src/mcp/HttpServer.zig b/src/mcp/HttpServer.zig
index f3c3527b8..52cac92fa 100644
--- a/src/mcp/HttpServer.zig
+++ b/src/mcp/HttpServer.zig
@@ -221,7 +221,7 @@ pub fn run(self: *HttpServer, address: sys_net.IpAddress) !void {
return;
}
switch (err) {
- error.ConnectionAborted => log.warn(.mcp, "accept connection aborted", .{}),
+ error.ConnectionAborted => log.debug(.mcp, "accept connection aborted", .{}),
else => log.err(.mcp, "accept error", .{ .err = err }),
}
continue;
diff --git a/src/mcp/router.zig b/src/mcp/router.zig
index b907b525b..bbc67380f 100644
--- a/src/mcp/router.zig
+++ b/src/mcp/router.zig
@@ -25,7 +25,7 @@ pub fn processRequests(server: anytype, reader: *std.Io.Reader, input: ?std.Io.F
const buffered_line = reader.takeDelimiter('\n') catch |err| switch (err) {
error.StreamTooLong => {
- log.err(.mcp, "Message too long", .{});
+ log.debug(.mcp, "Message too long", .{});
try server.sendError(.null, .InvalidRequest, "Message too long");
_ = reader.discardDelimiterInclusive('\n') catch |e| switch (e) {
error.EndOfStream => break,
@@ -83,7 +83,7 @@ pub fn handleMessage(server: anytype, arena: std.mem.Allocator, msg: []const u8)
const req = std.json.parseFromSliceLeaky(protocol.Request, arena, msg, .{
.ignore_unknown_fields = true,
}) catch |err| {
- log.warn(.mcp, "JSON Parse Error", .{ .err = err, .msg = msg });
+ log.debug(.mcp, "JSON Parse Error", .{ .err = err, .msg = msg });
try server.sendError(.null, .ParseError, "Parse error");
return;
};
@@ -167,8 +167,6 @@ test "MCP.router - handleMessage - synchronous unit tests" {
// 5. Parse error
{
- testing.expectLog(&.{.mcp});
-
try handleMessage(server, aa, "invalid json");
try testing.expectJson("{\"jsonrpc\": \"2.0\", \"id\": null, \"error\": {\"code\": -32700}}", out_alloc.writer.buffered());
}
diff --git a/src/network/CorsGate.zig b/src/network/CorsGate.zig
index 109264584..b6ab991b8 100644
--- a/src/network/CorsGate.zig
+++ b/src/network/CorsGate.zig
@@ -65,7 +65,7 @@ fn flushPending(self: *CorsGate, key: []const u8, allowed: bool) void {
if (!allowed) {
lp.metrics.cors_preflight.incr(.blocked);
- log.warn(.cors, "preflight blocked", .{ .url = transfer.req.url });
+ log.debug(.cors, "preflight blocked", .{ .url = transfer.req.url });
transfer.failAsync(error.CorsBlocked);
continue;
}
@@ -527,7 +527,7 @@ const CorsPreflightContext = struct {
fn errorCallback(ctx_ptr: *anyopaque, err: anyerror) void {
const self: *CorsPreflightContext = @ptrCast(@alignCast(ctx_ptr));
- log.warn(.cors, "preflight error", .{ .url = self.url, .err = err });
+ log.debug(.cors, "preflight error", .{ .url = self.url, .err = err });
self.resolve(false);
}
@@ -656,7 +656,7 @@ pub fn validateResponse(transfer: *Transfer) !void {
errdefer lp.metrics.cors_response.incr(.blocked);
const allow_origin = HttpClient.findHeader(transfer.res.headers, ACCESS_CONTROL_ALLOW_ORIGIN) orelse {
- log.warn(.cors, "blocked", .{ .url = req.url, .reason = "missing acao" });
+ log.debug(.cors, "blocked", .{ .url = req.url, .reason = "missing acao" });
return error.CorsBlocked;
};
@@ -664,14 +664,14 @@ pub fn validateResponse(transfer: *Transfer) !void {
const is_wildcard_origin = std.mem.eql(u8, allow_origin, "*");
if (is_wildcard_origin and wants_credentials) {
- log.warn(.cors, "blocked", .{ .url = req.url, .reason = "wildcard origin with credentials" });
+ log.debug(.cors, "blocked", .{ .url = req.url, .reason = "wildcard origin with credentials" });
return error.CorsBlocked;
}
if (!is_wildcard_origin) {
const origin = transfer.effectiveOrigin();
if (!std.mem.eql(u8, allow_origin, origin)) {
- log.warn(.cors, "blocked", .{
+ log.debug(.cors, "blocked", .{
.url = req.url,
.reason = "origin mismatch",
.allow_origin = allow_origin,
@@ -683,12 +683,12 @@ pub fn validateResponse(transfer: *Transfer) !void {
if (wants_credentials) {
const allow_creds = HttpClient.findHeader(transfer.res.headers, ACCESS_CONTROL_ALLOW_CREDENTIALS) orelse {
- log.warn(.cors, "blocked", .{ .url = req.url, .reason = "missing acac" });
+ log.debug(.cors, "blocked", .{ .url = req.url, .reason = "missing acac" });
return error.CorsBlocked;
};
if (!std.mem.eql(u8, allow_creds, "true")) {
- log.warn(.cors, "blocked", .{ .url = req.url, .reason = "credentials not allowed", .allow_credentials = allow_creds });
+ log.debug(.cors, "blocked", .{ .url = req.url, .reason = "credentials not allowed", .allow_credentials = allow_creds });
return error.CorsBlocked;
}
}
diff --git a/src/network/HttpClient.zig b/src/network/HttpClient.zig
index c0680b690..abbb09cb6 100644
--- a/src/network/HttpClient.zig
+++ b/src/network/HttpClient.zig
@@ -1112,7 +1112,7 @@ fn pipeline(self: *Client, transfer: *Transfer, from: SubmitFrom) !void {
if (self.obey_cors and !transfer.req.internal) {
if (!isCrossOriginModeAllowed(transfer)) {
- log.warn(.http, "blocked by mode", .{
+ log.debug(.http, "blocked by mode", .{
.url = transfer.req.url,
.mode = @tagName(transfer.req.request_mode),
});
@@ -1721,7 +1721,7 @@ fn processMessages(self: *Client) !bool {
// either buffered it for dispatch, parked it, or deinit'd it.
// Only the throw path cleans up here.
const done = self.processOneMessage(msg, transfer) catch |err| blk: {
- log.err(.http, "process_messages", .{ .err = err, .req = transfer });
+ log.debug(.http, "process_messages", .{ .err = err, .req = transfer });
if (transfer._conn) |c| {
self.removeConn(c);
transfer._conn = null;
@@ -3045,7 +3045,7 @@ pub const Transfer = struct {
// free. Only called from deliver().
fn failDelivery(self: *Transfer, err: anyerror) void {
if (err != error.TransferCanceled) {
- log.err(.http, "delivery callback", .{ .err = err, .req = self });
+ log.debug(.http, "delivery callback", .{ .err = err, .req = self });
}
self.requestFailed(err);
self.finishDelivery();
@@ -3791,7 +3791,7 @@ pub const Transfer = struct {
if (@intFromEnum(hdr.source) > @intFromEnum(source)) {
if (hdr.source == .fixed) {
- log.warn(.http, "ignore overriding fixed header", .{ .header = hdr.name });
+ log.debug(.http, "ignore overriding fixed header", .{ .header = hdr.name });
}
return;
}
@@ -3814,7 +3814,7 @@ pub const Transfer = struct {
fn verifyHeader(name: []const u8, value: []const u8) bool {
if (std.ascii.eqlIgnoreCase(name, "user-agent")) {
lp.Config.validateUserAgent(value) catch |err| {
- log.warn(.http, "invalid header dropped", .{ .name = name, .err = err });
+ log.debug(.http, "invalid header dropped", .{ .name = name, .err = err });
return false;
};
}
@@ -4959,13 +4959,11 @@ test "HttpClient: Transfer header layering" {
try testing.expectEqual("\"author-etag\"", transfer.findRequestHeader("if-none-match").?);
// nothing overrides a fixed header, whatever the layer or mode
- testing.expectLog(&.{ .http, .http });
try transfer.setHeader("sec-ch-ua", "\"Chromium\";v=\"140\"", .{ .source = .cdp });
try transfer.appendHeader("SEC-CH-UA", "\"Chromium\";v=\"140\"", .{ .source = .author });
try testing.expectEqual("\"Lightpanda\";v=\"1\"", transfer.findRequestHeader("sec-ch-ua").?);
// an invalid User-Agent never enters the list
- testing.expectLog(&.{.http});
try transfer.setHeader("user-agent", "Mozilla/5.0", .{ .source = .author });
try testing.expectEqual("Lightpanda/1.0", transfer.findRequestHeader("user-agent").?);
diff --git a/src/network/Robots.zig b/src/network/Robots.zig
index e02b644f1..da0b55718 100644
--- a/src/network/Robots.zig
+++ b/src/network/Robots.zig
@@ -317,7 +317,7 @@ fn parseRulesWithUserAgent(
if (true_line.len == 0) continue;
const colon_idx = std.mem.indexOfScalar(u8, true_line, ':') orelse {
- log.warn(.browser, "robots line missing colon", .{ .line = line });
+ log.debug(.browser, "robots line missing colon", .{ .line = line });
continue;
};
const key_str = try std.ascii.allocLowerString(allocator, true_line[0..colon_idx]);
@@ -375,7 +375,7 @@ fn parseRulesWithUserAgent(
try wildcard_rules.append(allocator, Rule.allowRule(duped_value));
},
.not_in_entry => {
- log.warn(.browser, "robots unexpected rule", .{ .rule = "allow" });
+ log.debug(.browser, "robots unexpected rule", .{ .rule = "allow" });
continue;
},
}
@@ -400,7 +400,7 @@ fn parseRulesWithUserAgent(
try wildcard_rules.append(allocator, Rule.disallowRule(duped_value));
},
.not_in_entry => {
- log.warn(.browser, "robots unexpected rule", .{ .rule = "disallow" });
+ log.debug(.browser, "robots unexpected rule", .{ .rule = "disallow" });
continue;
},
}
diff --git a/src/network/RobotsGate.zig b/src/network/RobotsGate.zig
index b9cc738b1..1ffe9a1e9 100644
--- a/src/network/RobotsGate.zig
+++ b/src/network/RobotsGate.zig
@@ -54,7 +54,7 @@ pub fn check(self: *RobotsGate, transfer: *Transfer) !Result {
switch (decision) {
.allowed => return .allowed,
.blocked => {
- log.warn(.http, "blocked by robots", .{ .url = url });
+ log.debug(.http, "blocked by robots", .{ .url = url });
return .blocked;
},
}
@@ -148,7 +148,7 @@ fn flushPending(self: *RobotsGate, robots_url: []const u8, outcome: Outcome) voi
if (decision == .blocked) {
lp.metrics.robots_access.incr(.deny);
- log.warn(.http, "blocked by robots", .{ .url = transfer.req.url });
+ log.debug(.http, "blocked by robots", .{ .url = transfer.req.url });
transfer.failAsync(error.RobotsBlocked);
continue;
}
@@ -207,7 +207,7 @@ const RobotsContext = struct {
// We only return an error if an allocation or something fails.
// Our parser does already leniently handle malformed input and takes whichever rules it can parse.
// On this case of an allocation failure, it is our fault so we put it as disallowed.
- log.warn(.browser, "error while parsing robots.txt", .{ .robots_url = robots_url, .err = err });
+ log.debug(.browser, "error while parsing robots.txt", .{ .robots_url = robots_url, .err = err });
self.settle(.{ .outcome = .{ .decision = .blocked } });
return;
};
@@ -230,7 +230,7 @@ const RobotsContext = struct {
},
// RFC9309: Unreachable (500-599) means that we are completely disallowed.
500...599 => {
- log.warn(.http, "robots.txt unreachable", .{
+ log.debug(.http, "robots.txt unreachable", .{
.url = robots_url,
.status = self.status,
});
@@ -249,7 +249,7 @@ const RobotsContext = struct {
fn errorCallback(ctx_ptr: *anyopaque, err: anyerror) void {
const self: *RobotsContext = @ptrCast(@alignCast(ctx_ptr));
- log.warn(.http, "robots fetch failed", .{ .err = err });
+ log.debug(.http, "robots fetch failed", .{ .err = err });
self.settle(.{
.outcome = .{ .decision = .allowed },
.cache = false,
diff --git a/src/network/http.zig b/src/network/http.zig
index 756280496..43773c890 100644
--- a/src/network/http.zig
+++ b/src/network/http.zig
@@ -288,9 +288,9 @@ fn opensocketCallback(
if (filter.isBlockedSockaddr(address)) {
if (address.family == posix.AF.INET or address.family == posix.AF.INET6) {
const ip = sys_net.addressFromSockaddr(@ptrCast(@alignCast(&address.addr)));
- log.warn(.http, "blocked by IP filter", .{ .ip = ip });
+ log.debug(.http, "blocked by IP filter", .{ .ip = ip });
} else {
- log.warn(.http, "blocked by IP filter", .{ .family = address.family });
+ log.debug(.http, "blocked by IP filter", .{ .family = address.family });
}
return libcurl.CURL_SOCKET_BAD;
}
diff --git a/src/server/Driver.zig b/src/server/Driver.zig
index d917c759d..65511985d 100644
--- a/src/server/Driver.zig
+++ b/src/server/Driver.zig
@@ -107,7 +107,7 @@ pub fn onMessage(self: *const Driver, msg: *Inbox.Message) anyerror!void {
pub fn onPing(self: *const Driver, body: []const u8) void {
const l = self.link() orelse return;
l.sendPong(body) catch |err| {
- log.warn(self.scope, "pong", .{ .err = err });
+ log.debug(self.scope, "pong", .{ .err = err });
};
}
@@ -141,7 +141,7 @@ pub fn onHttp(self: *const Driver, command: http_command.Command) void {
pub fn onClose(self: *const Driver) bool {
if (self.link()) |l| {
l.send(&WS.CLOSE_NORMAL) catch |err| {
- log.warn(self.scope, "close reply", .{ .err = err });
+ log.debug(self.scope, "close reply", .{ .err = err });
};
}
return self.onDisconnect(null);
@@ -152,7 +152,7 @@ pub fn onClose(self: *const Driver) bool {
pub fn onQuit(self: *const Driver) void {
if (self.link()) |l| {
l.send(&WS.CLOSE_NORMAL) catch |err| {
- log.warn(self.scope, "quit close", .{ .err = err });
+ log.debug(self.scope, "quit close", .{ .err = err });
};
}
log.info(self.scope, "session ended", .{});
@@ -217,7 +217,7 @@ fn tick(self: *const Driver) !bool {
// the close frame here can't interleave with another write.
if (self.link()) |l| {
l.send(&WS.CLOSE_GOING_AWAY) catch |err| {
- log.warn(self.scope, "terminate close", .{ .err = err });
+ log.debug(self.scope, "terminate close", .{ .err = err });
};
}
return false;
diff --git a/src/server/Server.zig b/src/server/Server.zig
index 6a598f121..af2888694 100644
--- a/src/server/Server.zig
+++ b/src/server/Server.zig
@@ -330,7 +330,7 @@ fn accept(self: *Server, now: u64) !void {
switch (err) {
error.WouldBlock => break,
error.ConnectionAborted => {
- log.warn(.serve, "accept connection aborted", .{});
+ log.debug(.serve, "accept connection aborted", .{});
continue;
},
error.ProcessFdQuotaExceeded, error.SystemFdQuotaExceeded => {
diff --git a/src/server/bidi/browser.zig b/src/server/bidi/browser.zig
index ab4f0d715..92dac1599 100644
--- a/src/server/bidi/browser.zig
+++ b/src/server/bidi/browser.zig
@@ -70,13 +70,13 @@ fn createUserContext(cmd: *BiDi.Command) !void {
unhandledPromptBehavior: ?std.json.Value = null,
});
if (p.proxy != null or p.acceptInsecureCerts != null or p.unhandledPromptBehavior != null) {
- log.warn(.not_implemented, "bidi.createUserContext", .{ .proxy = p.proxy != null, .acceptInsecureCerts = p.acceptInsecureCerts, .unhandledPromptBehavior = p.unhandledPromptBehavior != null });
+ log.debug(.not_implemented, "bidi.createUserContext", .{ .proxy = p.proxy != null, .acceptInsecureCerts = p.acceptInsecureCerts, .unhandledPromptBehavior = p.unhandledPromptBehavior != null });
return cmd.sendError("unsupported operation", "user context options are not supported");
}
const bidi = cmd.bidi;
if (bidi.user_context.isDefault() == false) {
- log.warn(.not_implemented, "bidi.createUserContext", .{ .feature = "multiple user contexts" });
+ log.debug(.not_implemented, "bidi.createUserContext", .{ .feature = "multiple user contexts" });
return cmd.sendError("unsupported operation", "only one user context can exist besides the default");
}
diff --git a/src/server/bidi/browsing_context.zig b/src/server/bidi/browsing_context.zig
index cb466c82a..bc4b02d66 100644
--- a/src/server/bidi/browsing_context.zig
+++ b/src/server/bidi/browsing_context.zig
@@ -110,7 +110,7 @@ fn create(cmd: *BiDi.Command) !void {
const bidi = cmd.bidi;
if (bidi.browsing_context != null) {
- log.warn(.not_implemented, "bidi.BrowingContext", .{ .feature = "multiple user contexts" });
+ log.debug(.not_implemented, "bidi.BrowingContext", .{ .feature = "multiple user contexts" });
return cmd.sendError("unsupported operation", "only a single browsing context is supported");
}
@@ -254,7 +254,7 @@ fn startNavigation(cmd: *BiDi.Command, ctx: *Context, frame: *Frame, url: [:0]co
bidi.user_context.session.initiateRootNavigation(frame._frame_id, url, nav_opts);
nav_result catch |err| {
- log.warn(.bidi, "navigate", .{ .err = err });
+ log.debug(.bidi, "navigate", .{ .err = err });
if (wait != .none and ctx.pending_navigate == null) {
// the lifecycle already answered it
return;
@@ -343,7 +343,7 @@ fn locateNodes(cmd: *BiDi.Command) !void {
else => return cmd.sendError("invalid argument", "locator value must be a string"),
},
.innerText, .accessibility, .context => {
- log.warn(.not_implemented, "bidi.locateNodes", .{ .locator = @tagName(p.locator.type) });
+ log.debug(.not_implemented, "bidi.locateNodes", .{ .locator = @tagName(p.locator.type) });
return cmd.sendError("unsupported operation", "locator type is not supported");
},
};
diff --git a/src/server/bidi/execute.zig b/src/server/bidi/execute.zig
index ec19ceb01..71e16a075 100644
--- a/src/server/bidi/execute.zig
+++ b/src/server/bidi/execute.zig
@@ -276,7 +276,7 @@ pub const Pending = struct {
self.answered = true;
bidi.replyResult(self.to, cloned) catch |err| {
- log.err(.bidi, "execute result", .{ .err = err, .reply = self.to });
+ log.debug(.bidi, "execute result", .{ .err = err, .reply = self.to });
};
}
@@ -286,7 +286,7 @@ pub const Pending = struct {
}
self.answered = true;
self.bidi.replyError(self.to, code, message) catch |err| {
- log.err(.bidi, "execute error", .{ .err = err, .reply = self.to });
+ log.debug(.bidi, "execute error", .{ .err = err, .reply = self.to });
};
}
diff --git a/src/server/bidi/script.zig b/src/server/bidi/script.zig
index 453816596..27f89d4e0 100644
--- a/src/server/bidi/script.zig
+++ b/src/server/bidi/script.zig
@@ -290,7 +290,7 @@ pub const Pending = struct {
};
result catch |err| {
- log.err(.bidi, "await promise", .{ .err = err, .reply = reply.to });
+ log.debug(.bidi, "await promise", .{ .err = err, .reply = reply.to });
};
}
@@ -419,7 +419,7 @@ fn serialize(
if (err == error.OutOfMemory) {
return err;
}
- log.warn(.bidi, "serialize", .{ .err = err });
+ log.debug(.bidi, "serialize", .{ .err = err });
try reply.sendError("unknown error", "cannot serialize result");
return null;
};
@@ -1171,7 +1171,6 @@ test "bidi.script: callFunction arguments" {
}
test "bidi.script: handles" {
- testing.expectLog(&.{.bidi});
var ctx = try testing.context();
defer ctx.deinit();
diff --git a/src/server/cdp/CDP.zig b/src/server/cdp/CDP.zig
index fd4d3df3d..9f59fec21 100644
--- a/src/server/cdp/CDP.zig
+++ b/src/server/cdp/CDP.zig
@@ -411,7 +411,7 @@ pub const BrowserContext = struct {
pub fn onInspectorResponse(ctx: *anyopaque, _: u32, msg: []const u8) void {
const self: *AttachedSession = @ptrCast(@alignCast(ctx));
self.bc.sendInspectorMessage(msg, self.id) catch |err| {
- log.err(.cdp, "send inspector response", .{ .err = err });
+ log.debug(.cdp, "send inspector response", .{ .err = err });
};
}
@@ -429,7 +429,7 @@ pub const BrowserContext = struct {
}
self.bc.sendInspectorMessage(msg, self.id) catch |err| {
- log.err(.cdp, "send inspector event", .{ .err = err });
+ log.debug(.cdp, "send inspector event", .{ .err = err });
};
}
};
@@ -683,7 +683,7 @@ pub const BrowserContext = struct {
pub fn createIsolatedWorld(self: *BrowserContext, world_name: []const u8, grant_universal_access: bool) !GetOrPutIsolatedWorld {
if (self.findIsolatedWorld(world_name)) |world| {
if (world.grant_universal_access != grant_universal_access) {
- log.warn(.cdp, "isolated world mismatch", .{ .name = world_name, .gua = grant_universal_access });
+ log.debug(.cdp, "isolated world mismatch", .{ .name = world_name, .gua = grant_universal_access });
}
return .{ .world = world, .found_existing = true };
}
diff --git a/src/server/cdp/domains/accessibility.zig b/src/server/cdp/domains/accessibility.zig
index 79346ec0a..31d0037d2 100644
--- a/src/server/cdp/domains/accessibility.zig
+++ b/src/server/cdp/domains/accessibility.zig
@@ -117,7 +117,7 @@ fn getPartialAXTree(cmd: *CDP.Command) !void {
if (params.fetchRelatives orelse true) {
// orelse true, because that's what Chrome defaults too, and if people
// aren't setting it, then they're expecting true.
- log.warn(.not_implemented, "getPartialAXTree", .{
+ log.debug(.not_implemented, "getPartialAXTree", .{
.cdp_cmd = "Accessibility.getPartialAXTree",
.param = "fetchRelatives",
});
diff --git a/src/server/cdp/domains/browser.zig b/src/server/cdp/domains/browser.zig
index 87d899e29..81c5ab55e 100644
--- a/src/server/cdp/domains/browser.zig
+++ b/src/server/cdp/domains/browser.zig
@@ -184,10 +184,10 @@ fn grantPermissions(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.origin) |v| {
- log.warn(.not_implemented, "Browser.grantPermissions", .{ .param = "origin", .value = v });
+ log.debug(.not_implemented, "Browser.grantPermissions", .{ .param = "origin", .value = v });
}
if (params.browserContextId) |v| {
- log.warn(.not_implemented, "Browser.grantPermissions", .{ .param = "browserContextId", .value = v });
+ log.debug(.not_implemented, "Browser.grantPermissions", .{ .param = "browserContextId", .value = v });
}
const browser = &cmd.cdp.browser;
@@ -209,10 +209,10 @@ fn setPermission(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.origin) |v| {
- log.warn(.not_implemented, "Browser.setPermission", .{ .param = "origin", .value = v });
+ log.debug(.not_implemented, "Browser.setPermission", .{ .param = "origin", .value = v });
}
if (params.browserContextId) |v| {
- log.warn(.not_implemented, "Browser.setPermission", .{ .param = "browserContextId", .value = v });
+ log.debug(.not_implemented, "Browser.setPermission", .{ .param = "browserContextId", .value = v });
}
const state = std.meta.stringToEnum(PermissionState, params.setting) orelse {
diff --git a/src/server/cdp/domains/dom.zig b/src/server/cdp/domains/dom.zig
index f113c83b5..be70a06aa 100644
--- a/src/server/cdp/domains/dom.zig
+++ b/src/server/cdp/domains/dom.zig
@@ -92,7 +92,7 @@ fn getDocument(cmd: *CDP.Command) !void {
const params = try cmd.params(Params) orelse Params{};
if (params.pierce) {
- log.warn(.not_implemented, "DOM.getDocument", .{ .param = "pierce" });
+ log.debug(.not_implemented, "DOM.getDocument", .{ .param = "pierce" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
@@ -432,7 +432,7 @@ fn describeNode(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.pierce) {
- log.warn(.not_implemented, "DOM.describeNode", .{ .param = "pierce" });
+ log.debug(.not_implemented, "DOM.describeNode", .{ .param = "pierce" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
@@ -627,7 +627,7 @@ fn getOuterHTML(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.includeShadowDOM) {
- log.warn(.not_implemented, "DOM.getOuterHTML", .{ .param = "includeShadowDOM" });
+ log.debug(.not_implemented, "DOM.getOuterHTML", .{ .param = "includeShadowDOM" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
const frame = bc.mainFrame() orelse return error.FrameNotLoaded;
diff --git a/src/server/cdp/domains/emulation.zig b/src/server/cdp/domains/emulation.zig
index 757a27e30..65fda606d 100644
--- a/src/server/cdp/domains/emulation.zig
+++ b/src/server/cdp/domains/emulation.zig
@@ -91,17 +91,17 @@ fn setDeviceMetricsOverride(cmd: *CDP.Command) !void {
screenHeight: ?u32 = null,
})) orelse return error.InvalidParams;
- // Not-yet-emulated parameters: accept them but warn so the caller knows
+ // Not-yet-emulated parameters: accept them but log so the caller knows
// they are ignored.
if (params.mobile) |v| {
- if (v) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ if (v) log.debug(.not_implemented, "setDeviceMetricsOverride", .{
.cdp_cmd = "Emulation.setDeviceMetricsOverride",
.param = "mobile",
.value = v,
});
}
if (params.scale) |v| {
- if (v != 0) log.warn(.not_implemented, "setDeviceMetricsOverride", .{
+ if (v != 0) log.debug(.not_implemented, "setDeviceMetricsOverride", .{
.cdp_cmd = "Emulation.setDeviceMetricsOverride",
.param = "scale",
.value = v,
@@ -147,7 +147,7 @@ pub fn setUserAgentOverride(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.platform) |v| {
- log.warn(.not_implemented, "Emulation.setUserAgentOverride", .{ .param = "platform", .value = v });
+ log.debug(.not_implemented, "Emulation.setUserAgentOverride", .{ .param = "platform", .value = v });
}
const ua = params.userAgent;
@@ -169,7 +169,7 @@ pub fn setUserAgentOverride(cmd: *CDP.Command) !void {
}
if (reserved) {
- log.warn(.not_implemented, "Emulation.setUserAgentOverride", .{ .param = "userAgent", .value = ua, .info = "User agent must not contain Mozilla" });
+ log.debug(.not_implemented, "Emulation.setUserAgentOverride", .{ .param = "userAgent", .value = ua, .info = "User agent must not contain Mozilla" });
return cmd.sendResult(null, .{});
}
@@ -217,7 +217,7 @@ fn setLocaleOverride(cmd: *CDP.Command) !void {
const Params = struct { locale: ?[]const u8 = null };
const params = (try cmd.params(Params)) orelse Params{};
if (params.locale) |v| {
- log.warn(.not_implemented, "Emulation.setLocaleOverride", .{ .locale = v });
+ log.debug(.not_implemented, "Emulation.setLocaleOverride", .{ .locale = v });
}
return cmd.sendResult(null, .{});
}
@@ -227,7 +227,7 @@ fn setTimezoneOverride(cmd: *CDP.Command) !void {
timezoneId: []const u8,
})) orelse return error.InvalidParams;
if (params.timezoneId.len > 0) {
- log.warn(.not_implemented, "Emulation.setTimezoneOverride", .{ .timezoneId = params.timezoneId });
+ log.debug(.not_implemented, "Emulation.setTimezoneOverride", .{ .timezoneId = params.timezoneId });
}
return cmd.sendResult(null, .{});
}
diff --git a/src/server/cdp/domains/fetch.zig b/src/server/cdp/domains/fetch.zig
index 9cec0b738..8be3b84eb 100644
--- a/src/server/cdp/domains/fetch.zig
+++ b/src/server/cdp/domains/fetch.zig
@@ -297,7 +297,7 @@ fn fulfillRequest(cmd: *CDP.Command) !void {
})) orelse return error.InvalidParams;
if (params.binaryResponseHeaders != null) {
- log.warn(.not_implemented, "Fetch.fulfillRequest", .{ .param = "binaryResponseHeaders" });
+ log.debug(.not_implemented, "Fetch.fulfillRequest", .{ .param = "binaryResponseHeaders" });
return error.NotImplemented;
}
@@ -474,7 +474,7 @@ pub const InterceptState = struct {
}
if (has_response_stage) {
- log.warn(.not_implemented, "Fetch.enable", .{ .params = "requestStage=Response" });
+ log.debug(.not_implemented, "Fetch.enable", .{ .params = "requestStage=Response" });
}
const owned = try self.allocator.alloc(Pattern, count);
@@ -675,8 +675,6 @@ test "cdp.Fetch: wildcardMatch" {
}
test "cdp.Fetch: InterceptState patterns" {
- testing.expectLog(&.{.not_implemented});
-
var state = try InterceptState.init(testing.allocator);
defer state.deinit();
diff --git a/src/server/cdp/domains/network.zig b/src/server/cdp/domains/network.zig
index e9d94cf76..204bea014 100644
--- a/src/server/cdp/domains/network.zig
+++ b/src/server/cdp/domains/network.zig
@@ -105,7 +105,7 @@ fn emulateNetworkConditions(cmd: *CDP.Command) !void {
}
// -1 disables a throughput limit.
if (params.latency > 0 or params.downloadThroughput > 0 or params.uploadThroughput > 0) {
- log.warn(.not_implemented, "Network.emulateConditions", .{ .param = "throttling" });
+ log.debug(.not_implemented, "Network.emulateConditions", .{ .param = "throttling" });
}
return cmd.sendResult(null, .{});
}
@@ -182,18 +182,18 @@ fn setExtraHTTPHeaders(cmd: *CDP.Command) !void {
const value = header.value_ptr.*;
if (Mime.isHttpToken(key) == false) {
- log.warn(.cdp, "network.setExtraHTTPHeaders", .{ .param = "header", .value = key, .info = "header name must be a non-empty HTTP token" });
+ log.debug(.cdp, "network.setExtraHTTPHeaders", .{ .param = "header", .value = key, .info = "header name must be a non-empty HTTP token" });
continue;
}
if (Mime.isHttpHeaderValue(value) == false) {
- log.warn(.cdp, "network.setExtraHTTPHeaders", .{ .param = "header", .value = key, .info = "header value must be Latin-1 text without CR, LF or NUL" });
+ log.debug(.cdp, "network.setExtraHTTPHeaders", .{ .param = "header", .value = key, .info = "header value must be Latin-1 text without CR, LF or NUL" });
continue;
}
if (std.ascii.eqlIgnoreCase(key, "user-agent")) {
Config.validateUserAgent(value) catch |err| {
- log.warn(.cdp, "network.setExtraHTTPHeaders", .{ .param = "userAgent", .value = value, .err = err });
+ log.debug(.cdp, "network.setExtraHTTPHeaders", .{ .param = "userAgent", .value = value, .err = err });
continue;
};
}
@@ -236,7 +236,7 @@ fn deleteCookies(cmd: *CDP.Command) !void {
// This allows Puppeteer's frame.setCookie() to work, which sends deleteCookies
// with partitionKey as part of its cookie-setting workflow.
if (params.partitionKey != null) {
- log.warn(.not_implemented, "partition key", .{ .src = "deleteCookies" });
+ log.debug(.not_implemented, "partition key", .{ .src = "deleteCookies" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
diff --git a/src/server/cdp/domains/page.zig b/src/server/cdp/domains/page.zig
index d2a51fb66..97f039979 100644
--- a/src/server/cdp/domains/page.zig
+++ b/src/server/cdp/domains/page.zig
@@ -203,7 +203,7 @@ fn addScriptToEvaluateOnNewDocument(cmd: *CDP.Command) !void {
ls.local.eval(source_dupe, null) catch |err| {
const caught = try_catch.caughtOrError(cmd.arena, err);
- log.warn(.cdp, "script on new doc", .{ .caught = caught });
+ log.debug(.cdp, "script on new doc", .{ .caught = caught });
};
}
}
@@ -256,7 +256,7 @@ fn createIsolatedWorld(cmd: *CDP.Command) !void {
grantUniveralAccess: bool = false,
})) orelse return error.InvalidParams;
if (!params.grantUniveralAccess) {
- log.warn(.not_implemented, "Page.createIsolatedWorld", .{ .param = "grantUniveralAccess" });
+ log.debug(.not_implemented, "Page.createIsolatedWorld", .{ .param = "grantUniveralAccess" });
// When grantUniveralAccess == false and the client attempts to resolve
// or otherwise access a DOM or other JS Object from another context that should fail.
}
@@ -810,7 +810,7 @@ pub fn frameNavigated(arena: Allocator, bc: *CDP.BrowserContext, event: *const N
ls.local.eval(script.source, null) catch |err| {
const caught = try_catch.caughtOrError(arena, err);
- log.warn(.cdp, "script on new doc", .{ .caught = caught });
+ log.debug(.cdp, "script on new doc", .{ .caught = caught });
};
}
@@ -1054,11 +1054,11 @@ fn captureScreenshot(cmd: *CDP.Command) !void {
const format = params.format orelse "png";
if (!std.mem.eql(u8, format, "png")) {
- log.warn(.not_implemented, "Page.captureScreenshot params", .{ .format = format });
+ log.debug(.not_implemented, "Page.captureScreenshot params", .{ .format = format });
return cmd.sendError(-32000, "unsupported screenshot format.", .{});
}
if (params.quality != null) {
- log.warn(.not_implemented, "Page.captureScreenshot params", .{ .quality = params.quality });
+ log.debug(.not_implemented, "Page.captureScreenshot params", .{ .quality = params.quality });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
@@ -1099,7 +1099,7 @@ fn printToPDF(cmd: *CDP.Command) !void {
};
const params = try cmd.params(Params) orelse Params{};
if (params.displayHeaderFooter) {
- log.warn(.not_implemented, "Page.printToPDF params", .{ .displayHeaderFooter = true });
+ log.debug(.not_implemented, "Page.printToPDF params", .{ .displayHeaderFooter = true });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
diff --git a/src/server/cdp/domains/storage.zig b/src/server/cdp/domains/storage.zig
index 38f00a928..e159295d4 100644
--- a/src/server/cdp/domains/storage.zig
+++ b/src/server/cdp/domains/storage.zig
@@ -163,7 +163,7 @@ fn buildCdpCookie(allocator: Allocator, param: CdpCookie) !Cookie {
// This allows Puppeteer's frame.setCookie() to work, which may send cookies with
// partitionKey as part of its cookie-setting workflow.
if (param.partitionKey != null) {
- log.warn(.not_implemented, "partition key", .{ .src = "buildCdpCookie" });
+ log.debug(.not_implemented, "partition key", .{ .src = "buildCdpCookie" });
}
// Still reject unsupported features
if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null) {
diff --git a/src/server/cdp/domains/target.zig b/src/server/cdp/domains/target.zig
index 1958b7d08..6ddcb438b 100644
--- a/src/server/cdp/domains/target.zig
+++ b/src/server/cdp/domains/target.zig
@@ -111,7 +111,7 @@ fn createBrowserContext(cmd: *CDP.Command) !void {
});
if (params) |p| {
if (p.disposeOnDetach or p.proxyBypassList != null or p.originsWithUniversalNetworkAccess != null) {
- log.warn(.not_implemented, "Target.createBrowserContext", .{ .disposeOnDetach = p.disposeOnDetach, .has_proxyBypassList = p.proxyBypassList != null, .has_originsWithUniversalNetworkAccess = p.originsWithUniversalNetworkAccess != null });
+ log.debug(.not_implemented, "Target.createBrowserContext", .{ .disposeOnDetach = p.disposeOnDetach, .has_proxyBypassList = p.proxyBypassList != null, .has_originsWithUniversalNetworkAccess = p.originsWithUniversalNetworkAccess != null });
}
}
@@ -380,7 +380,7 @@ fn sendMessageToTarget(cmd: *CDP.Command) !void {
var aw = std.Io.Writer.Allocating.init(cmd.arena);
cmd.cdp.dispatch(cmd.arena, .{ .capture = &aw.writer }, params.message) catch |err| {
- log.err(.cdp, "internal dispatch error", .{ .err = err, .id = cmd.input.id, .message = params.message });
+ log.debug(.cdp, "internal dispatch error", .{ .err = err, .id = cmd.input.id, .message = params.message });
return err;
};
diff --git a/src/server/cdp/domains/webmcp.zig b/src/server/cdp/domains/webmcp.zig
index 09ff2efe9..7681235a2 100644
--- a/src/server/cdp/domains/webmcp.zig
+++ b/src/server/cdp/domains/webmcp.zig
@@ -199,7 +199,7 @@ pub fn cancelAllPending(bc: *CDP.BrowserContext) void {
.invocationId = &id.toInvocationId(invocation.id),
.status = "Canceled",
}, .{ .session_id = bc.session_id }) catch |err| {
- log.err(.cdp, "WebMCP cancelAllPending", .{ .err = err });
+ log.debug(.cdp, "WebMCP cancelAllPending", .{ .err = err });
};
}
bc.webmcp_invocations.clearRetainingCapacity();
@@ -210,7 +210,7 @@ fn onPromiseFulfilled(invocation: *Invocation, value: js.Value) anyerror!void {
// removes it from the map and sends Canceled; we drop the late result.
if (invocation.bc.webmcp_invocations.fetchRemove(invocation.id) == null) return;
respondCompleted(invocation.bc.cdp, invocation.bc, invocation, value) catch |err| {
- log.err(.cdp, "WebMCP fulfilled", .{ .err = err });
+ log.debug(.cdp, "WebMCP fulfilled", .{ .err = err });
};
}
@@ -218,7 +218,7 @@ fn onPromiseRejected(invocation: *Invocation, reason: js.Value) anyerror!void {
if (invocation.bc.webmcp_invocations.fetchRemove(invocation.id) == null) return;
const msg = reason.toStringSlice() catch "tool rejected";
respondError(invocation.bc.cdp, invocation.bc, invocation, msg) catch |err| {
- log.err(.cdp, "WebMCP rejected", .{ .err = err });
+ log.debug(.cdp, "WebMCP rejected", .{ .err = err });
};
}
diff --git a/src/telemetry/lightpanda.zig b/src/telemetry/lightpanda.zig
index 85cd7fe22..2ff1770e5 100644
--- a/src/telemetry/lightpanda.zig
+++ b/src/telemetry/lightpanda.zig
@@ -184,7 +184,7 @@ fn run(self: *LightPanda) void {
var sent: usize = 0;
self.postEvents(&conn, batch.items, dropped, &sent) catch |err| {
- log.warn(.telemetry, "postEvents", .{ .err = err, .events = batch.items.len, .dropped = dropped });
+ log.debug(.telemetry, "postEvents", .{ .err = err, .events = batch.items.len, .dropped = dropped });
};
const lost: u32 = @intCast(batch.items.len - sent);
@@ -247,7 +247,7 @@ fn postEvents(self: *LightPanda, conn: *http.Connection, events: []const telemet
fn flush(self: *LightPanda, conn: *http.Connection) !void {
self._flush(conn) catch |err| {
- log.warn(.telemetry, "flush", .{ .err = err, .size = self.writer.written().len });
+ log.debug(.telemetry, "flush", .{ .err = err, .size = self.writer.written().len });
return err;
};
}
diff --git a/src/telemetry/telemetry.zig b/src/telemetry/telemetry.zig
index a3a7555cf..53cc582fa 100644
--- a/src/telemetry/telemetry.zig
+++ b/src/telemetry/telemetry.zig
@@ -55,7 +55,7 @@ fn TelemetryT(comptime P: type) type {
return;
}
self.provider.send(event) catch |err| {
- log.warn(.telemetry, "record error", .{ .err = err, .type = @tagName(std.meta.activeTag(event)) });
+ log.debug(.telemetry, "record error", .{ .err = err, .type = @tagName(std.meta.activeTag(event)) });
};
}