Lightpanda: the headless browser designed for AI and automation
v8: call v8__Platform__NotifyIsolateShutdown on isolate shutdown
Karl Seguin65f8a8358534
diff --git a/.github/actions/install/action.yml b/.github/actions/install/action.ymlindex 2266cec33..cea453685 100644--- a/.github/actions/install/action.yml+++ b/.github/actions/install/action.yml@@ -13,7 +13,7 @@ inputs:zig-v8:description: 'zig v8 version to install'required: false- default: 'v0.5.4'+ default: 'v0.5.5'v8:description: 'v8 version to install'required: falsediff --git a/.github/actions/v8-snapshot/action.yml b/.github/actions/v8-snapshot/action.ymlindex 20f2830e8..dfc98cb93 100644--- a/.github/actions/v8-snapshot/action.yml+++ b/.github/actions/v8-snapshot/action.yml@@ -13,7 +13,7 @@ inputs:zig-v8:description: 'zig-v8 release tag the prebuilt lib came from'required: false- default: 'v0.5.4'+ default: 'v0.5.5'runs:using: "composite"diff --git a/Dockerfile b/Dockerfileindex efd297324..b8490e751 100644--- a/Dockerfile+++ b/Dockerfile@@ -4,7 +4,7 @@ FROM debian:stable-slimARG MINISIG=0.12ARG ZIG_MINISIG=RWSGOq2NVecA2UPNdBUZykf1CCb147pkmdtYxgb3Ti+JO/wCYvhbAb/UARG V8=14.9.207.35-ARG ZIG_V8=v0.5.4+ARG ZIG_V8=v0.5.5ARG TARGETPLATFORMRUN apt-get update -yq && \diff --git a/build.zig.zon b/build.zig.zonindex d0bf21fcb..ea2aad0ba 100644--- a/build.zig.zon+++ b/build.zig.zon@@ -5,8 +5,8 @@.minimum_zig_version = "0.16.0",.dependencies = .{.v8 = .{- .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/dca81b538a52d5102181517ad87d9105629f94ec.tar.gz",- .hash = "v8-0.0.0-xddH6z0NAwA01BzbfQvo1wkOV6f2CjoNatGvv8mUn92X",+ .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/31b233ce6162c18eb37cacd001473057f75daad9.tar.gz",+ .hash = "v8-0.0.0-xddH62IdAwCZid1vyAzg_8IiWG4ovW7DbcnSvZd12I9p",},// .v8 = .{ .path = "../zig-v8-fork" },.brotli = .{diff --git a/src/browser/js/Env.zig b/src/browser/js/Env.zigindex 5586473fa..a3bb9cfbd 100644--- a/src/browser/js/Env.zig+++ b/src/browser/js/Env.zig@@ -241,6 +241,10 @@ pub fn deinit(self: *Env) void {allocator.free(self.eternal_function_templates);self.private_symbols.deinit();+ // This has to be before it's destroyed, since the handle has to exist to+ // be able to notify the platform about it. Documentation hits at this order:+ // "Notifies the given platform about the Isolate getting deleted soon"+ v8.v8__Platform__NotifyIsolateShutdown(self.platform.handle, self.isolate.handle);self.isolate.exit();self.isolate.deinit();v8.v8__ArrayBuffer__Allocator__DELETE(self.isolate_params.array_buffer_allocator.?);