Lightpanda: the headless browser designed for AI and automation
selector: match :read-write and :read-only per the HTML spec
Jay Hemnani6728051d46a3
diff --git a/src/browser/tests/element/pseudo_classes.html b/src/browser/tests/element/pseudo_classes.htmlindex 36b1c6cc6..6dd179d63 100644--- a/src/browser/tests/element/pseudo_classes.html+++ b/src/browser/tests/element/pseudo_classes.html@@ -129,3 +129,22 @@outer.remove();}</script>++<div id="rw">+ <input id="rw_text">+ <input id="rw_readonly" readonly>+ <input id="rw_disabled" disabled>+ <input id="rw_checkbox" type="checkbox">+ <input id="rw_number" type="number">+ <textarea id="rw_textarea"></textarea>+ <textarea id="rw_textarea_ro" readonly></textarea>+ <div id="rw_editable" contenteditable></div>+ <p id="rw_p"></p>+</div>+<script id="read_write">+{+ const ids = (sel) => Array.from(document.querySelectorAll('#rw ' + sel)).map((e) => e.id).join();+ testing.expectEqual('rw_text,rw_number,rw_textarea,rw_editable', ids(':read-write'));+ testing.expectEqual('rw_readonly,rw_disabled,rw_checkbox,rw_textarea_ro,rw_p', ids(':read-only'));+}+</script>diff --git a/src/browser/webapi/selector/List.zig b/src/browser/webapi/selector/List.zigindex 5614c1e26..16345242f 100644--- a/src/browser/webapi/selector/List.zig+++ b/src/browser/webapi/selector/List.zig@@ -505,6 +505,22 @@ fn attributeContainsWord(value: []const u8, word: []const u8) bool {return false;}+// https://html.spec.whatwg.org/multipage/semantics-other.html#selector-read-write+fn isReadWrite(el: *Node.Element) bool {+ if (el.is(Node.Element.Html.Input)) |input| {+ const readonly_applies = switch (input._input_type) {+ .text, .password, .email, .url, .tel, .search, .number => true,+ .date, .time, .@"datetime-local", .month, .week => true,+ else => false,+ };+ return readonly_applies and !el.hasAttributeInterned("readonly") and !el.isDisabled();+ }+ if (el.is(Node.Element.Html.TextArea) != null) {+ return !el.hasAttributeInterned("readonly") and !el.isDisabled();+ }+ return el.isEditingHost();+}+fn matchesPseudoClass(el: *Node.Element, pseudo: Selector.PseudoClass, scope: *Node, nth: ?*NthCache, frame: *Frame) bool {const node = el.asNode();switch (pseudo) {@@ -569,12 +585,8 @@ fn matchesPseudoClass(el: *Node.Element, pseudo: Selector.PseudoClass, scope: *N.in_range => return false,.out_of_range => return false,.placeholder_shown => return false,- .read_only => {- return el.hasAttributeInterned("readonly");- },- .read_write => {- return el.hasAttributeInterned("readonly") == false;- },+ .read_only => return !isReadWrite(el),+ .read_write => return isReadWrite(el),.default => return false,// User interaction