Lightpanda: the headless browser designed for AI and automation
Use for loops where a while counter was only an index
Adrià Arrufat6c05e00c59b0
diff --git a/src/agent/picker.zig b/src/agent/picker.zigindex 097fb3d75..762542347 100644--- a/src/agent/picker.zig+++ b/src/agent/picker.zig@@ -50,8 +50,7 @@ fn promptNumberedChoiceLine(header: []const u8, items: []const [:0]const u8, defvar stdin_buf: [128]u8 = undefined;var stdin = std.Io.File.stdin().readerStreaming(lp.io, &stdin_buf);- var attempt: u8 = 0;- while (attempt < 3) : (attempt += 1) {+ for (0..3) |_| {std.debug.print("{s}\n", .{header});for (items, 0..) |item, idx| {const marker: []const u8 = if (default) |d| (if (d == idx) " (default)" else "") else "";diff --git a/src/browser/js/Local.zig b/src/browser/js/Local.zigindex 05e6ed6d6..ef8bc9f6f 100644--- a/src/browser/js/Local.zig+++ b/src/browser/js/Local.zig@@ -884,9 +884,9 @@ pub const dictionary_group_marker = "js_grouped_dictionary";// automatically, but it's a lot easier just to check it and ask for a manual fix.pub fn assertDictionaryFieldOrder(comptime T: type) void {const field_names = @typeInfo(T).@"struct".field_names;- var i: usize = 1;- while (i < field_names.len) : (i += 1) {- if (std.mem.order(u8, field_names[i - 1], field_names[i]) == .gt) {+ if (field_names.len < 2) return;+ for (field_names[0 .. field_names.len - 1], field_names[1..]) |prev, next| {+ if (std.mem.order(u8, prev, next) == .gt) {@compileError("dictionary fields must be declared in lexicographic order: " ++ @typeName(T));}}diff --git a/src/browser/webapi/storage/Cookie.zig b/src/browser/webapi/storage/Cookie.zigindex 24bf8faac..62c040234 100644--- a/src/browser/webapi/storage/Cookie.zig+++ b/src/browser/webapi/storage/Cookie.zig@@ -1066,11 +1066,10 @@ test "Jar: add limit" {};// test the max number limit- var i: usize = 0;- while (i < max_jar_size) : (i += 1) {+ for (names) |name| {const c = Cookie{.arena = std.heap.ArenaAllocator.init(testing.allocator),- .name = names[i],+ .name = name,.domain = "lightpanda.io",.path = "/",.expires = null,diff --git a/src/cli.zig b/src/cli.zigindex 2821e6042..faa977783 100644--- a/src/cli.zig+++ b/src/cli.zig@@ -269,13 +269,12 @@ pub fn Builder(comptime commands: anytype) type {const Tag = std.math.IntFittingRange(0, len);var names: [len][:0]const u8 = undefined;- var i: usize = 0;- while (i < commands.len) : (i += 1) {- names[i] = commands[i].name;+ for (commands, 0..) |command, i| {+ names[i] = command.name;}// Entry for help.- names[i] = "help";+ names[commands.len] = "help";break :blk @Enum(Tag, .exhaustive, &names, &std.simd.iota(Tag, len));};@@ -396,9 +395,7 @@ pub fn Builder(comptime commands: anytype) type {var names: [len][:0]const u8 = undefined;var types: [len]type = undefined;- var i: usize = 0;- while (i < commands.len) : (i += 1) {- const command = commands[i];+ for (commands, 0..) |command, i| {const Command = @TypeOf(command);const options = command.options;@@ -417,8 +414,8 @@ pub fn Builder(comptime commands: anytype) type {}// Entry for help; just takes `Enum` itself.- names[i] = "help";- types[i] = Enum;+ names[commands.len] = "help";+ types[commands.len] = Enum;break :blk @Union(.auto, Enum, &names, &types, &@splat(.{}));};