Skip to content

Lightpanda: the headless browser designed for AI and automation

agent: handle Effort.null, bump zenai

Adrià Arrufat706dc87e23e7
diff --git a/build.zig.zon b/build.zig.zon
index 6082f5580..79156eab8 100644
--- a/build.zig.zon
+++ b/build.zig.zon
@@ -40,8 +40,8 @@
.hash = "N-V-__8AALc_rgC04POe18O0LKFRm4ouQpLtL3riscEmWp-Q",
},
.zenai = .{
- .url = "git+https://github.com/lightpanda-io/zenai.git#2f0973e6bfd7e56ba06983ea98adbe15145428c7",
- .hash = "zenai-0.0.0-iOY_VJlKCAAl5f2xNR19gykYxnYmf8GQhGxYYnlyZpy6",
+ .url = "git+https://github.com/lightpanda-io/zenai.git#8bfbb3e5788d278a63708db8ee5f58aa589f9fff",
+ .hash = "zenai-0.0.0-iOY_VHNwCAAZJVdc_8q-Vs7j5hexgpBh_8s6c6F1dlay",
},
.isocline = .{
.url = "git+https://github.com/arrufat/isocline#4a99434bee4a5ed04c1639514224d48cd55e1405",
diff --git a/src/agent/Agent.zig b/src/agent/Agent.zig
index fd11da445..1518d37f4 100644
--- a/src/agent/Agent.zig
+++ b/src/agent/Agent.zig
@@ -1275,10 +1275,11 @@ fn abortSave(self: *Agent, baseline: usize, reason: []const u8) void {
self.failSave(reason);
}
-/// Save synthesis warrants more reasoning than a normal turn. `.none` stays off
-/// so users can opt out on models that reject `reasoning_effort` (e.g. Mistral).
+/// Save synthesis warrants more reasoning than a normal turn. `.null` and
+/// `.none` are kept as chosen.
fn bumpedEffort(effort: Config.Effort) Config.Effort {
return switch (effort) {
+ .null => .null,
.none => .none,
.minimal => .low,
.low => .medium,
@@ -1926,8 +1927,11 @@ fn processUserMessage(self: *Agent, input: TurnInput) !?[]const u8 {
.max_tokens = 4096,
.tool_choice = .none,
// .low caps thinking so reasoning models still emit an answer;
- // `.none` stays off to opt out on models that reject it.
- .effort = if (self.effort == .none) .none else .low,
+ // `.null` and `.none` are kept as chosen.
+ .effort = switch (self.effort) {
+ .null, .none => self.effort,
+ else => .low,
+ },
.cancel = .{ .context = @ptrCast(self), .checkFn = checkCancel },
.before_request = .{ .context = @ptrCast(self), .callFn = beforeRequest },
.after_response = .{ .context = @ptrCast(self), .callFn = afterResponse },
diff --git a/src/agent/settings.zig b/src/agent/settings.zig
index 3594b71e4..0ef519edc 100644
--- a/src/agent/settings.zig
+++ b/src/agent/settings.zig
@@ -453,6 +453,20 @@ test "parseRemembered: search_engine field round-trips" {
try testing.expect(remembered.search_engine == .brave);
}
+test "parseRemembered: effort .null round-trips as a value, not an absent field" {
+ var buf: [256]u8 = undefined;
+ var w: std.Io.Writer = .fixed(&buf);
+ try std.zon.stringify.serialize(Remembered{ .model = "m", .effort = .null }, .{}, &w);
+ var src: [257]u8 = undefined;
+ @memcpy(src[0..w.buffered().len], w.buffered());
+ src[w.buffered().len] = 0;
+
+ var arena: std.heap.ArenaAllocator = .init(testing.allocator);
+ defer arena.deinit();
+ const remembered = parseRemembered(testing.allocator, arena.allocator(), src[0..w.buffered().len :0]).?;
+ try testing.expect(remembered.effort.? == .null);
+}
+
test "resolveSearchEngine: default auto, remembered wins" {
try testing.expect(resolveSearchEngine(null) == .auto);
try testing.expect(resolveSearchEngine(.{ .model = "m", .search_engine = null }) == .auto);