Lightpanda: the headless browser designed for AI and automation
css: honor pointer-events:none in computed style and hit testing
Adrià Arrufat728e8638d5a3
diff --git a/src/browser/tests/document/element_from_point_pointer_events.html b/src/browser/tests/document/element_from_point_pointer_events.htmlnew file mode 100644index 000000000..b589c2eb6--- /dev/null+++ b/src/browser/tests/document/element_from_point_pointer_events.html@@ -0,0 +1,53 @@+<!DOCTYPE html>+<script src="../testing.js"></script>+<style>+ .dead { pointer-events: none; }+</style>++<body>+ <div id="plain">Plain</div>+ <div id="under">+ <span id="dead" class="dead">Dead</span>+ </div>+ <div id="wrap" style="pointer-events: none">+ <div id="inherits">Inherits</div>+ <div id="live" style="pointer-events: auto">Live</div>+ </div>+</body>++<script id="computed_pointer_events">+{+ const pe = (id) => getComputedStyle(document.getElementById(id)).pointerEvents;+ testing.expectEqual('auto', pe('plain'));+ testing.expectEqual('none', pe('dead'));+ testing.expectEqual('none', pe('wrap'));+ testing.expectEqual('none', pe('inherits'));+ testing.expectEqual('auto', pe('live'));+ testing.expectEqual('none', getComputedStyle(document.getElementById('wrap')).getPropertyValue('pointer-events'));+}+</script>++<script id="hit_skips_pointer_events_none">+{+ const center = (el) => {+ const r = el.getBoundingClientRect();+ return [(r.left + r.right) / 2, (r.top + r.bottom) / 2];+ };++ // The hit falls through to an element underneath: #under in a real+ // layout, possibly a further ancestor in ours.+ const dead = document.getElementById('dead');+ const hit = document.elementFromPoint(...center(dead));+ testing.expectTrue(hit !== dead && hit.contains(dead));+ testing.expectFalse(document.elementsFromPoint(...center(dead)).includes(dead));++ // A pointer-events:auto child of a pointer-events:none parent is hit, and+ // the parent is left out of the stack.+ const live = document.getElementById('live');+ testing.expectEqual(live, document.elementFromPoint(...center(live)));+ const stack = document.elementsFromPoint(...center(live));+ testing.expectEqual(live, stack[0]);+ testing.expectFalse(stack.includes(document.getElementById('wrap')));+ testing.expectEqual(document.documentElement, stack[stack.length - 1]);+}+</script>diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zigindex dc4c6e13c..fe148ae64 100644--- a/src/browser/webapi/Document.zig+++ b/src/browser/webapi/Document.zig@@ -1020,7 +1020,9 @@ fn elementFromPointImpl(self: *Document, x: f64, y: f64, ignore_x: bool, frame:preorder_index += 1;if (node.is(Element)) |element| {hidden = hidden or style_manager.hasDisplayNone(element);- if (!hidden) {+ // pointer-events:none lets the hit fall through to what's under+ // it, but a child can opt back in, so the subtree is still walked.+ if (!hidden and !style_manager.hasPointerEventsNone(element)) {if (y >= pos and y <= pos + element.boxAxis(frame, .height)) {if (ignore_x) {topmost = element;@@ -1052,7 +1054,10 @@ fn elementsFromPoint(self: *Document, x: f64, y: f64, frame: *Frame) ![]const *Evar current: ?*Element = (try self.elementFromPoint(x, y, frame)) orelse return &.{};var result: std.ArrayList(*Element) = .empty;while (current) |el| {- try result.append(frame.local_arena, el);+ // The root element is always last, as in Chrome, even when it isn't hit.+ if (el.parentElement() == null or !el.hasPointerEventsNone(frame)) {+ try result.append(frame.local_arena, el);+ }current = el.parentElement();}return result.items;diff --git a/src/browser/webapi/css/CSSStyleDeclaration.zig b/src/browser/webapi/css/CSSStyleDeclaration.zigindex 4edfbb7a5..030111868 100644--- a/src/browser/webapi/css/CSSStyleDeclaration.zig+++ b/src/browser/webapi/css/CSSStyleDeclaration.zig@@ -79,7 +79,8 @@ pub fn getPropertyValue(self: *const CSSStyleDeclaration, property_name: []const// Computed styles must reflect stylesheet rules, not just the element's// inline `style=` attribute. Limited to display/visibility — what aria- // tree builders (Playwright ariaSnapshot) consult on every element.+ // tree builders (Playwright ariaSnapshot) consult on every element — and+ // pointer-events, which tells agents a control can't be clicked.if (self._is_computed) {if (self._element) |element| {if (element.ownerFrame(frame)) |owner| {@@ -92,6 +93,10 @@ pub fn getPropertyValue(self: *const CSSStyleDeclaration, property_name: []constif (style_manager.hasVisibilityHiddenInherited(element)) {return "hidden";}+ } else if (wrapped.eqlSlice("pointer-events")) {+ if (style_manager.hasPointerEventsNone(element)) {+ return "none";+ }}}}@@ -971,6 +976,11 @@ fn getDefaultPropertyValue(self: *const CSSStyleDeclaration, name: String) []conreturn "visible";}},+ 14 => {+ if (name.eqlSlice("pointer-events")) {+ return "auto";+ }+ },16 => {if (name.eqlSlice("background-color")) {// transparent