Lightpanda: the headless browser designed for AI and automation
hook up child srcset when created via fragment parser
Karl Seguin790a6e5bb9e0
diff --git a/src/browser/frame/parse.zig b/src/browser/frame/parse.zigindex 338b85916..c4251e3a8 100644--- a/src/browser/frame/parse.zig+++ b/src/browser/frame/parse.zig@@ -95,8 +95,10 @@ pub fn fragment(frame: *Frame, node: *Node, html: []const u8, opts: FragmentParswhile (it.next()) |child| {child._parent = node;}- // Nor did the options among them reach their select.+ // Nor did the options among them reach their select, nor the images+ // their picture.Element.Html.Select.childrenInserted(node);+ try Element.Html.Picture.childrenInserted(node, frame);}// Build a detached XMLDocument from `xml` (DOMParser.parseFromString anddiff --git a/src/browser/tests/element/html/image_srcset.html b/src/browser/tests/element/html/image_srcset.htmlindex e7555a35b..4887d38bd 100644--- a/src/browser/tests/element/html/image_srcset.html+++ b/src/browser/tests/element/html/image_srcset.html@@ -176,3 +176,40 @@testing.expectEqual(1, loads);});</script>++<script id="picture_fragment_parse" type=module>+ // A fragment parse links its children onto the target in one go, without+ // going through the insertion path, so the selection has to be redone+ // afterwards; otherwise the img keeps the src it picked while it was still+ // under the parser's wrapper, and later mutations compare against that.+ const state = await testing.async();+ const picture = document.createElement("picture");+ document.body.append(picture);+ picture.innerHTML = '<source srcset="/inner-source.png"><img src="/inner-img.png">';+ const img = picture.querySelector("img");+ const parsed = img.currentSrc;++ // insertAdjacentHTML parses into a fragment and moves the children in one+ // at a time, so it goes through the insertion path+ const adjacent_picture = document.createElement("picture");+ document.body.append(adjacent_picture);+ adjacent_picture.insertAdjacentHTML("beforeend", '<source srcset="/adjacent-source.png"><img src="/adjacent-img.png">');+ const adjacent = adjacent_picture.querySelector("img").currentSrc;++ // let the parses' load events flush before counting+ await new Promise(resolve => setTimeout(resolve, 10));+ let loads = 0;+ img.addEventListener("load", () => loads += 1);++ // the source is gone, so the selection falls back to the img's own src+ picture.querySelector("source").remove();+ await new Promise(resolve => setTimeout(resolve, 10));++ state.resolve();+ await state.done(() => {+ testing.expectEqual(testing.ORIGIN + "/inner-source.png", parsed);+ testing.expectEqual(testing.ORIGIN + "/adjacent-source.png", adjacent);+ testing.expectEqual(testing.ORIGIN + "/inner-img.png", img.currentSrc);+ testing.expectEqual(1, loads);+ });+</script>diff --git a/src/browser/webapi/element/html/Picture.zig b/src/browser/webapi/element/html/Picture.zigindex 7ca25daeb..005c2e107 100644--- a/src/browser/webapi/element/html/Picture.zig+++ b/src/browser/webapi/element/html/Picture.zig@@ -72,6 +72,15 @@ pub fn childRemoved(parent: *Node, child: *Node, next_sibling: ?*Node, frame: *F};}+// parse.fragment links every child of a parent at once, so the <img> among+// them never saw its <picture> parent.+pub fn childrenInserted(parent: *Node, frame: *Frame) !void {+ if (parent.is(Picture) == null) {+ return;+ }+ return imagesFrom(parent.firstChild(), frame);+}+pub fn sourceChanged(source: *Node, frame: *Frame) !void {const parent = source._parent orelse return;if (parent.is(Picture) == null) {