Skip to content

Lightpanda: the headless browser designed for AI and automation

more local_arena, less pub

Karl Seguin7945df66bafc
diff --git a/src/browser/Frame.zig b/src/browser/Frame.zig
index ba97d0738..ab0374eb1 100644
--- a/src/browser/Frame.zig
+++ b/src/browser/Frame.zig
@@ -2373,7 +2373,6 @@ pub fn dupeSSO(self: *Frame, value: []const u8) !String {
const RemoveNodeOpts = struct {
will_be_reconnected: bool,
// Set to false when the caller queues its own combined mutation record
- // (e.g. replaceChildren's single "replace all" record).
notify_observers: bool = true,
};
pub fn removeNode(self: *Frame, parent: *Node, child: *Node, opts: RemoveNodeOpts) void {
@@ -2509,7 +2508,6 @@ const InsertNodeOpts = struct {
child_already_connected: bool = false,
adopting_to_new_document: bool = false,
// Set to false when the caller queues its own combined mutation record
- // (e.g. replaceChildren's single "replace all" record).
notify_observers: bool = true,
};
pub fn insertNodeRelative(self: *Frame, parent: *Node, child: *Node, relative: InsertNodeRelative, opts: InsertNodeOpts) !void {
diff --git a/src/browser/webapi/Element.zig b/src/browser/webapi/Element.zig
index efcc7aaff..830810e0d 100644
--- a/src/browser/webapi/Element.zig
+++ b/src/browser/webapi/Element.zig
@@ -487,7 +487,7 @@ pub fn setOuterHTML(self: *Element, html: []const u8, frame: *Frame) !void {
var it = fragment.childrenIterator();
while (it.next()) |child| {
if (notify) {
- try added.append(frame.call_arena, child);
+ try added.append(frame.local_arena, child);
}
frame.removeNode(fragment, child, .{ .will_be_reconnected = dest_connected, .notify_observers = false });
try frame.insertNodeRelative(parent, child, .{ .before = node }, .{ .notify_observers = false });
diff --git a/src/browser/webapi/MutationObserver.zig b/src/browser/webapi/MutationObserver.zig
index 3c20732d0..d3d9b4d82 100644
--- a/src/browser/webapi/MutationObserver.zig
+++ b/src/browser/webapi/MutationObserver.zig
@@ -350,7 +350,6 @@ pub fn deliverRecords(self: *MutationObserver, frame: *Frame) !void {
defer ls.deinit();
var caught: js.TryCatch.Caught = undefined;
- // Per spec, the callback is invoked with the observer as its this value.
ls.toLocal(self._callback).tryCallWithThis(void, self, .{ records, self }, &caught) catch |err| {
log.err(.frame, "MutObserver.deliverRecords", .{ .err = err, .caught = caught });
return err;
diff --git a/src/browser/webapi/Node.zig b/src/browser/webapi/Node.zig
index 923080608..1057515a5 100644
--- a/src/browser/webapi/Node.zig
+++ b/src/browser/webapi/Node.zig
@@ -127,7 +127,7 @@ pub fn is(self: *Node, comptime T: type) ?*T {
/// NoModificationAllowedError for a null or document parent, while
/// insertAdjacentElement/Text return null for a null parent and otherwise
/// rely on the pre-insert validity checks (HierarchyRequestError).
-pub const AdjacentVariant = enum { html, node };
+const AdjacentVariant = enum { html, node };
/// Given a position, returns target and previous nodes required for
/// insertAdjacentHTML, insertAdjacentElement and insertAdjacentText.
@@ -1274,11 +1274,11 @@ pub fn replaceChildren(self: *Node, nodes: []const NodeOrText, frame: *Frame) !v
var frag_it = frag.asNode().childrenIterator();
while (frag_it.next()) |frag_child| {
try validateNodeInsertion(self, frag_child);
- try children_to_add.append(frame.call_arena, frag_child);
+ try children_to_add.append(frame.local_arena, frag_child);
}
} else {
try validateNodeInsertion(self, child);
- try children_to_add.append(frame.call_arena, child);
+ try children_to_add.append(frame.local_arena, child);
}
}
@@ -1294,7 +1294,7 @@ pub fn replaceChildren(self: *Node, nodes: []const NodeOrText, frame: *Frame) !v
var it = self.childrenIterator();
while (it.next()) |child| {
if (notify) {
- try removed.append(frame.call_arena, child);
+ try removed.append(frame.local_arena, child);
}
frame.removeNode(self, child, .{ .will_be_reconnected = false, .notify_observers = false });
}
@@ -1328,7 +1328,7 @@ pub fn setHTML(self: *Node, html: []const u8, allow_declarative_shadow: bool, fr
var it = self.childrenIterator();
while (it.next()) |child| {
if (notify) {
- try removed.append(frame.call_arena, child);
+ try removed.append(frame.local_arena, child);
}
frame.removeNode(self, child, .{ .will_be_reconnected = false, .notify_observers = false });
}
@@ -1345,7 +1345,7 @@ pub fn setHTML(self: *Node, html: []const u8, allow_declarative_shadow: bool, fr
var added: std.ArrayList(*Node) = .empty;
var child_it = self.childrenIterator();
while (child_it.next()) |child| {
- try added.append(frame.call_arena, child);
+ try added.append(frame.local_arena, child);
}
if (removed.items.len > 0 or added.items.len > 0) {
Frame.observers.notifyChildListChange(frame, self, added.items, removed.items, null, null);
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index 3e62aa99b..4cd12b702 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -287,7 +287,7 @@ pub fn insertAdjacentHTML(
const fragment = (try DocumentFragment.init(frame)).asNode();
try frame.parseHtmlAsChildren(fragment, html);
- const target_node, const prev_node = try self.asElement().asNode().findAdjacentNodes(position, .html);
+ const target_node, const prev_node = try self.asNode().findAdjacentNodes(position, .html);
var iter = fragment.childrenIterator();
while (iter.next()) |child_node| {