Skip to content

Lightpanda: the headless browser designed for AI and automation

`Crypto(HMAC)`: check signature length and sign length are equal

Halil Durak79c90cf876dd
diff --git a/src/browser/webapi/crypto/HMAC.zig b/src/browser/webapi/crypto/HMAC.zig
index 9e6dd8d0e..a897a02db 100644
--- a/src/browser/webapi/crypto/HMAC.zig
+++ b/src/browser/webapi/crypto/HMAC.zig
@@ -202,6 +202,11 @@ pub fn verify(
resolver.resolve("HMAC.verify", false);
return resolver.promise();
};
+ // Check that lengths match; CRYPTO_memcmp can't cover this.
+ if (@as(u32, @intCast(signature.len)) != out_len) {
+ resolver.resolve("HMAC.verify", false);
+ return resolver.promise();
+ }
// CRYPTO_memcmp compare in constant time so prohibits time-based attacks.
const res = crypto.CRYPTO_memcmp(signed, @ptrCast(signature.ptr), signature.len);