Lightpanda: the headless browser designed for AI and automation
Expand to destination to all stderr destination
Karl Seguin7b7c7d7b0bdb
diff --git a/src/crash_handler.zig b/src/crash_handler.zigindex 9eacbc257..e4f180aeb 100644--- a/src/crash_handler.zig+++ b/src/crash_handler.zig@@ -163,25 +163,41 @@ fn report(reason: []const u8, begin_addr: usize, args: anytype) !void {}fn curlPath(buf: []u8) ?usize {- const path_z = std.c.getenv("PATH") orelse return null;- var it = std.mem.tokenizeScalar(u8, std.mem.span(path_z), std.fs.path.delimiter);+ const cwd = std.Io.Dir.cwd();- var fba = std.heap.FixedBufferAllocator.init(buf);- const allocator = fba.allocator();+ if (std.c.getenv("PATH")) |path_z| {+ var it = std.mem.tokenizeScalar(u8, std.mem.span(path_z), std.fs.path.delimiter);- const cwd = std.Io.Dir.cwd();- while (it.next()) |p| {- defer fba.reset();- const full_path = std.fs.path.joinZ(allocator, &.{ p, "curl" }) catch continue;- cwd.access(lp.io, full_path, .{}) catch continue;- return full_path.len;+ var fba = std.heap.FixedBufferAllocator.init(buf);+ const allocator = fba.allocator();++ while (it.next()) |p| {+ defer fba.reset();+ const full_path = std.fs.path.joinZ(allocator, &.{ p, "curl" }) catch continue;+ cwd.access(lp.io, full_path, .{}) catch continue;+ return full_path.len;+ }+ }++ // A supervisor that replaces the environment rather than extending it+ // leaves us with no PATH at all, and every crash report with it.+ for ([_][]const u8{ "/usr/bin/curl", "/bin/curl", "/usr/local/bin/curl" }) |candidate| {+ if (candidate.len >= buf.len) continue;+ @memcpy(buf[0..candidate.len], candidate);+ buf[candidate.len] = 0;+ cwd.access(lp.io, buf[0..candidate.len :0], .{}) catch continue;+ return candidate.len;}return null;}const fatal_signals = [_]std.posix.SIG{ .SEGV, .BUS, .ILL, .FPE };+const max_backtrace_frames = 32;+// A frame further than a whole thread stack from its caller is not a frame.+const max_frame_distance = 8 << 20;+// Initialized before threads start; owned until process exit.-var signal_pipe_fd: std.c.fd_t = -1;+var signal_output_fd: std.c.fd_t = -1;var signal_handlers_attached = false;// Best-effort record of a fatal signal, written before the process dies of@@ -194,7 +210,7 @@ var signal_handlers_attached = false;pub fn attachSignalHandlers() void {if (builtin.os.tag != .linux or signal_handlers_attached) return;signal_handlers_attached = true;- signal_pipe_fd = openSignalPipe();+ signal_output_fd = openSignalOutput();var mask = std.posix.sigemptyset();std.posix.sigaddset(&mask, .PIPE);const act: std.posix.Sigaction = .{@@ -205,31 +221,44 @@ pub fn attachSignalHandlers() void {for (fatal_signals) |sig| std.posix.sigaction(sig, &act, null);}-fn openSignalPipe() std.c.fd_t {+fn openSignalOutput() std.c.fd_t {if (builtin.os.tag != .linux) return -1;+ const S = std.os.linux.S;+const raw_flags = std.c.fcntl(2, std.posix.F.GETFL);if (raw_flags < 0) return -1;const flags: std.posix.O = @bitCast(@as(u32, @intCast(raw_flags)));if (flags.ACCMODE == .RDONLY) return -1;+var original: std.os.linux.Statx = undefined;- if (!statPipe(2, &original)) return -1;- // Unlike dup(), procfs gives us independent O_NONBLOCK flags.- const fd = std.c.open("/proc/self/fd/2", .{ .ACCMODE = .WRONLY, .NONBLOCK = true, .CLOEXEC = true });+ if (!statFd(2, &original)) return -1;+ const is_regular = S.ISREG(original.mode);+ if (!is_regular and !S.ISFIFO(original.mode) and !S.ISCHR(original.mode)) return -1;++ // Unlike dup(), procfs gives us independent O_NONBLOCK flags. A regular+ // file additionally needs O_APPEND: the new description starts at offset+ // zero and would otherwise overwrite the head of the log.+ const fd = std.c.open("/proc/self/fd/2", .{+ .ACCMODE = .WRONLY,+ .NONBLOCK = true,+ .CLOEXEC = true,+ .APPEND = is_regular,+ });if (fd < 0) return -1;var reopened: std.os.linux.Statx = undefined;- if (!statPipe(fd, &reopened) or reopened.dev_major != original.dev_major or- reopened.dev_minor != original.dev_minor or reopened.ino != original.ino)- {+ if (!statFd(fd, &reopened) or reopened.dev_major != original.dev_major or reopened.dev_minor != original.dev_minor or reopened.ino != original.ino) {_ = std.c.close(fd);return -1;}return fd;}-fn statPipe(fd: std.c.fd_t, stat: *std.os.linux.Statx) bool {+fn statFd(fd: std.c.fd_t, stat: *std.os.linux.Statx) bool {const linux = std.os.linux;- if (linux.statx(fd, "", linux.AT.EMPTY_PATH, .{ .TYPE = true, .INO = true }, stat) != 0) return false;- return stat.mask.TYPE and stat.mask.INO and linux.S.ISFIFO(stat.mode);+ if (linux.statx(fd, "", linux.AT.EMPTY_PATH, .{ .TYPE = true, .INO = true }, stat) != 0) {+ return false;+ }+ return stat.mask.TYPE and stat.mask.INO;}fn handleFatalSignal(sig: std.posix.SIG, info: *const std.posix.siginfo_t, ctx_ptr: ?*anyopaque) callconv(.c) noreturn {@@ -237,22 +266,39 @@ fn handleFatalSignal(sig: std.posix.SIG, info: *const std.posix.siginfo_t, ctx_pconst default: std.posix.Sigaction = .{ .handler = .{ .handler = std.posix.SIG.DFL }, .mask = std.posix.sigemptyset(), .flags = 0 };for (fatal_signals) |fatal| _ = std.c.sigaction(fatal, &default, null);+ const opt_context: ?std.debug.cpu_context.Native = if (ctx_ptr == null) null else std.debug.cpu_context.fromPosixSignalContext(ctx_ptr);+ const context: ?*const std.debug.cpu_context.Native = if (opt_context) |*ctx| ctx else null;+var buffer: [512]u8 = undefined;var writer: std.Io.Writer = .fixed(&buffer);- writeSignalContext(&writer, sig, info, ctx_ptr) catch {};- const record = writer.buffered();- if (signal_pipe_fd >= 0) {- _ = std.c.write(signal_pipe_fd, record.ptr, record.len);+ writeSignalContext(&writer, sig, info, context) catch {};+ writeRecord(writer.buffered());++ // Written separately because walking the frame chain reads memory the+ // fault may already have invalidated: the record above has to survive a+ // second fault in here.+ if (context) |ctx| {+ writeBacktrace(ctx);+ }++ _ = std.c.raise(sig);+ std.c._exit(@intCast(128 + @intFromEnum(sig)));+}++fn writeRecord(record: []const u8) void {+ if (record.len == 0) {+ return;+ }+ if (signal_output_fd >= 0) {+ _ = std.c.write(signal_output_fd, record.ptr, record.len);} else {// Per-call flags leave inherited stderr flags unchanged. Non-sockets// fail with ENOTSOCK: omit the record rather than risk blocking._ = std.c.send(2, record.ptr, record.len, std.c.MSG.DONTWAIT | std.c.MSG.NOSIGNAL);}- _ = std.c.raise(sig);- std.c._exit(@intCast(128 + @intFromEnum(sig)));}-fn writeSignalContext(writer: *std.Io.Writer, sig: std.posix.SIG, info: *const std.posix.siginfo_t, ctx_ptr: ?*anyopaque) !void {+fn writeSignalContext(writer: *std.Io.Writer, sig: std.posix.SIG, info: *const std.posix.siginfo_t, context: ?*const std.debug.cpu_context.Native) !void {try writer.print("\nLightpanda fatal signal: {t} ({d})\nversion: {s}\nOS: {s}\nmode: {s}\ncode: {d}\n", .{sig, @intFromEnum(sig), lp.build_config.version, @tagName(builtin.os.tag), @tagName(builtin.mode), info.code,});@@ -263,16 +309,51 @@ fn writeSignalContext(writer: *std.Io.Writer, sig: std.posix.SIG, info: *const s}// Runtime address of a known symbol for offline ASLR adjustment.try writer.print("crash_handler.handleFatalSignal: 0x{x}\n", .{@intFromPtr(&handleFatalSignal)});- if (ctx_ptr != null) {- if (std.debug.cpu_context.fromPosixSignalContext(ctx_ptr)) |ctx| {- try writer.print("pc: 0x{x}\nfp: 0x{x}\n", .{ ctx.getPc(), ctx.getFp() });- switch (builtin.cpu.arch) {- .aarch64 => try writer.print("sp: 0x{x}\nlr: 0x{x}\n", .{ ctx.sp, ctx.x[30] }),- .x86_64 => try writer.print("sp: 0x{x}\n", .{ctx.gprs.get(.rsp)}),- else => {},- }+ if (context) |ctx| {+ try writer.print("pc: 0x{x}\nfp: 0x{x}\n", .{ ctx.getPc(), ctx.getFp() });+ if (stackPointer(ctx)) |sp| try writer.print("sp: 0x{x}\n", .{sp});+ switch (builtin.cpu.arch) {+ .aarch64 => try writer.print("lr: 0x{x}\n", .{ctx.x[30]}),+ else => {},+ }+ }+}++fn writeBacktrace(ctx: *const std.debug.cpu_context.Native) void {+ if (comptime builtin.omit_frame_pointer) {+ return;+ }++ var buffer: [640]u8 = undefined;+ var writer: std.Io.Writer = .fixed(&buffer);+ writer.print("backtrace: 0x{x}", .{ctx.getPc()}) catch return;++ // Each frame must sit above the last, close enough to be a real frame.+ var floor = stackPointer(ctx) orelse ctx.getFp();+ var fp = ctx.getFp();+ for (0..max_backtrace_frames) |_| {+ if (fp < floor or fp - floor > max_frame_distance or fp % @alignOf(usize) != 0) {+ break;+ }+ const frame: *const [2]usize = @ptrFromInt(fp);+ const return_address = frame[1];+ if (return_address == 0) {+ break;}+ writer.print(" 0x{x}", .{return_address}) catch break;+ floor = fp +| 1;+ fp = frame[0];}+ writer.writeByte('\n') catch {};+ writeRecord(writer.buffered());+}++fn stackPointer(ctx: *const std.debug.cpu_context.Native) ?usize {+ return switch (builtin.cpu.arch) {+ .aarch64 => ctx.sp,+ .x86_64 => ctx.gprs.get(.rsp),+ else => null,+ };}fn faultAddress(info: *const std.posix.siginfo_t) ?usize {@@ -286,7 +367,7 @@ const testing = @import("testing.zig");test "crash_handler: fatal signals preserve termination with unavailable stderr" {if (builtin.os.tag != .linux) return error.SkipZigTest;for (fatal_signals) |sig| {- for ([_]SignalTestMode{ .normal, .pipe, .closed, .broken_pipe, .locked_panic, .regular_file, .read_only_pipe }) |mode| {+ for ([_]SignalTestMode{ .normal, .pipe, .tty, .closed, .broken_pipe, .locked_panic, .regular_file, .read_only_pipe }) |mode| {try testSignal(sig, mode);}}@@ -329,20 +410,62 @@ test "crash_handler: unknown signal addresses are not read" {}}-const SignalTestMode = enum { normal, pipe, closed, broken_pipe, locked_panic, hardware, full_pipe, full_socket, regular_file, read_only_pipe };+const SignalTestMode = enum { normal, pipe, tty, closed, broken_pipe, locked_panic, hardware, full_pipe, full_socket, regular_file, read_only_pipe };++extern "c" fn posix_openpt(oflag: c_int) c_int;+extern "c" fn grantpt(fd: c_int) c_int;+extern "c" fn unlockpt(fd: c_int) c_int;+extern "c" fn ptsname_r(fd: c_int, buf: [*]u8, buflen: usize) c_int;++// fds[0] is the master the parent reads, fds[1] the slave the child gets as+// its stderr: the same shape as pipe() and socketpair().+fn openPty(fds: *[2]std.c.fd_t) c_int {+ const oflag: c_int = @bitCast(@as(u32, @bitCast(std.posix.O{ .ACCMODE = .RDWR, .NOCTTY = true })));+ const master = posix_openpt(oflag);+ if (master < 0) return -1;++ if (grantpt(master) != 0 or unlockpt(master) != 0) {+ _ = std.c.close(master);+ return -1;+ }+ var name: [128]u8 = undefined;+ if (ptsname_r(master, &name, name.len) != 0) {+ _ = std.c.close(master);+ return -1;+ }+ const slave = std.c.open(@ptrCast(&name), .{ .ACCMODE = .WRONLY, .NOCTTY = true });+ if (slave < 0) {+ _ = std.c.close(master);+ return -1;+ }+ fds.* = .{ master, slave };+ return 0;+}fn testSignal(sig: std.posix.SIG, mode: SignalTestMode) !void {const guard = if (mode == .hardware) try std.posix.mmap(null, std.heap.pageSize(), .{}, .{ .TYPE = .PRIVATE, .ANONYMOUS = true }, -1, 0) else null;defer if (guard) |memory| std.posix.munmap(memory);const file = if (mode == .regular_file) std.c.memfd_create("fatal-signal-test", std.c.MFD.CLOEXEC) else -1;- if (mode == .regular_file) try testing.expectEqual(true, file >= 0);+ if (mode == .regular_file) {+ try testing.expectEqual(true, file >= 0);+ // O_APPEND or not is the whole question: a reopened description starts+ // at offset zero and would land on top of this.+ try testing.expectEqual(@as(isize, prior_log.len), std.c.write(file, prior_log, prior_log.len));+ }defer if (file >= 0) {_ = std.c.close(file);};var fds: [2]std.c.fd_t = undefined;const full = mode == .full_pipe or mode == .full_socket;const is_pipe = mode == .pipe or mode == .full_pipe or mode == .read_only_pipe;- const result = if (is_pipe) std.c.pipe(&fds) else std.c.socketpair(std.posix.AF.UNIX, std.posix.SOCK.STREAM, 0, &fds);+ const result = if (mode == .tty)+ openPty(&fds)+ else if (is_pipe)+ std.c.pipe(&fds)+ else+ std.c.socketpair(std.posix.AF.UNIX, std.posix.SOCK.STREAM, 0, &fds);+ // A sandbox without /dev/ptmx leaves nothing to test here.+ if (mode == .tty and result != 0) return;try testing.expectEqual(@as(c_int, 0), result);defer _ = std.c.close(fds[0]);const pid = std.c.fork();@@ -391,14 +514,15 @@ fn testSignal(sig: std.posix.SIG, mode: SignalTestMode) !void {if (mode == .locked_panic) panic_mutex.lockUncancelable(lp.io);const flags_before = std.c.fcntl(2, std.posix.F.GETFL);attachSignalHandlers();- const first_pipe = signal_pipe_fd;+ const first_output = signal_output_fd;attachSignalHandlers();- if (signal_pipe_fd != first_pipe) std.c._exit(1);+ if (signal_output_fd != first_output) std.c._exit(1);if (std.c.fcntl(2, std.posix.F.GETFL) != flags_before) std.c._exit(1);- if (signal_pipe_fd >= 0) {- const pipe_flags: std.posix.O = @bitCast(@as(u32, @intCast(std.c.fcntl(signal_pipe_fd, std.posix.F.GETFL))));- if (!pipe_flags.NONBLOCK) std.c._exit(1);- if (std.c.fcntl(signal_pipe_fd, std.posix.F.GETFD) & std.posix.FD_CLOEXEC == 0) std.c._exit(1);+ if (signal_output_fd >= 0) {+ const output_flags: std.posix.O = @bitCast(@as(u32, @intCast(std.c.fcntl(signal_output_fd, std.posix.F.GETFL))));+ if (!output_flags.NONBLOCK) std.c._exit(1);+ if (output_flags.APPEND != (mode == .regular_file)) std.c._exit(1);+ if (std.c.fcntl(signal_output_fd, std.posix.F.GETFD) & std.posix.FD_CLOEXEC == 0) std.c._exit(1);}if (guard) |memory| @as(*volatile u8, @ptrCast(memory.ptr)).* = 1;_ = std.c.raise(sig);@@ -419,20 +543,42 @@ fn testSignal(sig: std.posix.SIG, mode: SignalTestMode) !void {try testing.expectEqual(true, std.posix.W.IFSIGNALED(raw));errdefer std.debug.print("signal={t} mode={t} status=0x{x}\n", .{ sig, mode, raw });try testing.expectEqual(sig, std.posix.W.TERMSIG(raw));- if (file >= 0) try testing.expectEqual(@as(std.c.off_t, 0), std.c.lseek(file, 0, std.c.SEEK.END));- if (mode == .read_only_pipe or mode == .closed or mode == .broken_pipe or mode == .regular_file) try testing.expectEqual(@as(usize, 0), len);- if (mode == .normal or mode == .locked_panic or mode == .hardware or mode == .pipe) {- const text = output[0..len];++ var text = output[0..len];+ if (mode == .regular_file) {+ // The record went to the file, not to the socketpair.+ try testing.expectEqual(@as(usize, 0), len);+ try testing.expectEqual(@as(std.c.off_t, 0), std.c.lseek(file, 0, std.c.SEEK.SET));+ const count = std.c.read(file, &output, output.len);+ try testing.expectEqual(true, count > 0);+ text = output[0..@intCast(count)];+ try testing.expectEqual(true, std.mem.startsWith(u8, text, prior_log));+ }+ var unwrapped: [output.len]u8 = undefined;+ if (mode == .tty) {+ // ONLCR turns every \n into \r\n on the way through the line discipline.+ const replaced = std.mem.replace(u8, text, "\r\n", "\n", &unwrapped);+ text = unwrapped[0 .. text.len - replaced];+ }+ if (mode == .read_only_pipe or mode == .closed or mode == .broken_pipe) try testing.expectEqual(@as(usize, 0), text.len);+ if (mode == .normal or mode == .locked_panic or mode == .hardware or mode == .pipe or mode == .tty or mode == .regular_file) {errdefer std.debug.print("signal={t} mode={t}\n{s}\n", .{ sig, mode, text });try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, "Lightpanda fatal signal:"));try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, "\npc: 0x"));try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, "\ncrash_handler.handleFatalSignal: 0x"));+ try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, "\nbacktrace: 0x"));if (mode == .hardware) {var address_buffer: [64]u8 = undefined;const address = try std.fmt.bufPrint(&address_buffer, "address: 0x{x}\n", .{@intFromPtr(guard.?.ptr)});try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, address));+ // The faulting pc alone is not a backtrace: the walk has to have+ // followed at least one link out of the frame that faulted.+ const line = text[std.mem.indexOf(u8, text, "\nbacktrace: ").? + 1 ..];+ try testing.expectEqual(true, std.mem.count(u8, line[0..std.mem.indexOfScalar(u8, line, '\n').?], " 0x") >= 2);} else {try testing.expectEqual(true, std.mem.containsAtLeast(u8, text, 1, "address: unavailable\n"));}}}++const prior_log = "a line that was already in the log\n";