Skip to content

Lightpanda: the headless browser designed for AI and automation

fix: single source of truth for hashchange fragment decision

Pierre Tachoire846d6fd81668
diff --git a/src/browser/tests/event/hashchange.html b/src/browser/tests/event/hashchange.html
index 595851bf9..acf66ccb6 100644
--- a/src/browser/tests/event/hashchange.html
+++ b/src/browser/tests/event/hashchange.html
@@ -81,3 +81,36 @@
});
}
</script>
+
+<script id=hashChangeFiresOnHistoryTraversal type=module>
+{
+ // Traversing history (history.back) between entries that share a document
+ // but differ only by fragment must also fire hashchange. The decision is
+ // owned by Navigation.navigateInner (single resolved-URL source of truth),
+ // not re-derived in History.goInner.
+ const state = await testing.async();
+
+ const events = [];
+ window.onhashchange = (e) => {
+ events.push([e.oldURL, e.newURL]);
+ if (events.length === 2) state.resolve();
+ };
+
+ // Relative to the document's current URL (a prior block leaves a fragment
+ // here): pushState creates a fragment-only entry without firing hashchange,
+ // then back/forward traverse between the two entries.
+ const before = location.href;
+ history.pushState(null, '', '#section'); // entry .../#section; no hashchange
+ const after = location.href;
+ history.back(); // traverse: after -> before
+ history.forward(); // traverse: before -> after
+
+ await state.done(() => {
+ testing.expectEqual([
+ [after, before],
+ [before, after],
+ ], events);
+ window.onhashchange = null;
+ });
+}
+</script>
diff --git a/src/browser/webapi/History.zig b/src/browser/webapi/History.zig
index 0136ee948..b09df743e 100644
--- a/src/browser/webapi/History.zig
+++ b/src/browser/webapi/History.zig
@@ -19,7 +19,6 @@
const std = @import("std");
const js = @import("../js/js.zig");
-const URL = @import("../URL.zig");
const Frame = @import("../Frame.zig");
const PopStateEvent = @import("event/PopStateEvent.zig");
@@ -99,13 +98,7 @@ fn goInner(delta: i32, frame: *Frame) !void {
const event = (try PopStateEvent.initTrusted(comptime .wrap("popstate"), .{ .state = entry._state.value }, frame)).asEvent();
try frame._event_manager.dispatchDirect(target, event, frame.window._on_popstate, .{ .context = "Pop State" });
}
-
- // Queue hashchange when traversing between entries that share a
- // document but differ only by fragment.
- const is_fragment_change = !std.mem.eql(u8, frame.url, url) and URL.eqlDocument(frame.url, url);
- if (is_fragment_change) {
- try frame.queueHashChange(frame.url, url);
- }
+ // hashchange is queued by navigateInner.
}
}
diff --git a/src/browser/webapi/navigation/Navigation.zig b/src/browser/webapi/navigation/Navigation.zig
index 41ce62f0b..532abd00c 100644
--- a/src/browser/webapi/navigation/Navigation.zig
+++ b/src/browser/webapi/navigation/Navigation.zig
@@ -298,6 +298,10 @@ pub fn navigateInner(
new_url = try arena.dupeZ(u8, new_url);
}
+ // Captured before the switch overwrites frame.url in the same_document
+ // branches; used to queue the hashchange once below.
+ const old_url = frame.url;
+
const previous = self.getCurrentEntry();
switch (kind) {
@@ -345,6 +349,10 @@ pub fn navigateInner(
},
}
+ if (is_same_document and !std.mem.eql(u8, old_url, new_url)) {
+ try frame.queueHashChange(old_url, new_url);
+ }
+
if (self._on_currententrychange) |cec| {
// If we haven't navigated off, let us fire off an a currententrychange.
const event = (try NavigationCurrentEntryChangeEvent.initTrusted(