Skip to content

Lightpanda: the headless browser designed for AI and automation

input: keep HTMLElement.click's form-control guard so a disabled fieldset still fires

Adrià Arrufat85914a9dc4dd
diff --git a/src/browser/tests/element/html/button.html b/src/browser/tests/element/html/button.html
index ff6f67022..ac9953423 100644
--- a/src/browser/tests/element/html/button.html
+++ b/src/browser/tests/element/html/button.html
@@ -277,5 +277,11 @@
b_fs.addEventListener('click', () => clicks++);
b_fs.click();
testing.expectEqual(0, clicks);
+
+ // A disabled fieldset is not itself a disabled form control.
+ const fs = $('#fs_disabled');
+ fs.addEventListener('click', () => clicks++);
+ fs.click();
+ testing.expectEqual(1, clicks);
}
</script>
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index 789c8c096..1cff27706 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -401,8 +401,9 @@ pub fn insertAdjacentHTML(
}
pub fn click(self: *HtmlElement, frame: *Frame) !void {
- if (self.asElement().isDisabled()) {
- return;
+ switch (self._type) {
+ .button, .input, .textarea, .select, .option, .optgroup => if (self.asElement().isDisabled()) return,
+ else => {},
}
const flags = &self.asElement()._flags;