Skip to content

Lightpanda: the headless browser designed for AI and automation

enable --log-filter in release

Karl Seguin861ffb164bf2
diff --git a/src/browser/Frame.zig b/src/browser/Frame.zig
index f950ffc19..06744452b 100644
--- a/src/browser/Frame.zig
+++ b/src/browser/Frame.zig
@@ -1856,6 +1856,7 @@ pub fn iframeAddedCallback(self: *Frame, iframe: *IFrame) !void {
return;
}
if (self._session.load_resources.iframe == false) {
+ log.warnDisabledIFrame();
iframe._executed = true;
return;
}
diff --git a/src/browser/webapi/SharedWorkerGlobalScope.zig b/src/browser/webapi/SharedWorkerGlobalScope.zig
index af06aea6c..7bf26cdc6 100644
--- a/src/browser/webapi/SharedWorkerGlobalScope.zig
+++ b/src/browser/webapi/SharedWorkerGlobalScope.zig
@@ -93,7 +93,7 @@ pub fn init(frame: *Frame, url: [:0]const u8, name: []const u8, worker_type: Wor
errdefer proto.deinit();
if (session.load_resources.worker == false) {
- log.debug(.browser, "shared worker disabled", .{ .url = owned_url });
+ log.warnDisabledWorker();
return self;
}
diff --git a/src/browser/webapi/Worker.zig b/src/browser/webapi/Worker.zig
index 7ca95befa..d6013a4b4 100644
--- a/src/browser/webapi/Worker.zig
+++ b/src/browser/webapi/Worker.zig
@@ -92,7 +92,7 @@ pub fn init(url: []const u8, options: ?WorkerOptions, frame: *Frame) !*Worker {
try frame.trackWorker(self);
if (session.load_resources.worker == false) {
- log.debug(.browser, "worker disabled", .{ .url = resolved_url });
+ log.warnDisabledWorker();
return self;
}
diff --git a/src/log.zig b/src/log.zig
index f8413a646..aad606aed 100644
--- a/src/log.zig
+++ b/src/log.zig
@@ -26,6 +26,7 @@ pub const Scope = enum {
cache,
cdp,
console,
+ disabled,
dom,
event,
frame,
@@ -70,7 +71,6 @@ const Opts = struct {
format: Format = if (lp.IS_DEBUG) .pretty else .logfmt,
level: Level = if (lp.IS_DEBUG) .info else .warn,
// Per-scope enabled flags; a `false` entry suppresses that scope's logs.
- // Only consulted in Debug builds. Default: everything enabled.
scope_enabled: [num_scopes]bool = [_]bool{true} ** num_scopes,
};
@@ -86,10 +86,8 @@ pub fn enabled(scope: Scope, level: Level) bool {
return false;
}
- if (comptime lp.IS_DEBUG) {
- if (opts.scope_enabled[@intFromEnum(scope)] == false) {
- return false;
- }
+ if (opts.scope_enabled[@intFromEnum(scope)] == false) {
+ return false;
}
return true;
@@ -164,6 +162,20 @@ pub fn note(scope: Scope, msg: []const u8, data: anytype) void {
}
}
+var warned_disabled_worker = std.atomic.Value(bool).init(false);
+pub fn warnDisabledWorker() void {
+ if (warned_disabled_worker.swap(true, .monotonic) == false) {
+ warn(.disabled, "workers disabled", .{ .hint = "enable via --load-resources worker" });
+ }
+}
+
+var warned_disabled_iframe = std.atomic.Value(bool).init(false);
+pub fn warnDisabledIFrame() void {
+ if (warned_disabled_iframe.swap(true, .monotonic) == false) {
+ warn(.disabled, "iframes disabled", .{ .hint = "enable via --load-resources iframe" });
+ }
+}
+
pub fn log(scope: Scope, level: Level, msg: []const u8, data: anytype) void {
if (enabled(scope, level) == false) {
return;