Lightpanda: the headless browser designed for AI and automation
Optimize visibility check
Karl Seguin8c5b68476083
diff --git a/src/browser/interactive.zig b/src/browser/interactive.zigindex 1fbb0c8ab..9b008cb88 100644--- a/src/browser/interactive.zig+++ b/src/browser/interactive.zig@@ -179,26 +179,37 @@ fn walkInteractive(const listener_targets = try buildListenerTargetMap(frame, arena);var css_cache: Element.PointerEventsCache = .empty;- var visibility_cache: Element.VisibilityCache = .empty;var results: std.ArrayList(InteractiveElement) = .empty;+ if (root.is(Element)) |root_el| {+ // root is outside of the tree walk, so check its visibility upfront.+ if (!root_el.checkVisibilityCached(null, frame, .scan)) {+ return &.{};+ }+ }+var tw = TreeWalker.Full.init(root, .{});while (tw.next()) |node| {const el = node.is(Element) orelse continue;- const html_el = el.is(Element.Html) orelse continue;- // Skip non-visual elements that are never user-interactive.switch (el.getTag()) {- .script, .style, .link, .meta, .head, .noscript, .template => continue,+ .script, .style, .link, .meta, .head, .noscript, .template => {+ // Skip non-visual elements (and their children) that are never+ // user-interactive.+ tw.skipChildren();+ continue;+ },else => {},}- if (!el.checkVisibilityCached(&visibility_cache, frame)) {+ if (frame._style_manager.hasDisplayNone(el, .scan)) {tw.skipChildren();continue;}+ const html_el = el.is(Element.Html) orelse continue;+const itype = classifyInteractivity(frame, el, html_el, listener_targets, &css_cache) orelse continue;const role = getRole(el);@@ -676,6 +687,7 @@ test "browser.interactive: hidden elements are skipped" {\\<button hidden>Attribute</button>\\<div style="display:none"><a href="/x">Ancestor</a><input type="text"></div>\\<div hidden><button>Ancestor attribute</button></div>+ \\<svg style="display:none"><foreignObject><button>Foreign</button></foreignObject></svg>\\<button>Visible</button>);defer testing.test_session.closeAllPages();