Lightpanda: the headless browser designed for AI and automation
crash: protect every script reject from running microtasks mid-evaluation
Karl Seguin8dcaa2986673
diff --git a/src/browser/js/Context.zig b/src/browser/js/Context.zigindex 82260aaa9..8e8e93ae0 100644--- a/src/browser/js/Context.zig+++ b/src/browser/js/Context.zig@@ -602,6 +602,12 @@ pub fn dynamicModuleCallback(_ = import_attrs;const self = fromC(c_context.?).?;++ // prevent running a microtask checkpoint mid-script: import() is called+ // from running JS, and every reject below would otherwise drain the queue+ self.call_depth += 1;+ defer self.call_depth -= 1;+const local = js.Local{.ctx = self,.handle = c_context.?,@@ -638,10 +644,6 @@ pub fn dynamicModuleCallback(},};- // prevent running a microtask checkpoint mid-script- self.call_depth += 1;- defer self.call_depth -= 1;-const promise = self._dynamicModuleCallback(normalized_specifier, resource, &local) catch |err| blk: {log.debug(.js, "dynamic module callback", .{.err = err,diff --git a/src/browser/tests/page/module.html b/src/browser/tests/page/module.htmlindex 35ed677cc..e299a1f6f 100644--- a/src/browser/tests/page/module.html+++ b/src/browser/tests/page/module.html@@ -111,3 +111,8 @@ let a top-level-await module finish before its still-evaluating parent -->import "./modules/tla.js?reject";import "./modules/checkpoint-reject.js";</script>++<script type=module>+ import "./modules/tla.js?bad-specifier";+ import "./modules/checkpoint-bad-specifier.js";+</script>diff --git a/src/browser/tests/page/modules/checkpoint-bad-specifier.js b/src/browser/tests/page/modules/checkpoint-bad-specifier.jsnew file mode 100644index 000000000..43b9d94e1--- /dev/null+++ b/src/browser/tests/page/modules/checkpoint-bad-specifier.js@@ -0,0 +1,2 @@+// fails to resolve: rejected synchronously by the host callback+import('daaab2025').catch(() => {});