Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: return a more realistic / correct navigator.appVersion

Karl Seguin9acac373b7e4
diff --git a/src/browser/tests/navigator/navigator.html b/src/browser/tests/navigator/navigator.html
index e23af85b3..4e0bdd20d 100644
--- a/src/browser/tests/navigator/navigator.html
+++ b/src/browser/tests/navigator/navigator.html
@@ -7,7 +7,7 @@
testing.expectEqual(true, navigator.userAgent.length > 0);
testing.expectEqual(true, navigator.userAgent.includes('Lightpanda'));
testing.expectEqual('Netscape', navigator.appName);
- testing.expectEqual('1.0', navigator.appVersion);
+ testing.expectEqual(true, navigator.appVersion.startsWith('5.0 ('));
testing.expectEqual(true, navigator.platform.length > 0);
// Platform should be one of the known values
diff --git a/src/browser/webapi/Navigator.zig b/src/browser/webapi/Navigator.zig
index a80ceac8e..109a11223 100644
--- a/src/browser/webapi/Navigator.zig
+++ b/src/browser/webapi/Navigator.zig
@@ -79,7 +79,11 @@ pub fn getAppCodeName(_: *const Navigator) []const u8 {
}
pub fn getAppVersion(_: *const Navigator) []const u8 {
- return "1.0";
+ return switch (builtin.target.os.tag) {
+ .macos => "5.0 (Macintosh)",
+ .windows => "5.0 (Windows)",
+ else => "5.0 (X11)",
+ };
}
pub fn getLanguage(self: *const Navigator, exec: *const Execution) []const u8 {