Skip to content

Lightpanda: the headless browser designed for AI and automation

`Image`: cover `src` changes on `attributeRemove`

Halil Durak9b9ecedc7d3f
diff --git a/src/browser/webapi/element/html/Image.zig b/src/browser/webapi/element/html/Image.zig
index 941770314..83e096009 100644
--- a/src/browser/webapi/element/html/Image.zig
+++ b/src/browser/webapi/element/html/Image.zig
@@ -179,14 +179,21 @@ pub const Build = struct {
return self.imageAddedCallback(frame);
}
- // `img.src = ...` routes through `setSrc`, but `setAttribute("src", ...)`
- // only reaches us here, and both have to (re)do fetch.
pub fn attributeChange(element: *Element, name: String, _: String, frame: *Frame) !void {
if (!name.eql(comptime .wrap("src"))) {
return;
}
return element.as(Image).imageAddedCallback(frame);
}
+
+ // Removing the src leaves no request to make, but any in-flight one still
+ // has to be invalidated.
+ pub fn attributeRemove(element: *Element, name: String, frame: *Frame) !void {
+ if (!name.eql(comptime .wrap("src"))) {
+ return;
+ }
+ return element.as(Image).imageAddedCallback(frame);
+ }
};
const testing = @import("../../../../testing.zig");