Skip to content

Lightpanda: the headless browser designed for AI and automation

frameless documents now set load flag on calling frame

Karl Seguina06e4688b146
diff --git a/src/browser/EventManager.zig b/src/browser/EventManager.zig
index 805811b8e..c09492aca 100644
--- a/src/browser/EventManager.zig
+++ b/src/browser/EventManager.zig
@@ -68,7 +68,9 @@ pub fn register(self: *EventManager, target: *EventTarget, typ: []const u8, call
if (target._type == .node and listener.typ.eql(comptime .wrap("load"))) {
// optimization so that we avoid firing load for things (e.g. images)
// if there's no load listener regsitered (which is pretty common).
- const owner = target.subtype(Node).ownerFrame(self.frame) orelse return;
+ // A frameless document's node (createHTMLDocument, DOMParser) can be
+ // adopted into the caller's document later and load there.
+ const owner = target.subtype(Node).ownerFrame(self.frame) orelse self.frame;
owner._event_manager.has_dom_load_listener = true;
}
}
diff --git a/src/browser/tests/element/html/image_frameless_load.html b/src/browser/tests/element/html/image_frameless_load.html
new file mode 100644
index 000000000..76c7ab11b
--- /dev/null
+++ b/src/browser/tests/element/html/image_frameless_load.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<script src="../../testing.js"></script>
+<body></body>
+
+<!--
+ Must be the only `load` listener on a node in this page: the frame skips
+ image load events when none was registered on it.
+-->
+<script id="frameless-doc-img-adopted-fires-load">
+ // jQuery.parseHTML builds nodes in a createHTMLDocument document.
+ const doc = document.implementation.createHTMLDocument('');
+ const img = doc.createElement('img');
+ img.src = 'a.png';
+ let fired = false;
+ img.addEventListener('load', () => fired = true);
+ document.body.appendChild(img);
+ testing.onload(() => testing.expectEqual(true, fired));
+</script>
diff --git a/src/browser/webapi/element/html/Image.zig b/src/browser/webapi/element/html/Image.zig
index a568bc65e..c51b7a053 100644
--- a/src/browser/webapi/element/html/Image.zig
+++ b/src/browser/webapi/element/html/Image.zig
@@ -446,6 +446,10 @@ test "WebApi: HTML.Image srcset" {
try testing.htmlRunner("element/html/image_srcset.html", .{});
}
+test "WebApi: HTML.Image frameless load listener" {
+ try testing.htmlRunner("element/html/image_frameless_load.html", .{});
+}
+
test "WebApi: HTML.Image fetch" {
try testing.htmlRunner("element/html/image_fetch.html", .{ .load_resources = .{ .image = true } });
}