Lightpanda: the headless browser designed for AI and automation
overflow: Make RC a u32
Karl Seguina100c49cee43
diff --git a/src/browser/tests/net/url_search_params.html b/src/browser/tests/net/url_search_params.htmlindex 48442d221..10354dc6d 100644--- a/src/browser/tests/net/url_search_params.html+++ b/src/browser/tests/net/url_search_params.html@@ -19,6 +19,17 @@}</script>+<script id=rcStress>+ // regression for when RC was generic, held a u8 and would overflow+ const stress = new URLSearchParams('a=1&b=2');+ const iters = [];+ for (let i = 0; i < 300; i++) {+ iters.push(stress.keys());+ }+ // as long as this test doesn't cause a crash, we're ok+ testing.expectTrue(true);+</script>+<script id=urlSearchParams>const inputs = [[["over", "9000!!"], ["abc", "123"], ["key1", ""], ["key2", ""]],diff --git a/src/browser/webapi/AbstractRange.zig b/src/browser/webapi/AbstractRange.zigindex 732acc7e6..2898e1ff3 100644--- a/src/browser/webapi/AbstractRange.zig+++ b/src/browser/webapi/AbstractRange.zig@@ -32,7 +32,7 @@ const AbstractRange = @This();pub const _prototype_root = true;-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_type: Type,_arena: Allocator,_end_offset: u32,diff --git a/src/browser/webapi/Blob.zig b/src/browser/webapi/Blob.zigindex 0b03d63b4..becdbade0 100644--- a/src/browser/webapi/Blob.zig+++ b/src/browser/webapi/Blob.zig@@ -35,7 +35,7 @@ const Blob = @This();pub const _prototype_root = true;_type: Type,-_rc: lp.RC(u32),+_rc: lp.RC,_arena: Allocator,diff --git a/src/browser/webapi/CryptoKey.zig b/src/browser/webapi/CryptoKey.zigindex 12e7c119a..2df7f3000 100644--- a/src/browser/webapi/CryptoKey.zig+++ b/src/browser/webapi/CryptoKey.zig@@ -30,7 +30,7 @@ const Allocator = std.mem.Allocator;/// generateKey(), deriveKey(), importKey(), or unwrapKey().const CryptoKey = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator = undefined,/// Algorithm being used._type: Type,diff --git a/src/browser/webapi/DOMMatrixReadOnly.zig b/src/browser/webapi/DOMMatrixReadOnly.zigindex 6f3e68471..d0340f942 100644--- a/src/browser/webapi/DOMMatrixReadOnly.zig+++ b/src/browser/webapi/DOMMatrixReadOnly.zig@@ -30,7 +30,7 @@ const DOMMatrixReadOnly = @This();pub const _prototype_root = true;_type: Type,-_rc: lp.RC(u8),+_rc: lp.RC,_arena: Allocator,// Stored column-major, matching the spec's mAB naming where A is the columndiff --git a/src/browser/webapi/DOMNodeIterator.zig b/src/browser/webapi/DOMNodeIterator.zigindex f7ef1ec34..b2336bb31 100644--- a/src/browser/webapi/DOMNodeIterator.zig+++ b/src/browser/webapi/DOMNodeIterator.zig@@ -29,7 +29,7 @@ pub const FilterOpts = NodeFilter.FilterOpts;const DOMNodeIterator = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_root: *Node,_what_to_show: u32,_filter: NodeFilter,diff --git a/src/browser/webapi/DOMPointReadOnly.zig b/src/browser/webapi/DOMPointReadOnly.zigindex dccb9770a..db91e5a3f 100644--- a/src/browser/webapi/DOMPointReadOnly.zig+++ b/src/browser/webapi/DOMPointReadOnly.zig@@ -31,7 +31,7 @@ const DOMPointReadOnly = @This();pub const _prototype_root = true;_type: Type,-_rc: lp.RC(u8),+_rc: lp.RC,_arena: Allocator,_x: f64,diff --git a/src/browser/webapi/DOMTreeWalker.zig b/src/browser/webapi/DOMTreeWalker.zigindex 0e07dab95..e0d0c3970 100644--- a/src/browser/webapi/DOMTreeWalker.zig+++ b/src/browser/webapi/DOMTreeWalker.zig@@ -28,7 +28,7 @@ pub const FilterOpts = NodeFilter.FilterOpts;const DOMTreeWalker = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_root: *Node,_what_to_show: u32,_filter: NodeFilter,diff --git a/src/browser/webapi/DataTransfer.zig b/src/browser/webapi/DataTransfer.zigindex b8505d42c..8ba50fd51 100644--- a/src/browser/webapi/DataTransfer.zig+++ b/src/browser/webapi/DataTransfer.zig@@ -50,7 +50,7 @@ pub fn registerTypes() []const type {_arena: Allocator,// Refcounted so the GC weak-finalizer (or page teardown) releases the pooled// arena exactly once; mirrors Blob's lifecycle.-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},_items: std.ArrayList(*DataTransferItem) = .{},_item_list: *DataTransferItemList,// FileList lives on the factory slab and is frame-tracked, so each File ref itdiff --git a/src/browser/webapi/Event.zig b/src/browser/webapi/Event.zigindex 0c0bad24e..1f29a4f56 100644--- a/src/browser/webapi/Event.zig+++ b/src/browser/webapi/Event.zig@@ -65,7 +65,7 @@ _time_origin: u64 = 0,// - 0: no reference, always a transient state going to either 1 or about to be deinit'd// - 1: either zig or v8 have a reference// - 2: both zig and v8 have a reference-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},pub const EventPhase = enum(u8) {none = 0,diff --git a/src/browser/webapi/FileReader.zig b/src/browser/webapi/FileReader.zigindex 68e214b78..543997d44 100644--- a/src/browser/webapi/FileReader.zig+++ b/src/browser/webapi/FileReader.zig@@ -33,7 +33,7 @@ const Allocator = std.mem.Allocator;/// https://developer.mozilla.org/en-US/docs/Web/API/FileReaderconst FileReader = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_exec: *Execution,_proto: *EventTarget,_arena: Allocator,diff --git a/src/browser/webapi/ImageData.zig b/src/browser/webapi/ImageData.zigindex cca2b5212..7e4a1ecae 100644--- a/src/browser/webapi/ImageData.zig+++ b/src/browser/webapi/ImageData.zig@@ -28,7 +28,7 @@ const Execution = js.Execution;/// https://developer.mozilla.org/en-US/docs/Web/API/ImageData/ImageDataconst ImageData = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_width: u32,_height: u32,_data: js.ArrayBufferRef(.uint8_clamped).Global,diff --git a/src/browser/webapi/IntersectionObserver.zig b/src/browser/webapi/IntersectionObserver.zigindex c6899c739..6d8cefb7f 100644--- a/src/browser/webapi/IntersectionObserver.zig+++ b/src/browser/webapi/IntersectionObserver.zig@@ -39,7 +39,7 @@ pub fn registerTypes() []const type {const IntersectionObserver = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_callback: js.Function.Global,_observing: std.ArrayList(*Element) = .{},@@ -316,7 +316,7 @@ pub fn deliverEntries(self: *IntersectionObserver, frame: *Frame) !void {}pub const IntersectionObserverEntry = struct {- _rc: lp.RC(u8) = .{},+ _rc: lp.RC = .{},_arena: Allocator,_time: f64,_target: *Element,diff --git a/src/browser/webapi/Location.zig b/src/browser/webapi/Location.zigindex 06d40666a..3cf1b8fdd 100644--- a/src/browser/webapi/Location.zig+++ b/src/browser/webapi/Location.zig@@ -28,7 +28,7 @@ const Frame = @import("../Frame.zig");const Location = @This();_url: *URL,-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},pub fn init(raw_url: []const u8, frame: *Frame) !*Location {const url = try URL.init(raw_url, null, &frame.js.execution);diff --git a/src/browser/webapi/MutationObserver.zig b/src/browser/webapi/MutationObserver.zigindex d3d9b4d82..6a7de1f3e 100644--- a/src/browser/webapi/MutationObserver.zig+++ b/src/browser/webapi/MutationObserver.zig@@ -39,7 +39,7 @@ pub fn registerTypes() []const type {const MutationObserver = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_callback: js.Function.Global,_observing: std.ArrayList(Observing) = .{},@@ -357,7 +357,7 @@ pub fn deliverRecords(self: *MutationObserver, frame: *Frame) !void {}pub const MutationRecord = struct {- _rc: lp.RC(u8) = .{},+ _rc: lp.RC = .{},_type: Type,_target: *Node,_arena: Allocator,diff --git a/src/browser/webapi/Notification.zig b/src/browser/webapi/Notification.zigindex c9ce32261..83b64a14b 100644--- a/src/browser/webapi/Notification.zig+++ b/src/browser/webapi/Notification.zig@@ -29,7 +29,7 @@ const Allocator = std.mem.Allocator;const Notification = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_proto: *EventTarget,_title: []const u8,diff --git a/src/browser/webapi/Permissions.zig b/src/browser/webapi/Permissions.zigindex 0c3a6a743..c297d139c 100644--- a/src/browser/webapi/Permissions.zig+++ b/src/browser/webapi/Permissions.zig@@ -61,7 +61,7 @@ pub fn query(_: *const Permissions, qd: QueryDescriptor, exec: *const Execution)}const PermissionStatus = struct {- _rc: lp.RC(u8) = .{},+ _rc: lp.RC = .{},_arena: Allocator,_name: []const u8,_state: State,diff --git a/src/browser/webapi/Selection.zig b/src/browser/webapi/Selection.zigindex 77fedfd97..251e22db1 100644--- a/src/browser/webapi/Selection.zig+++ b/src/browser/webapi/Selection.zig@@ -33,7 +33,7 @@ const Selection = @This();pub const SelectionDirection = enum { backward, forward, none };-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_range: ?*Range = null,_direction: SelectionDirection = .none,diff --git a/src/browser/webapi/URL.zig b/src/browser/webapi/URL.zigindex 78ac5b7b2..19c1037d2 100644--- a/src/browser/webapi/URL.zig+++ b/src/browser/webapi/URL.zig@@ -33,7 +33,7 @@ _url: *U.Url = undefined,_port: [5]u8 = undefined,_search_params: ?*URLSearchParams = null,/// We have to track lifetime of URL to free `_url`.-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},// conveniencepub const resolve = @import("../URL.zig").resolve;diff --git a/src/browser/webapi/XPathExpression.zig b/src/browser/webapi/XPathExpression.zigindex 0e0e4f842..17afdb6a6 100644--- a/src/browser/webapi/XPathExpression.zig+++ b/src/browser/webapi/XPathExpression.zig@@ -42,7 +42,7 @@ const Allocator = std.mem.Allocator;const XPathExpression = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_expr: *const xpath.Ast.Expr,diff --git a/src/browser/webapi/XPathResult.zig b/src/browser/webapi/XPathResult.zigindex 99feeb5f6..7a407f677 100644--- a/src/browser/webapi/XPathResult.zig+++ b/src/browser/webapi/XPathResult.zig@@ -75,7 +75,7 @@ const Value = union(enum) {nodes: []const *Node,};-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_type: u16,_value: Value,diff --git a/src/browser/webapi/animation/Animation.zig b/src/browser/webapi/animation/Animation.zigindex 5880df9dd..2139d52b8 100644--- a/src/browser/webapi/animation/Animation.zig+++ b/src/browser/webapi/animation/Animation.zig@@ -34,7 +34,7 @@ const PlayState = enum {finished,};-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},_frame: *Frame,_arena: Allocator,diff --git a/src/browser/webapi/collections/DOMStringList.zig b/src/browser/webapi/collections/DOMStringList.zigindex 24e4ea1e1..f95284f66 100644--- a/src/browser/webapi/collections/DOMStringList.zig+++ b/src/browser/webapi/collections/DOMStringList.zig@@ -43,7 +43,7 @@ pub fn registerTypes() []const type {pub const DOMStringList = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_items: []const []const u8,diff --git a/src/browser/webapi/collections/HTMLCollection.zig b/src/browser/webapi/collections/HTMLCollection.zigindex 53a0ada61..fe60a92aa 100644--- a/src/browser/webapi/collections/HTMLCollection.zig+++ b/src/browser/webapi/collections/HTMLCollection.zig@@ -60,7 +60,7 @@ _data: union(Mode) {form: NodeLive(.form),empty: void,},-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},pub fn deinit(self: *HTMLCollection, page: *Page) void {page.factory.destroy(self);diff --git a/src/browser/webapi/collections/NodeList.zig b/src/browser/webapi/collections/NodeList.zigindex eb9cb6901..8b1ac85e7 100644--- a/src/browser/webapi/collections/NodeList.zig+++ b/src/browser/webapi/collections/NodeList.zig@@ -39,7 +39,7 @@ _data: union(enum) {radio_node_list: *RadioNodeList,name: NodeLive(.name),},-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},pub fn deinit(self: *NodeList, page: *Page) void {switch (self._data) {diff --git a/src/browser/webapi/collections/iterator.zig b/src/browser/webapi/collections/iterator.zigindex a98336184..92be12ee3 100644--- a/src/browser/webapi/collections/iterator.zig+++ b/src/browser/webapi/collections/iterator.zig@@ -27,7 +27,7 @@ pub fn Entry(comptime Inner: type, comptime field: ?[]const u8) type {return struct {_inner: Inner,- _rc: lp.RC(u8) = .{},+ _rc: lp.RC = .{},const Self = @This();diff --git a/src/browser/webapi/css/FontFace.zig b/src/browser/webapi/css/FontFace.zigindex 9b6cd6360..e6b5a1166 100644--- a/src/browser/webapi/css/FontFace.zig+++ b/src/browser/webapi/css/FontFace.zig@@ -27,7 +27,7 @@ const Allocator = std.mem.Allocator;const FontFace = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_family: []const u8,diff --git a/src/browser/webapi/css/FontFaceSet.zig b/src/browser/webapi/css/FontFaceSet.zigindex f0bd994f6..26da28227 100644--- a/src/browser/webapi/css/FontFaceSet.zig+++ b/src/browser/webapi/css/FontFaceSet.zig@@ -32,7 +32,7 @@ const Allocator = std.mem.Allocator;const FontFaceSet = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_proto: *EventTarget,_arena: Allocator,diff --git a/src/browser/webapi/encoding/TextDecoder.zig b/src/browser/webapi/encoding/TextDecoder.zigindex e32ac3a59..d73cccbf4 100644--- a/src/browser/webapi/encoding/TextDecoder.zig+++ b/src/browser/webapi/encoding/TextDecoder.zig@@ -28,7 +28,7 @@ const Allocator = std.mem.Allocator;const TextDecoder = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_fatal: bool,_arena: Allocator,_ignore_bom: bool,diff --git a/src/browser/webapi/net/EventSource.zig b/src/browser/webapi/net/EventSource.zigindex 9f3a42b75..8b167b6f0 100644--- a/src/browser/webapi/net/EventSource.zig+++ b/src/browser/webapi/net/EventSource.zig@@ -39,7 +39,7 @@ const IS_DEBUG = @import("builtin").mode == .Debug;// https://html.spec.whatwg.org/multipage/server-sent-events.htmlconst EventSource = @This();-_rc: lp.RC(u16) = .{},+_rc: lp.RC = .{},_exec: *const Execution,_proto: *EventTarget,_arena: Allocator,diff --git a/src/browser/webapi/net/FormData.zig b/src/browser/webapi/net/FormData.zigindex 3cf0174c9..d4ffce43c 100644--- a/src/browser/webapi/net/FormData.zig+++ b/src/browser/webapi/net/FormData.zig@@ -34,7 +34,7 @@ const Allocator = std.mem.Allocator;const FormData = @This();-_rc: lp.RC(u8),+_rc: lp.RC,_arena: Allocator,_entries: std.ArrayList(Entry),diff --git a/src/browser/webapi/net/Request.zig b/src/browser/webapi/net/Request.zigindex f8c5ac6f9..b9b28c31e 100644--- a/src/browser/webapi/net/Request.zig+++ b/src/browser/webapi/net/Request.zig@@ -36,7 +36,7 @@ const Allocator = std.mem.Allocator;const Request = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_url: [:0]const u8,_method: http.Method,_headers: ?*Headers,diff --git a/src/browser/webapi/net/Response.zig b/src/browser/webapi/net/Response.zigindex fc34f6f19..06efeac55 100644--- a/src/browser/webapi/net/Response.zig+++ b/src/browser/webapi/net/Response.zig@@ -44,7 +44,7 @@ pub const Type = enum {opaqueredirect,};-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_status: u16,_arena: Allocator,_headers: *Headers,diff --git a/src/browser/webapi/net/URLSearchParams.zig b/src/browser/webapi/net/URLSearchParams.zigindex dbb1e09ee..66f967af5 100644--- a/src/browser/webapi/net/URLSearchParams.zig+++ b/src/browser/webapi/net/URLSearchParams.zig@@ -41,7 +41,7 @@ pub fn registerTypes() []const type {const URLSearchParams = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_arena: Allocator,_params: KeyValueList,diff --git a/src/browser/webapi/net/WebSocket.zig b/src/browser/webapi/net/WebSocket.zigindex 3a1eca146..135e4cdb9 100644--- a/src/browser/webapi/net/WebSocket.zig+++ b/src/browser/webapi/net/WebSocket.zig@@ -40,7 +40,7 @@ const IS_DEBUG = @import("builtin").mode == .Debug;const WebSocket = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_exec: *const Execution,_proto: *EventTarget,_arena: Allocator,diff --git a/src/browser/webapi/net/XMLHttpRequest.zig b/src/browser/webapi/net/XMLHttpRequest.zigindex 71c3a842d..975f3fdf4 100644--- a/src/browser/webapi/net/XMLHttpRequest.zig+++ b/src/browser/webapi/net/XMLHttpRequest.zig@@ -42,7 +42,7 @@ const Allocator = std.mem.Allocator;const IS_DEBUG = @import("builtin").mode == .Debug;const XMLHttpRequest = @This();-_rc: lp.RC(u8) = .{},+_rc: lp.RC = .{},_exec: *const Execution,_proto: *XMLHttpRequestEventTarget,_upload: ?*XMLHttpRequestUpload = null,diff --git a/src/browser/webapi/storage/idb/IDBTransaction.zig b/src/browser/webapi/storage/idb/IDBTransaction.zigindex 6b57ac96b..d58e617ea 100644--- a/src/browser/webapi/storage/idb/IDBTransaction.zig+++ b/src/browser/webapi/storage/idb/IDBTransaction.zig@@ -59,7 +59,7 @@ _durability: Durability = .default,// owned object, one while a drain task is scheduled, one while parked on the// engine's connection gate (gate ownership needs no ref of its own: it's only// ever held while a drain task exists).-_rc: lp.RC(u32) = .{},+_rc: lp.RC = .{},_arena: Allocator,// v8 handles owned by the transaction, swept (reset) in deinit. Slots arediff --git a/src/lightpanda.zig b/src/lightpanda.zigindex df0bd4e93..e17397e3a 100644--- a/src/lightpanda.zig+++ b/src/lightpanda.zig@@ -329,42 +329,42 @@ noinline fn assertionFailure(comptime ctx: []const u8, args: anytype) noreturn {const rc_canary: u32 = 0x52434E54;const rc_poison: u32 = 0xDEADC0DE;-// Reference counting helper-pub fn RC(comptime T: type) type {- return struct {- _refs: std.atomic.Value(T) = .init(0),- _canary: u32 = rc_canary,-- pub fn init(refs: T) @This() {- return .{ ._refs = .init(refs) };- }+// Reference counting helper. The count is a u32: a u8 silently wrapped at 256+// concurrent refs (e.g. hundreds of live iterators on one URLSearchParams),+// causing a premature deinit and a poisoned "release overflow" crash.+pub const RC = struct {+ _refs: std.atomic.Value(u32) = .init(0),+ _canary: u32 = rc_canary,++ pub fn init(refs: u32) RC {+ return .{ ._refs = .init(refs) };+ }- pub fn acquire(self: *@This()) void {- _ = self._refs.fetchAdd(1, .monotonic);- }+ pub fn acquire(self: *RC) void {+ _ = self._refs.fetchAdd(1, .monotonic);+ }- pub fn release(self: *@This(), value: anytype, page: *Page) void {- const prev = self._refs.fetchSub(1, .acq_rel);- assert(prev > 0, "release overflow", .{- .type = @typeName(@TypeOf(value)),- .canary = self._canary, // rc_canary=live/accounting, rc_poison=double-release, else=reuse- .refs = prev,- .ptr = @intFromPtr(value),- });- if (prev == 1) {- // Mark dead before deinit frees this memory, so a stale- // weak-callback re-fire reads rc_poison instead of a- // misleadingly-intact canary.- self._canary = rc_poison;- value.deinit(page);- }+ pub fn release(self: *RC, value: anytype, page: *Page) void {+ const prev = self._refs.fetchSub(1, .acq_rel);+ assert(prev > 0, "release overflow", .{+ .type = @typeName(@TypeOf(value)),+ .canary = self._canary, // rc_canary=live/accounting, rc_poison=double-release, else=reuse+ .refs = prev,+ .ptr = @intFromPtr(value),+ });+ if (prev == 1) {+ // Mark dead before deinit frees this memory, so a stale+ // weak-callback re-fire reads rc_poison instead of a+ // misleadingly-intact canary.+ self._canary = rc_poison;+ value.deinit(page);}+ }- pub fn format(self: @This(), writer: *std.Io.Writer) !void {- return writer.print("{d}", .{self._refs.load(.monotonic)});- }- };-}+ pub fn format(self: RC, writer: *std.Io.Writer) !void {+ return writer.print("{d}", .{self._refs.load(.monotonic)});+ }+};const testing = @import("testing.zig");test "writeJsonEnvelope: null frame" {