Lightpanda: the headless browser designed for AI and automation
browser: make console capture opt-in (#2686)
Adrià Arrufata1d427e51800
diff --git a/src/agent/Agent.zig b/src/agent/Agent.zigindex 0a26bd5f0..b8f9eb5d1 100644--- a/src/agent/Agent.zig+++ b/src/agent/Agent.zig@@ -314,6 +314,7 @@ pub fn deinit(self: *Agent) void {fn startSession(self: *Agent) !void {self.session = try self.browser.newSession(self.notification);self.session.cancel_hook = .{ .context = @ptrCast(self), .check = checkCancel };+ try self.session.enableConsoleCapture();}// Compile-time constant; projected once per process to avoid rebuilding per call.diff --git a/src/browser/Session.zig b/src/browser/Session.zigindex f346b7dd3..4423d9352 100644--- a/src/browser/Session.zig+++ b/src/browser/Session.zig@@ -90,10 +90,11 @@ subframe_loading_enabled: bool = true,// session init; the LP.configureLoading CDP method can flip it per-session.worker_loading_enabled: bool = true,-// Session-scoped capture of console.* output for the `consoleLogs` MCP tool.-// Fed by an `console_message` notification listener; drained on tool call.-// Capped at `max_console_bytes` so a runaway page can't grow it unbounded.+// Console.* capture for the `consoleLogs` tool, capped at `max_console_bytes`.+// Opt-in via `enableConsoleCapture`: plain CDP `serve` never drains it, so+// leaving the listener off keeps the buffer at zero bytes._console_messages: std.Io.Writer.Allocating,+_console_capture: bool = false,// Opt-in fetch of external <link rel=stylesheet> resources. Defaults to// false to preserve the current rendering-free fast path: drivers that@@ -147,12 +148,19 @@ pub fn init(self: *Session, browser: *Browser, notification: *Notification) !voi.load_external_stylesheets = browser.app.config.enableExternalStylesheets(),};errdefer self._console_messages.deinit();+}- try notification.register(.console_message, self, onConsoleMessage);+/// Register the console listener so `drainConsoleMessages` returns output. Idempotent.+pub fn enableConsoleCapture(self: *Session) !void {+ if (self._console_capture) return;+ try self.notification.register(.console_message, self, onConsoleMessage);+ self._console_capture = true;}pub fn deinit(self: *Session) void {- self.notification.unregister(.console_message, self);+ if (self._console_capture) {+ self.notification.unregister(.console_message, self);+ }if (self._pending != null) {self.discardPendingPage();diff --git a/src/mcp/Server.zig b/src/mcp/Server.zigindex d06943169..4691e4d87 100644--- a/src/mcp/Server.zig+++ b/src/mcp/Server.zig@@ -44,6 +44,7 @@ pub fn init(allocator: std.mem.Allocator, app: *App, writer: *std.io.Writer) !*Serrdefer self.browser.deinit();self.session = try self.browser.newSession(self.notification);+ try self.session.enableConsoleCapture();if (app.config.cookieFile()) |cookie_path| {lp.cookies.loadFromFile(self.session, cookie_path);