Lightpanda: the headless browser designed for AI and automation
webapi: inline style writes are now ce_reactions = true flagged
Karl Seguina55dede2ee95
diff --git a/src/browser/tests/custom_elements/attribute_changed.html b/src/browser/tests/custom_elements/attribute_changed.htmlindex 2ebbf99e2..101ea58df 100644--- a/src/browser/tests/custom_elements/attribute_changed.html+++ b/src/browser/tests/custom_elements/attribute_changed.html@@ -163,3 +163,39 @@testing.expectEqual('initial', callbackCalls[1].newValue);}</script>++<script id="style_declaration">+{+ let calls = [];++ class StyleObserver extends HTMLElement {+ static get observedAttributes() {+ return ['style'];+ }++ attributeChangedCallback(name, oldValue, newValue) {+ calls.push(newValue);+ }+ }++ customElements.define('style-observer', StyleObserver);+ const el = document.createElement('style-observer');++ // each write runs the callback before returning+ el.style.setProperty('color', 'red');+ testing.expectEqual(['color: red;'], calls);++ el.style.cssText = 'width: 1px;';+ testing.expectEqual(2, calls.length);++ el.style.borderWidth = '2px';+ testing.expectEqual(3, calls.length);++ el.style.cssFloat = 'left';+ testing.expectEqual(4, calls.length);++ el.style.removeProperty('width');+ testing.expectEqual(5, calls.length);+ testing.expectEqual(el.getAttribute('style'), calls[4]);+}+</script>diff --git a/src/browser/webapi/css/CSSStyleDeclaration.zig b/src/browser/webapi/css/CSSStyleDeclaration.zigindex ea4b0bce3..586038d5a 100644--- a/src/browser/webapi/css/CSSStyleDeclaration.zig+++ b/src/browser/webapi/css/CSSStyleDeclaration.zig@@ -1061,7 +1061,7 @@ pub const JsApi = struct {pub var class_id: bridge.ClassId = undefined;};- pub const cssText = bridge.accessor(CSSStyleDeclaration.getCssText, CSSStyleDeclaration.setCssText, .{});+ pub const cssText = bridge.accessor(CSSStyleDeclaration.getCssText, CSSStyleDeclaration.setCssText, .{ .ce_reactions = true });pub const length = bridge.accessor(CSSStyleDeclaration.length, null, .{});pub const item = bridge.function(_item, .{});@@ -1074,9 +1074,9 @@ pub const JsApi = struct {pub const getPropertyValue = bridge.function(CSSStyleDeclaration.getPropertyValue, .{});pub const getPropertyPriority = bridge.function(CSSStyleDeclaration.getPropertyPriority, .{});- pub const setProperty = bridge.function(CSSStyleDeclaration.setProperty, .{});- pub const removeProperty = bridge.function(CSSStyleDeclaration.removeProperty, .{});- pub const cssFloat = bridge.accessor(CSSStyleDeclaration.getFloat, CSSStyleDeclaration.setFloat, .{});+ pub const setProperty = bridge.function(CSSStyleDeclaration.setProperty, .{ .ce_reactions = true });+ pub const removeProperty = bridge.function(CSSStyleDeclaration.removeProperty, .{ .ce_reactions = true });+ pub const cssFloat = bridge.accessor(CSSStyleDeclaration.getFloat, CSSStyleDeclaration.setFloat, .{ .ce_reactions = true });};const testing = @import("../../../testing.zig");diff --git a/src/browser/webapi/css/CSSStyleProperties.zig b/src/browser/webapi/css/CSSStyleProperties.zigindex 3ae24327f..e0f2fb4ee 100644--- a/src/browser/webapi/css/CSSStyleProperties.zig+++ b/src/browser/webapi/css/CSSStyleProperties.zig@@ -405,5 +405,5 @@ pub const JsApi = struct {pub var class_id: bridge.ClassId = undefined;};- pub const @"[]" = bridge.namedIndexed(CSSStyleProperties.getNamed, CSSStyleProperties.setNamed, null, null, null, .{});+ pub const @"[]" = bridge.namedIndexed(CSSStyleProperties.getNamed, CSSStyleProperties.setNamed, null, null, null, .{ .ce_reactions = true });};