Skip to content

Lightpanda: the headless browser designed for AI and automation

test: child-frame coverage for the JSON tree and the MCP tree tools

Adrià Arrufata6e7767533f6
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index 5f90c164a..77d6d422d 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -2150,6 +2150,8 @@ fn regexLiteral(text: []const u8) ?RegexLiteral {
return .{ .body = text[1..close], .flags = flags };
}
+const testing = @import("../testing.zig");
+
test "regexLiteral" {
for ([_][]const u8{ "foo", "/", "//", "//i", "/foo", "/foo/ bar", "/usr/bin" }) |text| {
try std.testing.expectEqual(null, regexLiteral(text));
@@ -2588,6 +2590,30 @@ test "call: unknown tool name surfaces in-band" {
try std.testing.expectEqualStrings("Unknown tool: multi_tool_use.parallel", r.text);
}
+test "tree and nodeDetails read the node's own frame" {
+ var registry: NodeRegistry = .init(std.testing.allocator);
+ defer registry.deinit();
+
+ var page = try testing.pageTest("cdp/semantic_tree_iframe.html", .{});
+ defer page.close();
+ const child = page.frame().?.child_frames.items[0];
+
+ const html = (child.document.getDocumentElement() orelse unreachable).asNode();
+ const input = (try child.document.querySelector(.wrap("input"), child)).?.asNode();
+ const html_id = (try registry.register(html)).id;
+ const input_id = (try registry.register(input)).id;
+
+ const aa = testing.arena_allocator;
+ const tree_args = try std.json.parseFromSliceLeaky(std.json.Value, aa, try std.fmt.allocPrint(aa, "{{\"backendNodeId\":{d}}}", .{html_id}), .{});
+ const tree = try call(aa, page.session, &registry, "tree", tree_args, .{});
+ try std.testing.expect(std.mem.indexOf(u8, tree.text, "child-label") != null);
+ try std.testing.expect(std.mem.indexOf(u8, tree.text, "parent-") == null);
+
+ const details_args = try std.json.parseFromSliceLeaky(std.json.Value, aa, try std.fmt.allocPrint(aa, "{{\"backendNodeId\":{d}}}", .{input_id}), .{});
+ const details = try call(aa, page.session, &registry, "nodeDetails", details_args, .{});
+ try std.testing.expect(std.mem.indexOf(u8, details.text, "child-label") != null);
+}
+
test "parseValue: zero-filled optional backendNodeId treated as omitted" {
var arena: std.heap.ArenaAllocator = .init(std.testing.allocator);
defer arena.deinit();
diff --git a/src/server/cdp/domains/lp.zig b/src/server/cdp/domains/lp.zig
index adb3903a3..62898c3f0 100644
--- a/src/server/cdp/domains/lp.zig
+++ b/src/server/cdp/domains/lp.zig
@@ -647,6 +647,13 @@ test "cdp.lp: semantic tree and node details read the node's own frame" {
try testing.expectEqual("child-label", details.get("name").?.string);
try testing.expectEqual("child-option", details.get("options").?.array.items[0].object.get("value").?.string);
+ // JSON format and interactiveOnly walk the same frame as the text format.
+ try ctx.processMessage(.{ .id = 5, .method = "LP.getSemanticTree", .params = .{ .backendNodeId = html_id, .interactiveOnly = true } });
+ const json = try std.json.Stringify.valueAlloc(testing.allocator, (try dumpReply(&ctx, 5)).get("result").?.object.get("semanticTree").?, .{});
+ defer testing.allocator.free(json);
+ try testing.expect(std.mem.indexOf(u8, json, "child-label") != null);
+ try testing.expect(std.mem.indexOf(u8, json, "parent-") == null);
+
// A document with no frame has no styles or layout to describe.
const frameless = try root._factory.genericDocument(.{});
const frameless_id = (try bc.node_registry.register(frameless.asNode())).id;