Lightpanda: the headless browser designed for AI and automation
webapi: createRange() boundary points start in the document it's called on
Francis Bouvieraa12ed5e9903
diff --git a/src/browser/Factory.zig b/src/browser/Factory.zigindex 5065b7141..097fb2c1b 100644--- a/src/browser/Factory.zig+++ b/src/browser/Factory.zig@@ -269,10 +269,17 @@ pub fn blob(_: *const Factory, arena: Allocator, child: anytype) !*@TypeOf(childreturn chain.get(1);}-pub fn abstractRange(_: *const Factory, arena: Allocator, child: anytype, frame: *Frame) !*@TypeOf(child) {+pub fn abstractRange(self: *const Factory, arena: Allocator, child: anytype, frame: *Frame) !*@TypeOf(child) {+ return self.abstractRangeIn(arena, child, frame.document.asNode(), frame);+}++// `container` is the initial start/end container: per spec, createRange()+// initializes both boundary points to (document, 0) of the document it was+// called on, which is not necessarily the frame's main document.+pub fn abstractRangeIn(_: *const Factory, arena: Allocator, child: anytype, container: *Node, frame: *Frame) !*@TypeOf(child) {const chain = try PrototypeChain(&.{ AbstractRange, @TypeOf(child) }).allocate(arena);- const doc = frame.document.asNode();+ const doc = container;const abstract_range = chain.get(0);abstract_range.* = AbstractRange{._rc = .{},diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zigindex 49e233340..656a6eb6d 100644--- a/src/browser/webapi/Document.zig+++ b/src/browser/webapi/Document.zig@@ -505,8 +505,8 @@ pub fn createProcessingInstruction(self: *Document, target: []const u8, data: []}const Range = @import("Range.zig");-pub fn createRange(_: *const Document, frame: *Frame) !*Range {- return Range.init(frame);+pub fn createRange(self: *Document, frame: *Frame) !*Range {+ return Range.initIn(self.asNode(), frame);}pub fn createEvent(_: *const Document, event_type: []const u8, frame: *Frame) !*@import("Event.zig") {diff --git a/src/browser/webapi/Range.zig b/src/browser/webapi/Range.zigindex 35f6eec10..43cc1b126 100644--- a/src/browser/webapi/Range.zig+++ b/src/browser/webapi/Range.zig@@ -34,9 +34,15 @@ const Range = @This();_proto: *AbstractRange,pub fn init(frame: *Frame) !*Range {+ return initIn(frame.document.asNode(), frame);+}++// Both boundary points start at (container, 0); document.createRange()+// passes the document it was called on.+pub fn initIn(container: *Node, frame: *Frame) !*Range {const arena = try frame.getArena(.medium, "Range");errdefer frame.releaseArena(arena);- return frame._factory.abstractRange(arena, Range{ ._proto = undefined }, frame);+ return frame._factory.abstractRangeIn(arena, Range{ ._proto = undefined }, container, frame);}pub fn asAbstractRange(self: *Range) *AbstractRange {