Lightpanda: the headless browser designed for AI and automation
script: wait for the inserting script before draining a nested script's tasks
Scott Tayloraf976c4ed424
diff --git a/src/browser/ScriptManagerBase.zig b/src/browser/ScriptManagerBase.zigindex 9910b6ed7..20763ffc2 100644--- a/src/browser/ScriptManagerBase.zig+++ b/src/browser/ScriptManagerBase.zig@@ -967,12 +967,12 @@ pub const Script = struct {return;}- defer {+ defer if (frame.js.call_depth == 0) {local.runMacrotasks(); // also runs microtasks_ = frame.js.scheduler.run() catch |err| {log.err(.frame, "scheduler", .{ .err = err });};- }+ };if (success) {self.executeCallback(comptime .wrap("load"));diff --git a/src/browser/tests/element/html/script/dynamic_inline.html b/src/browser/tests/element/html/script/dynamic_inline.htmlindex e06b48219..2f70d83ca 100644--- a/src/browser/tests/element/html/script/dynamic_inline.html+++ b/src/browser/tests/element/html/script/dynamic_inline.html@@ -42,6 +42,34 @@testing.expectFalse(window.empty_ran);</script>+<script id=inline_insert_waits_for_inserting_script>+{+ // A script inserted by a running script runs synchronously, but the+ // microtask checkpoint and timers wait until the inserting script returns.+ const order = [];+ window.nested_order = order;+ const parent = document.createElement('div');+ document.head.appendChild(parent);+ new MutationObserver(() => order.push('mutation')).observe(parent, { childList: true });+ Promise.resolve().then(() => order.push('promise'));+ setTimeout(() => order.push('timer'), 0);+ const until = performance.now() + 5;+ while (performance.now() < until) {}++ for (let i = 0; i < 2; i++) {+ const s = document.createElement('script');+ s.textContent = `window.nested_order.push('inline-${i}');`;+ parent.appendChild(s);+ order.push(`after-${i}`);+ }+ testing.expectEqual('inline-0,after-0,inline-1,after-1', order.join(','));++ testing.onload(() => {+ testing.expectEqual('inline-0,after-0,inline-1,after-1,promise,mutation,timer', order.join(','));+ });+}+</script>+<script id=module_inline>window.module_executed = false;const s6 = document.createElement('script');