Skip to content

Lightpanda: the headless browser designed for AI and automation

release on dispose

Muki Kiboigob0c0b3fe3a01
diff --git a/src/browser/webapi/navigation/NavigationHistoryEntry.zig b/src/browser/webapi/navigation/NavigationHistoryEntry.zig
index c8c1010b2..76beeb0bb 100644
--- a/src/browser/webapi/navigation/NavigationHistoryEntry.zig
+++ b/src/browser/webapi/navigation/NavigationHistoryEntry.zig
@@ -92,9 +92,10 @@ fn getOnDispose(self: *const NavigationHistoryEntry) ?js.Function.Global {
return self._on_dispose;
}
-pub fn setOnDispose(self: *NavigationHistoryEntry, listener: ?js.Function) !void {
- if (listener) |listen| {
- self._on_dispose = try listen.persistWithThis(self);
+pub fn setOnDispose(self: *NavigationHistoryEntry, cb_: ?js.Function) !void {
+ if (self._on_dispose) |od| od.release();
+ if (cb_) |cb| {
+ self._on_dispose = try cb.persistWithThis(self);
} else {
self._on_dispose = null;
}