Skip to content

Lightpanda: the headless browser designed for AI and automation

tools: wait for networkidle after an action-triggered navigation

Adrià Arrufatb2fb908e0616
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index d70f19860..0606cba31 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -1860,7 +1860,8 @@ fn awaitQueuedNavigation(session: *lp.Session, frame: *lp.Frame) ToolError!void
return;
}
var runner = session.runner(.{});
- runner.waitForFrame(root_frame_id, 10000, .{ .until = .done }) catch |err|
+ // `.done` never arrives on a page with background timers or polling.
+ runner.waitForFrame(root_frame_id, 10000, .{ .until = .networkidle }) catch |err|
return if (err == error.Cancelled) ToolError.Cancelled else ToolError.NavigationFailed;
}
@@ -1904,7 +1905,7 @@ fn finalizeAction(arena: std.mem.Allocator, session: *lp.Session, registry: *Nod
// The action opened a new window (target=_blank or window.open).
// Follow it, as a user whose click opened a tab would.
var runner = session.runner(.{});
- runner.waitForFrame(page.page.frame._frame_id, 10000, .{ .until = .done }) catch |err|
+ runner.waitForFrame(page.page.frame._frame_id, 10000, .{ .until = .networkidle }) catch |err|
return if (err == error.Cancelled) ToolError.Cancelled else ToolError.NavigationFailed;
page = try requireFrame(session);
const popups = page.page.popups.items;