Skip to content

Lightpanda: the headless browser designed for AI and automation

shortcut default/text getResponse instead of caching path

Muki Kiboigob3655f59184a
diff --git a/src/browser/webapi/net/XMLHttpRequest.zig b/src/browser/webapi/net/XMLHttpRequest.zig
index 35bf4fb09..11921e969 100644
--- a/src/browser/webapi/net/XMLHttpRequest.zig
+++ b/src/browser/webapi/net/XMLHttpRequest.zig
@@ -519,9 +519,14 @@ fn getResponseURL(self: *XMLHttpRequest) []const u8 {
fn getResponse(self: *XMLHttpRequest, exec: *const Execution) !?Response {
// https://xhr.spec.whatwg.org/#the-response-attribute
- // If the response type is default or text, we don't need it to be done to return things.
- const needs_done = self._response_type != .default and self._response_type != .text;
- if (needs_done and self._ready_state != .done) {
+ // default/text can be read while still loading, so we return the
+ // current bytes directly instead of caching a value that would go
+ // stale as more data arrives.
+ if (self._response_type == .default or self._response_type == .text) {
+ return .{ .text = self._response_data.items };
+ }
+
+ if (self._ready_state != .done) {
return null;
}
@@ -532,7 +537,7 @@ fn getResponse(self: *XMLHttpRequest, exec: *const Execution) !?Response {
const data = self._response_data.items;
const res: Response = switch (self._response_type) {
- .default, .text => .{ .text = data },
+ .default, .text => unreachable,
.json => blk: {
const local = exec.js.local.?;