Skip to content

Lightpanda: the headless browser designed for AI and automation

interactive: skip hidden elements

Adrià Arrufatb814af122d93
diff --git a/src/browser/interactive.zig b/src/browser/interactive.zig
index e31f8ac67..1fbb0c8ab 100644
--- a/src/browser/interactive.zig
+++ b/src/browser/interactive.zig
@@ -179,6 +179,7 @@ fn walkInteractive(
const listener_targets = try buildListenerTargetMap(frame, arena);
var css_cache: Element.PointerEventsCache = .empty;
+ var visibility_cache: Element.VisibilityCache = .empty;
var results: std.ArrayList(InteractiveElement) = .empty;
@@ -193,6 +194,11 @@ fn walkInteractive(
else => {},
}
+ if (!el.checkVisibilityCached(&visibility_cache, frame)) {
+ tw.skipChildren();
+ continue;
+ }
+
const itype = classifyInteractivity(frame, el, html_el, listener_targets, &css_cache) orelse continue;
const role = getRole(el);
@@ -663,3 +669,17 @@ test "browser.interactive: mixed elements" {
defer testing.test_session.closeAllPages();
try testing.expectEqual(4, elements.len);
}
+
+test "browser.interactive: hidden elements are skipped" {
+ const elements = try testInteractive(
+ \\<button style="display:none">Inline</button>
+ \\<button hidden>Attribute</button>
+ \\<div style="display:none"><a href="/x">Ancestor</a><input type="text"></div>
+ \\<div hidden><button>Ancestor attribute</button></div>
+ \\<button>Visible</button>
+ );
+ defer testing.test_session.closeAllPages();
+ try testing.expectEqual(1, elements.len);
+ try testing.expectEqual("button", elements[0].tag_name);
+ try testing.expectEqual("Visible", elements[0].name.?);
+}