Skip to content

Lightpanda: the headless browser designed for AI and automation

window: add outerWidth, outerHeight, screenX/Y and screenLeft/Top

Jay Hemnanib84f019163e0
diff --git a/src/browser/tests/window/replaceable.html b/src/browser/tests/window/replaceable.html
index 218283789..67252ccaa 100644
--- a/src/browser/tests/window/replaceable.html
+++ b/src/browser/tests/window/replaceable.html
@@ -17,6 +17,7 @@
"console", "self", "frames", "parent", "length",
"scrollX", "scrollY", "pageXOffset", "pageYOffset",
"innerWidth", "innerHeight", "devicePixelRatio",
+ "outerWidth", "outerHeight", "screenX", "screenY", "screenLeft", "screenTop",
].forEach(checkReplaceable);
</script>
diff --git a/src/browser/tests/window/window.html b/src/browser/tests/window/window.html
index 7c7cc5162..5f7136cae 100644
--- a/src/browser/tests/window/window.html
+++ b/src/browser/tests/window/window.html
@@ -12,6 +12,15 @@
testing.expectEqual(1920, innerWidth);
</script>
+<script id=outer_size_and_screen_position>
+ testing.expectEqual(innerWidth, outerWidth);
+ testing.expectEqual(innerHeight, outerHeight);
+ testing.expectEqual(0, screenX);
+ testing.expectEqual(0, screenY);
+ testing.expectEqual(0, screenLeft);
+ testing.expectEqual(0, screenTop);
+</script>
+
<script id=is_secure_context>
{
// The test server is on 127.0.0.1: loopback is potentially trustworthy.
diff --git a/src/browser/webapi/Window.zig b/src/browser/webapi/Window.zig
index ebae20c9a..ad1a7f26a 100644
--- a/src/browser/webapi/Window.zig
+++ b/src/browser/webapi/Window.zig
@@ -220,6 +220,30 @@ fn setDevicePixelRatio(self: *Window, value: js.Value) void {
self.replaceGlobalProperty(value, "devicePixelRatio");
}
+fn setOuterWidth(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "outerWidth");
+}
+
+fn setOuterHeight(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "outerHeight");
+}
+
+fn setScreenX(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "screenX");
+}
+
+fn setScreenY(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "screenY");
+}
+
+fn setScreenLeft(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "screenLeft");
+}
+
+fn setScreenTop(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "screenTop");
+}
+
fn setScrollX(self: *Window, value: js.Value) void {
self.replaceGlobalProperty(value, "scrollX");
}
@@ -781,6 +805,20 @@ fn getDevicePixelRatio(_: *const Window, frame: *Frame) f32 {
return frame.page.getViewport().scale;
}
+// There is no window frame around the viewport and no window position on a
+// screen, so the outer size is the viewport and the position is 0.
+fn getOuterWidth(_: *const Window, frame: *Frame) u32 {
+ return frame.page.getViewport().width;
+}
+
+fn getOuterHeight(_: *const Window, frame: *Frame) u32 {
+ return frame.page.getViewport().height;
+}
+
+fn getScreenPosition(_: *const Window) i32 {
+ return 0;
+}
+
pub fn scrollTo(self: *Window, opts: Element.ScrollToOpts, y: ?i32, frame: *Frame) !void {
const o = opts.offsets(y);
const size = self._frame.document.scrollSize();
@@ -1163,6 +1201,12 @@ pub const JsApi = struct {
pub const innerWidth = bridge.accessor(Window.getInnerWidth, Window.setInnerWidth, .{});
pub const innerHeight = bridge.accessor(Window.getInnerHeight, Window.setInnerHeight, .{});
pub const devicePixelRatio = bridge.accessor(Window.getDevicePixelRatio, Window.setDevicePixelRatio, .{});
+ pub const outerWidth = bridge.accessor(Window.getOuterWidth, Window.setOuterWidth, .{});
+ pub const outerHeight = bridge.accessor(Window.getOuterHeight, Window.setOuterHeight, .{});
+ pub const screenX = bridge.accessor(Window.getScreenPosition, Window.setScreenX, .{});
+ pub const screenY = bridge.accessor(Window.getScreenPosition, Window.setScreenY, .{});
+ pub const screenLeft = bridge.accessor(Window.getScreenPosition, Window.setScreenLeft, .{});
+ pub const screenTop = bridge.accessor(Window.getScreenPosition, Window.setScreenTop, .{});
pub const opener = bridge.accessor(Window.getOpener, Window.setOpener, .{});
pub const closed = bridge.accessor(Window.getClosed, null, .{});