Lightpanda: the headless browser designed for AI and automation
cdp: on context not found, return the same code & message as Chrome
Karl Seguinbf145f48ba76
diff --git a/src/server/cdp/domains/browser.zig b/src/server/cdp/domains/browser.zigindex 82db99050..2a5318b7e 100644--- a/src/server/cdp/domains/browser.zig+++ b/src/server/cdp/domains/browser.zig@@ -352,7 +352,7 @@ test "cdp.browser: disposing a context clears its permission overrides" {try testing.expectEqual(@as(usize, 2), browser.permissions.count());try ctx.processMessage(.{ .id = 3, .method = "Target.disposeBrowserContext", .params = .{ .browserContextId = "BID-UNKNOWN" } });- try ctx.expectSentError(-32602, "No browser context with the given id found", .{ .id = 3 });+ try ctx.expectSentError(-32000, "Failed to find context with id BID-UNKNOWN", .{ .id = 3 });try testing.expectEqual(@as(usize, 2), browser.permissions.count());try ctx.processMessage(.{ .id = 4, .method = "Target.disposeBrowserContext", .params = .{ .browserContextId = "BID-PERM-OLD" } });diff --git a/src/server/cdp/domains/target.zig b/src/server/cdp/domains/target.zigindex 7c80905da..ccdd2371d 100644--- a/src/server/cdp/domains/target.zig+++ b/src/server/cdp/domains/target.zig@@ -148,11 +148,9 @@ fn disposeBrowserContext(cmd: *CDP.Command) !void {browserContextId: []const u8,})) orelse return error.InvalidParams;- const bc = cmd.browser_context orelse {- return cmd.sendError(-32602, "No browser context with the given id found", .{});- };+ const bc = cmd.browser_context orelse return sendContextNotFound(cmd, params.browserContextId);if (std.mem.eql(u8, bc.id, params.browserContextId) == false) {- return cmd.sendError(-32602, "No browser context with the given id found", .{});+ return sendContextNotFound(cmd, params.browserContextId);}// Disposing a context closes its target; drivers wait on those events.@@ -161,6 +159,11 @@ fn disposeBrowserContext(cmd: *CDP.Command) !void {try cmd.sendResult(null, .{});}+fn sendContextNotFound(cmd: *CDP.Command, context_id: []const u8) !void {+ const message = try std.fmt.allocPrint(cmd.arena, "Failed to find context with id {s}", .{context_id});+ return cmd.sendError(-32000, message, .{});+}+fn createTarget(cmd: *CDP.Command) !void {const params = (try cmd.params(struct {url: [:0]const u8 = "about:blank",@@ -607,7 +610,7 @@ test "cdp.target: disposeBrowserContext" {.method = "Target.disposeBrowserContext",.params = .{ .browserContextId = "BID-10" },});- try ctx.expectSentError(-32602, "No browser context with the given id found", .{ .id = 8 });+ try ctx.expectSentError(-32000, "Failed to find context with id BID-10", .{ .id = 8 });}{@@ -681,7 +684,7 @@ test "cdp.target: disposeBrowserContext destroys an unattached target" {// An invalid context ID must leave the live target untouched.try ctx.processMessage(.{ .id = 2, .method = "Target.disposeBrowserContext", .params = .{ .browserContextId = "BID-UNKNOWN" } });- try ctx.expectSentError(-32602, "No browser context with the given id found", .{ .id = 2 });+ try ctx.expectSentError(-32000, "Failed to find context with id BID-UNKNOWN", .{ .id = 2 });try ctx.expectSentCount(3);try testing.expectEqual(&target_id, bc.target_id.?);