Skip to content

Lightpanda: the headless browser designed for AI and automation

base: handle tag insertion w/ href

Pierre Tachoirebf42831f9a26
diff --git a/src/browser/webapi/Node.zig b/src/browser/webapi/Node.zig
index dc5e71d68..f14c7784f 100644
--- a/src/browser/webapi/Node.zig
+++ b/src/browser/webapi/Node.zig
@@ -1218,7 +1218,7 @@ pub fn cloneNodeInto(self: *Node, deep: bool, document: *const Document, frame:
.processing_instruction => Frame.node_factory.createProcessingInstruction(document, cd.subtype(CData.ProcessingInstruction)._target, data),
};
},
- .element => return self.subtype(Element).clone(deep, document, frame),
+ .element => return self.subtype(Element).clone(deep, document, frame) catch return error.CloneError,
.document => {
const doc = self.subtype(Document);
const cloned = switch (doc._type) {
diff --git a/src/browser/webapi/element/html/Base.zig b/src/browser/webapi/element/html/Base.zig
index 25e956d7b..95ef472df 100644
--- a/src/browser/webapi/element/html/Base.zig
+++ b/src/browser/webapi/element/html/Base.zig
@@ -28,6 +28,7 @@ const Element = @import("../../Element.zig");
const HtmlElement = @import("../Html.zig");
+const String = lp.String;
const Base = @This();
pub const Proto = HtmlElement;
@@ -56,16 +57,16 @@ pub fn setHref(self: *Base, value: []const u8, frame: *Frame) !void {
const element = self.asElement();
try element.setAttributeSafe(comptime .wrap("href"), .wrap(value), frame);
+ if (element.asNode().isConnected() == false) return;
+ try self.baseAddedCallback(frame);
+}
+
+fn baseAddedCallback(self: *Base, frame: *Frame) !void {
// Per HTML spec, the document's base URL is the href of the FIRST <base>
// element in tree order that has an href attribute — not necessarily this
// one. Re-derive from scratch so that setting href on a non-authoritative
// <base>, or clearing href on the authoritative one, both work correctly.
- const node = element.asNode();
- if (!node.isConnected()) {
- return;
- }
-
- const owner = node.ownerFrame(frame) orelse return;
+ const owner = self.asNode().ownerFrame(frame) orelse return;
const first = (try owner.document.querySelector(comptime .wrap("base[href]"), owner)) orelse {
owner.base_url = null;
return;
@@ -96,6 +97,28 @@ pub const JsApi = struct {
pub const target = reflect.string("target");
};
+pub const Build = struct {
+ pub const parser_created_on_insert = true;
+
+ pub fn created(node: *Node, frame: *Frame) !void {
+ if (node.isConnected() == false) return;
+
+ const self = node.as(Base);
+ try self.baseAddedCallback(frame);
+ }
+
+ pub fn attributeChange(element: *Element, name: String, _: String, frame: *Frame) !void {
+ if (!name.eql(comptime .wrap("href"))) {
+ return;
+ }
+ if (element.asNode().isConnected() == false) return;
+
+ try element.as(Base).baseAddedCallback(frame);
+ }
+
+ // TODO handle attribute remove?
+};
+
const testing = @import("../../../../testing.zig");
test "WebApi: HTML.Base" {
try testing.htmlRunner("element/html/base.html", .{});