Skip to content

Lightpanda: the headless browser designed for AI and automation

cdp: LP.waitForSelector shares the state-dependent wait default

Adrià Arrufatc793ea8c0f89
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index 1c26a93fb..44424753f 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -1635,7 +1635,8 @@ const default_wait_timeout_ms: u32 = 5000;
/// A wait entered before `load` also inherits the nav budget: a post-load
/// selector keeps the wall time it had when `goto` waited for `load` itself.
-fn defaultWaitTimeout(frame: *const lp.Frame) u32 {
+/// Shared with CDP's `LP.waitForSelector`, which fronts the same action.
+pub fn defaultWaitTimeout(frame: *const lp.Frame) u32 {
if (frame._load_state == .complete) return default_wait_timeout_ms;
return default_nav_timeout_ms + default_wait_timeout_ms;
}
diff --git a/src/cdp/domains/lp.zig b/src/cdp/domains/lp.zig
index 9313e2e5b..8c4617c72 100644
--- a/src/cdp/domains/lp.zig
+++ b/src/cdp/domains/lp.zig
@@ -344,7 +344,7 @@ fn waitForSelector(cmd: anytype) !void {
const bc = cmd.browser_context orelse return error.NoBrowserContext;
const frame = bc.mainFrame() orelse return error.FrameNotLoaded;
- const timeout_ms = params.timeout orelse 5000;
+ const timeout_ms = params.timeout orelse lp.tools.defaultWaitTimeout(frame);
const selector_z = try cmd.arena.dupeZ(u8, params.selector);
const node = lp.actions.waitForSelector(selector_z, timeout_ms, frame._frame_id, bc.session) catch |err| {