Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: don't fire AbortSignal.timeout() after frame detach

Francis Bouviercc81c5993b45
diff --git a/src/browser/webapi/AbortSignal.zig b/src/browser/webapi/AbortSignal.zig
index 64cbd2752..b9e34faec 100644
--- a/src/browser/webapi/AbortSignal.zig
+++ b/src/browser/webapi/AbortSignal.zig
@@ -245,6 +245,22 @@ const TimeoutCallback = struct {
}
fn timeoutAbort(self: *TimeoutCallback) !void {
+ // Per spec, the abort is queued as a global task on the signal's
+ // global: it must not run when the global's document is no longer
+ // fully active (e.g. the iframe that created the signal was detached).
+ switch (self.exec.js.global) {
+ .frame => |frame| {
+ var current: ?@TypeOf(frame) = frame;
+ while (current) |f| : (current = f.parent) {
+ const iframe = f.iframe orelse continue;
+ if (!iframe.asNode().isConnected()) {
+ return;
+ }
+ }
+ },
+ .worker => {},
+ }
+
const dom = try self.exec.arena.create(DOMException);
dom.* = DOMException.fromError(error.TimeoutError).?;
try self.signal.abort(.{ .dom = dom }, self.exec);