Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: remove button.required, it isn't a real attribute

Karl Seguincd7c33436faa
diff --git a/src/browser/tests/element/html/base_dynamic.html b/src/browser/tests/element/html/base_dynamic.html
index 7a9836183..b6f92f522 100644
--- a/src/browser/tests/element/html/base_dynamic.html
+++ b/src/browser/tests/element/html/base_dynamic.html
@@ -195,6 +195,7 @@
// falls back to the document's fallback base URL.
// The URL parser lowercases the scheme and strips spaces, tabs and
// newlines: these are data: and javascript: URLs too.
+ testing.beginBrowserLog("Chrome: 'data'/'javascript' URLs may not be used as base URLs");
for (const href of ['data:/,more-test', 'javascript:/,more-test',
'DATA:/,more-test', 'JavaScript:/,more-test',
' data:/,more-test', 'java\tscript:/,more-test']) {
@@ -206,6 +207,7 @@
testing.expectEqual(new URL('blah', document.URL).href, a.href);
b.remove();
}
+ testing.endBrowserLog();
}
</script>
diff --git a/src/browser/tests/element/html/button.html b/src/browser/tests/element/html/button.html
index 7860ab86f..f8cb37400 100644
--- a/src/browser/tests/element/html/button.html
+++ b/src/browser/tests/element/html/button.html
@@ -62,7 +62,6 @@
<button id="named2"></button>
<button id="required1" required></button>
-<button id="required2"></button>
<script id="name_initial">
testing.expectEqual('submit-btn', $('#named1').name)
@@ -95,39 +94,15 @@
}
</script>
-<script id="required_initial">
- testing.expectEqual(true, $('#required1').required)
- testing.expectEqual(false, $('#required2').required)
-</script>
-
-<script id="required_set">
+<script id="no_required">
{
- const button = document.createElement('button')
- testing.expectEqual(false, button.required)
+ // <button> has no required IDL attribute; the content attribute is inert.
+ testing.expectFalse('required' in $('#required1'))
+ testing.expectEqual('', $('#required1').getAttribute('required'))
- button.required = true
- testing.expectEqual(true, button.required)
- testing.expectEqual('', button.getAttribute('required'))
-
- button.required = false
- testing.expectEqual(false, button.required)
- testing.expectEqual(null, button.getAttribute('required'))
- }
-</script>
-
-<script id="required_reflects_to_attribute">
- {
const button = document.createElement('button')
- testing.expectEqual(null, button.getAttribute('required'))
- testing.expectFalse(button.outerHTML.includes('required'))
-
button.required = true
- testing.expectEqual('', button.getAttribute('required'))
- testing.expectTrue(button.outerHTML.includes('required'))
-
- button.required = false
testing.expectEqual(null, button.getAttribute('required'))
- testing.expectFalse(button.outerHTML.includes('required'))
}
</script>
diff --git a/src/browser/tests/testing.js b/src/browser/tests/testing.js
index c29c4d26d..986cc4009 100644
--- a/src/browser/tests/testing.js
+++ b/src/browser/tests/testing.js
@@ -187,6 +187,21 @@
return true;
}
+ // Brackets messages the browser itself logs (not console.* calls, so they
+ // can't be silenced) for an expected error case. Folded into a collapsed
+ // group so a clean run in Chrome/Firefox shows nothing unexpected.
+ function beginBrowserLog(reason) {
+ if (IS_TEST_RUNNER === false) {
+ console.groupCollapsed(`expected browser logs: ${reason || _currentScriptId()}`);
+ }
+ }
+
+ function endBrowserLog() {
+ if (IS_TEST_RUNNER === false) {
+ console.groupEnd();
+ }
+ }
+
function printTimeoutState() {
console.warn('Pending count:', Array.from(async_pending.keys()));
}
@@ -204,6 +219,8 @@
withError: withError,
withReportedErrors: withReportedErrors,
printTimeoutState: printTimeoutState,
+ beginBrowserLog: beginBrowserLog,
+ endBrowserLog: endBrowserLog,
onload: onload,
IS_TEST_RUNNER: IS_TEST_RUNNER,
HOST: '127.0.0.1',
diff --git a/src/browser/webapi/element/html/Button.zig b/src/browser/webapi/element/html/Button.zig
index 1378c8d2b..2d0f2cac6 100644
--- a/src/browser/webapi/element/html/Button.zig
+++ b/src/browser/webapi/element/html/Button.zig
@@ -203,7 +203,6 @@ pub const JsApi = struct {
pub const disabled = reflect.boolean("disabled");
pub const name = reflect.string("name");
- pub const required = reflect.boolean("required");
pub const form = bridge.accessor(Button.getForm, null, .{});
pub const formAction = bridge.accessor(Button.getFormAction, Button.setFormAction, .{ .ce_reactions = true });
pub const formEnctype = bridge.accessor(Button.getFormEnctype, Button.setFormEnctype, .{ .ce_reactions = true });