Lightpanda: the headless browser designed for AI and automation
tools: resolve $LP_* placeholders in startGoto
Adrià Arrufatcfd61ca69e82
diff --git a/src/browser/tools.zig b/src/browser/tools.zigindex b6587a3e4..f020a5fce 100644--- a/src/browser/tools.zig+++ b/src/browser/tools.zig@@ -1856,7 +1856,8 @@ pub fn startGoto(arguments: ?std.json.Value,receiver_frame_id: ?u32,) ToolError!StartedGoto {- const args = try parseArgs(GotoParams, arena, arguments);+ // This path bypasses `call`, so it needs its own `$LP_*` substitution pass.+ const args = try parseArgs(GotoParams, arena, try substituteStringArgs(arena, .goto, arguments));if (receiver_frame_id) |fid| {if (session.livePage(fid)) |page| {registry.resetFrame(arena, &page.frame);diff --git a/src/script/Runtime.zig b/src/script/Runtime.zigindex 2ab67361c..8e923b916 100644--- a/src/script/Runtime.zig+++ b/src/script/Runtime.zig@@ -1083,6 +1083,30 @@ test "agent script runtime: parallel gotos coexist and route per page" {);}+test "agent script runtime: goto resolves $LP_* placeholders" {+ defer testing.reset();+ defer testing.test_session.closeAllPages();++ var registry = CDPNode.Registry.init(testing.allocator);+ defer registry.deinit();++ const runtime = try Runtime.init(testing.allocator, testing.test_app, testing.test_session, ®istry);+ defer runtime.deinit();++ _ = setenv(@constCast("LP_RUNTIME_GOTO_BASE"), @constCast("http://localhost:9582"), 1);+ defer _ = unsetenv(@constCast("LP_RUNTIME_GOTO_BASE"));++ try runTestScript(runtime,+ \\const page = new Page();+ \\await page.goto("$LP_RUNTIME_GOTO_BASE/src/browser/tests/mcp_actions.html");+ \\const { btn } = page.extract({ btn: "#btn" });+ \\if (btn !== "Click Me") throw new Error("wrong page: " + btn);+ );+}++extern fn setenv(name: [*:0]u8, value: [*:0]u8, override: c_int) c_int;+extern fn unsetenv(name: [*:0]u8) c_int;+test "agent script runtime: a tool-triggered navigation keeps the handle routable" {defer testing.reset();defer testing.test_session.closeAllPages();