Skip to content

Lightpanda: the headless browser designed for AI and automation

fix abort release->reject ordering

Karl Seguind86aa293f59a
diff --git a/src/browser/tests/weblocks.html b/src/browser/tests/weblocks.html
index 942c9563e..f3c9ec1c5 100644
--- a/src/browser/tests/weblocks.html
+++ b/src/browser/tests/weblocks.html
@@ -403,6 +403,22 @@
}
</script>
+<script id=abortedRequestIsRemovedBeforePromiseRejects type=module>
+{
+ const state = await testing.async();
+ navigator.locks.request('timeout-abort', () => new Promise(() => {}));
+ navigator.locks.request('timeout-abort', { signal: AbortSignal.timeout(5) }, () => {})
+ .catch(async (e) => {
+ const snapshot = await navigator.locks.query();
+ const pending = snapshot.pending.filter((p) => p.name === 'timeout-abort').length;
+ state.resolve(e.name + ':' + pending);
+ });
+ await state.done((v) => {
+ testing.expectEqual('TimeoutError:0', v);
+ });
+}
+</script>
+
<script id=lockIsReleasedBeforeRequestPromiseResolves type=module>
{
const state = await testing.async();
diff --git a/src/browser/webapi/LockManager.zig b/src/browser/webapi/LockManager.zig
index 4f900c7b9..d7e82b21d 100644
--- a/src/browser/webapi/LockManager.zig
+++ b/src/browser/webapi/LockManager.zig
@@ -207,8 +207,8 @@ pub const LockRequest = struct {
defer ls.deinit();
const resolver = self.resolver.local(&ls.local);
- resolver.reject("LockManager.signal.aborted", reason);
self.manager.releaseLock(self);
+ resolver.reject("LockManager.signal.aborted", reason);
}
};