Skip to content

Lightpanda: the headless browser designed for AI and automation

Add test

Karl Seguineb6cd3e5214d
diff --git a/src/browser/tests/streams/readable_stream.html b/src/browser/tests/streams/readable_stream.html
index 1216e3afa..ebad2c459 100644
--- a/src/browser/tests/streams/readable_stream.html
+++ b/src/browser/tests/streams/readable_stream.html
@@ -464,6 +464,30 @@
}
</script>
+<script id=response_text_rejects_with_stream_error type=module>
+ const state = await testing.async();
+
+ const errored = new Error('errored');
+ const pulled = new Error('pulled');
+ let r1, r2;
+ try {
+ await new Response(new ReadableStream({ start(c) { c.error(errored); } })).text();
+ } catch (x) {
+ r1 = x;
+ }
+ try {
+ await new Response(new ReadableStream({ pull() { throw pulled; } })).text();
+ } catch (x) {
+ r2 = x;
+ }
+ state.resolve();
+
+ await state.done(() => {
+ testing.expectEqual(errored, r1);
+ testing.expectEqual(pulled, r2);
+ });
+</script>
+
<script id=stored_error type=module>
const state = await testing.async();
diff --git a/src/browser/webapi/streams/ReadableStream.zig b/src/browser/webapi/streams/ReadableStream.zig
index 2930ad79f..7ff9535bc 100644
--- a/src/browser/webapi/streams/ReadableStream.zig
+++ b/src/browser/webapi/streams/ReadableStream.zig
@@ -217,15 +217,9 @@ pub fn callPullIfNeeded(self: *ReadableStream) !void {
// Note: In a complete implementation, we'd handle the promise returned by pull
// and set _pulling = false when it resolves
ls.toLocal(func).callRethrow(void, .{self._controller}) catch |err| {
- if (err == error.JsException or err == error.TryCatchRethrow) {
- if (try_catch.exceptionValue()) |exc| {
- try self._controller.errorWithValue(exc);
- } else {
- return err;
- }
- } else {
- return err;
- }
+ if (err != error.TryCatchRethrow) return err;
+ const exc = try_catch.exceptionValue() orelse return err;
+ try self._controller.fail(&ls.local, exc);
};
}
diff --git a/src/browser/webapi/streams/ReadableStreamDefaultController.zig b/src/browser/webapi/streams/ReadableStreamDefaultController.zig
index 32778ee6e..8453063b0 100644
--- a/src/browser/webapi/streams/ReadableStreamDefaultController.zig
+++ b/src/browser/webapi/streams/ReadableStreamDefaultController.zig
@@ -243,12 +243,6 @@ pub fn fail(self: *ReadableStreamDefaultController, local: *const js.Local, reas
}
}
-/// Errors the stream with an arbitrary JS value, preserving its identity.
-/// This is what the JS-facing `controller.error(e)` uses.
-pub fn errorWithValue(self: *ReadableStreamDefaultController, value: js.Value) !void {
- return self.fail(value.local, value);
-}
-
/// The caller owns the returned global and must release it.
pub fn dequeue(self: *ReadableStreamDefaultController) ?js.Value.Global {
if (self._queue.items.len == 0) {