Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: on writablestream close error, reject

Karl Seguineb78800b77fe
diff --git a/src/browser/tests/streams/readable_stream.html b/src/browser/tests/streams/readable_stream.html
index d677f751e..fe6f4c2cd 100644
--- a/src/browser/tests/streams/readable_stream.html
+++ b/src/browser/tests/streams/readable_stream.html
@@ -454,7 +454,7 @@
<script id=stored_error type=module>
const state = await testing.async();
- // read(), cancel(), write() and close() reject with whatever
+ // read(), cancel(), write(), close() and closed reject with whatever
// controller.error() was given.
const errored = new ReadableStream({ start(c) { c.error('err!'); } }).getReader();
const no_reason = new ReadableStream({ start(c) { c.error(); } }).getReader();
@@ -467,10 +467,11 @@
await errored_sink.write('a').catch((e) => e),
await errored_sink.close().catch((e) => e),
await no_reason_sink.close().then(() => 'resolved', (e) => e),
+ await errored_sink.closed.catch((e) => e),
];
state.resolve();
await state.done(() => {
- testing.expectEqual(['err!', 'err!', undefined, 'err!', 'err!', undefined], results);
+ testing.expectEqual(['err!', 'err!', undefined, 'err!', 'err!', undefined, 'err!'], results);
});
</script>
diff --git a/src/browser/webapi/streams/WritableStreamDefaultWriter.zig b/src/browser/webapi/streams/WritableStreamDefaultWriter.zig
index 3d1354f4f..cfed9426a 100644
--- a/src/browser/webapi/streams/WritableStreamDefaultWriter.zig
+++ b/src/browser/webapi/streams/WritableStreamDefaultWriter.zig
@@ -92,8 +92,10 @@ pub fn getClosed(self: *WritableStreamDefaultWriter, exec: *const Execution) !js
return local.typeError("Writer has been released");
};
- if (stream._state == .closed) {
- return local.resolvePromise(.{});
+ if (stream._state == .errored) {
+ const resolver = local.createPromiseResolver();
+ resolver.reject("WritableStreamDefaultWriter.closed", stream._stored_error.?);
+ return resolver.promise();
}
return local.resolvePromise(.{});