Lightpanda: the headless browser designed for AI and automation
webapi: add support for form[field]
Pranav Joglekarf07b2d352048
diff --git a/src/browser/tests/element/html/form.html b/src/browser/tests/element/html/form.htmlindex 2612be61c..8532ad266 100644--- a/src/browser/tests/element/html/form.html+++ b/src/browser/tests/element/html/form.html@@ -46,6 +46,17 @@}</script>+<script id="direct_form_named_access">+{+ const form = $('#form_controls');+ testing.expectEqual(form.elements.user, form.user);+ testing.expectEqual(form.elements.pass, form.pass);++ // real properties still win+ testing.expectEqual('function', typeof form.submit);+}+</script>+<!-- Test fixtures for form.method --><form id="form_get" method="get"></form><form id="form_post" method="post"></form>diff --git a/src/browser/webapi/collections/HTMLFormControlsCollection.zig b/src/browser/webapi/collections/HTMLFormControlsCollection.zigindex e3c27a5ea..8e3300085 100644--- a/src/browser/webapi/collections/HTMLFormControlsCollection.zig+++ b/src/browser/webapi/collections/HTMLFormControlsCollection.zig@@ -55,12 +55,12 @@ pub fn getAtIndex(self: *HTMLFormControlsCollection, index: usize, frame: *Framereturn self._proto.getAtIndex(index, frame);}-const NamedItemResult = union(enum) {+pub const NamedItemResult = union(enum) {element: *Element,radio_node_list: *RadioNodeList,};-fn namedItem(self: *HTMLFormControlsCollection, name: []const u8, frame: *Frame) !?NamedItemResult {+pub fn namedItem(self: *HTMLFormControlsCollection, name: []const u8, frame: *Frame) !?NamedItemResult {if (name.len == 0) {return null;}diff --git a/src/browser/webapi/element/html/Form.zig b/src/browser/webapi/element/html/Form.zigindex 44cf990c8..f5407dda0 100644--- a/src/browser/webapi/element/html/Form.zig+++ b/src/browser/webapi/element/html/Form.zig@@ -188,6 +188,25 @@ fn getFormOwner(element: *Element, frame: *Frame) ?*Form {return null;}+fn matchesName(element: *Element, name: []const u8) bool {+ if (element.getId()) |id| {+ if (std.mem.eql(u8, id, name)) {+ return true;+ }+ }+ if (element.getName()) |elem_name| {+ if (std.mem.eql(u8, elem_name, name)) {+ return true;+ }+ }+ return false;+}++fn namedItem(self: *Form, name: []const u8, frame: *Frame) !?collections.HTMLFormControlsCollection.NamedItemResult {+ const elements = try self.getElements(frame);+ return elements.namedItem(name, frame);+}+/// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-form-checkvalidity/// Returns true if every submittable element in the form is valid. Fires an/// `invalid` event on each failing element.@@ -227,6 +246,16 @@ pub const JsApi = struct {pub var class_id: bridge.ClassId = undefined;};+ pub const @"[str]" = bridge.namedIndexed(Form.namedItem, null, null, null, struct {+ fn wrap(self: *Form, field_name: []const u8, frame: *Frame) !u32 {+ if (try hasNamed(self, field_name, frame)) {+ // Named properties are [LegacyUnenumerableNamedProperties]+ return js.v8.DontEnum;+ }+ return error.NotHandled;+ }+ }.wrap, .{ .null_as_undefined = true });+const reflect = Element.Reflect(Form);pub const encoding = reflect.enumerated("enctype", &.{ "application/x-www-form-urlencoded", "multipart/form-data", "text/plain" }, .{ .missing = "application/x-www-form-urlencoded" });pub const autocomplete = reflect.enumerated("autocomplete", &.{ "on", "off" }, .{ .missing = "on" });@@ -244,6 +273,21 @@ pub const JsApi = struct {pub const requestSubmit = bridge.function(Form.requestSubmit, .{});pub const checkValidity = bridge.function(Form.checkValidity, .{});pub const reportValidity = bridge.function(Form.reportValidity, .{});++ // Presence only, `namedItem` is relativel expensive / RC'd+ fn hasNamed(self: *Form, field_name: []const u8, frame: *Frame) !bool {+ if (field_name.len == 0) {+ return false;+ }++ var it = self.iterator(frame);+ while (it.next()) |element| {+ if (matchesName(element, field_name)) {+ return true;+ }+ }+ return false;+ }};const testing = @import("../../../../testing.zig");