Lightpanda: the headless browser designed for AI and automation
webapi: isEqualNode(null) now returns false rather than throwing
Karl Seguinf244fe10c849
diff --git a/src/browser/tests/node/is_equal_node.html b/src/browser/tests/node/is_equal_node.htmlindex ef192fae2..189d91ce6 100644--- a/src/browser/tests/node/is_equal_node.html+++ b/src/browser/tests/node/is_equal_node.html@@ -38,3 +38,13 @@testing.expectEqual(false, e1.isEqualNode(e2));}</script>++<script id=isEqualNode_null>+ {+ const div = document.createElement("div");+ testing.expectEqual(false, div.isEqualNode(null));+ testing.expectEqual(false, div.isEqualNode(undefined));+ testing.expectError('TypeError', () => div.isEqualNode());+ testing.expectError('TypeError', () => div.isEqualNode({}));+ }+</script>diff --git a/src/browser/webapi/Node.zig b/src/browser/webapi/Node.zigindex d45fb55cd..156093011 100644--- a/src/browser/webapi/Node.zig+++ b/src/browser/webapi/Node.zig@@ -1866,7 +1866,10 @@ pub const JsApi = struct {fn _getRootNode(self: *Node, opts: ?GetRootNodeOpts) *Node {return self.getRootNode(opts orelse .{});}- pub const isEqualNode = bridge.function(Node.isEqualNode, .{});+ pub const isEqualNode = bridge.function(_isEqualNode, .{});+ fn _isEqualNode(self: *Node, other: js.Nullable(*Node)) bool {+ return self.isEqualNode(other.value orelse return false);+ }pub const lookupNamespaceURI = bridge.function(_lookupNamespaceURI, .{});fn _lookupNamespaceURI(self: *Node, prefix: js.Nullable([]const u8), frame: *Frame) ?[]const u8 {return self.lookupNamespaceURI(prefix.value, frame);