Skip to content

Lightpanda: the headless browser designed for AI and automation

actions: route hover through the shared move sequence

Adrià Arrufatf2c2c4e9ce24
diff --git a/src/browser/actions.zig b/src/browser/actions.zig
index d88a686b0..58689658b 100644
--- a/src/browser/actions.zig
+++ b/src/browser/actions.zig
@@ -21,7 +21,6 @@ const lp = @import("../lightpanda.zig");
const DOMNode = @import("webapi/Node.zig");
const Element = @import("webapi/Element.zig");
const Event = @import("webapi/Event.zig");
-const MouseEvent = @import("webapi/event/MouseEvent.zig");
const KeyboardEvent = @import("webapi/event/KeyboardEvent.zig");
const Frame = @import("Frame.zig");
const Session = @import("Session.zig");
@@ -50,23 +49,8 @@ pub fn click(node: *DOMNode, frame: *Frame) !void {
pub fn hover(node: *DOMNode, frame: *Frame) !void {
const el = node.is(Element) orelse return error.InvalidNodeType;
- const mouseover_event: *MouseEvent = try .initTrusted(comptime .wrap("mouseover"), .{
- .bubbles = true,
- .cancelable = true,
- .composed = true,
- }, frame);
-
- frame._event_manager.dispatch(el.asEventTarget(), mouseover_event.asEvent()) catch |err| {
- lp.log.debug(.app, "hover mouseover failed", .{ .err = err });
- return error.ActionFailed;
- };
-
- const mouseenter_event: *MouseEvent = try .initTrusted(comptime .wrap("mouseenter"), .{
- .composed = true,
- }, frame);
-
- frame._event_manager.dispatch(el.asEventTarget(), mouseenter_event.asEvent()) catch |err| {
- lp.log.debug(.app, "hover mouseenter failed", .{ .err = err });
+ Frame.user_input.moveSequence(frame, el, .{}) catch |err| {
+ lp.log.debug(.app, "hover failed", .{ .err = err });
return error.ActionFailed;
};
}
diff --git a/src/mcp/tools.zig b/src/mcp/tools.zig
index dc028ebb1..049be9d13 100644
--- a/src/mcp/tools.zig
+++ b/src/mcp/tools.zig
@@ -1540,6 +1540,51 @@ test "MCP - Actions by selector: hover, selectOption, setChecked" {
try testing.expect(result.isTrue());
}
+test "MCP - hover moves the pointer between elements" {
+ const aa = testing.arena_allocator;
+
+ var out: std.Io.Writer.Allocating = .init(aa);
+ const server = try testLoadPage("http://localhost:9582/src/browser/tests/mcp_actions.html", &out.writer);
+ defer server.deinit();
+ server.active_session.enterIsolate();
+ defer server.active_session.exitIsolate();
+
+ const page = server.active_session.session.pages.items[0];
+
+ var ls: js.Local.Scope = undefined;
+ page.frame.js.localScope(&ls);
+ defer ls.deinit();
+
+ var try_catch: js.TryCatch = undefined;
+ try_catch.init(&ls.local);
+ defer try_catch.deinit();
+
+ _ = try ls.local.exec(
+ \\ window.hoverLog = [];
+ \\ for (const t of ['mouseover', 'mouseenter', 'mouseout', 'mouseleave', 'mousemove']) {
+ \\ document.addEventListener(t, (e) => window.hoverLog.push(t + ':' + (e.target.id || e.target.localName)), true);
+ \\ }
+ , null);
+
+ try router.handleMessage(server, aa,
+ \\{"jsonrpc":"2.0","id":1,"method":"tools/call","params":{"name":"hover","arguments":{"selector":"#hoverTarget"}}}
+ );
+ _ = try ls.local.exec("window.hoverLog.push('|')", null);
+ try router.handleMessage(server, aa,
+ \\{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"hover","arguments":{"selector":"#keyTarget"}}}
+ );
+
+ // The second hover leaves the first target, and <body>, their common
+ // ancestor, is neither left nor re-entered.
+ const result = try ls.local.exec(
+ \\ window.hoverLog.join(' ') === [
+ \\ 'mouseover:hoverTarget', 'mouseenter:html', 'mouseenter:body', 'mouseenter:hoverTarget', 'mousemove:hoverTarget', '|',
+ \\ 'mouseout:hoverTarget', 'mouseleave:hoverTarget', 'mouseover:keyTarget', 'mouseenter:keyTarget', 'mousemove:keyTarget',
+ \\ ].join(' ')
+ , null);
+ try testing.expect(result.isTrue());
+}
+
test "MCP - findElement" {
const aa = testing.arena_allocator;