Skip to content

Lightpanda: the headless browser designed for AI and automation

cdp: LP.getInteractiveElements reads the node's own frame

Adrià Arrufatf81d72c0dc1a
diff --git a/src/browser/tests/cdp/iframe/interactive_child.html b/src/browser/tests/cdp/iframe/interactive_child.html
new file mode 100644
index 000000000..2f56fe96c
--- /dev/null
+++ b/src/browser/tests/cdp/iframe/interactive_child.html
@@ -0,0 +1,4 @@
+<!doctype html>
+<div id=child-hook>child-hook</div>
+<a id=child-link href="target.html">child-link</a>
+<script>document.getElementById('child-hook').addEventListener('click', () => {});</script>
diff --git a/src/browser/tests/cdp/interactive_iframe.html b/src/browser/tests/cdp/interactive_iframe.html
new file mode 100644
index 000000000..873403d9c
--- /dev/null
+++ b/src/browser/tests/cdp/interactive_iframe.html
@@ -0,0 +1,4 @@
+<!doctype html>
+<div id=parent-hook>parent-hook</div>
+<script>document.getElementById('parent-hook').addEventListener('click', () => {});</script>
+<iframe src="iframe/interactive_child.html"></iframe>
diff --git a/src/server/cdp/domains/lp.zig b/src/server/cdp/domains/lp.zig
index bbcf957a5..adb3903a3 100644
--- a/src/server/cdp/domains/lp.zig
+++ b/src/server/cdp/domains/lp.zig
@@ -248,12 +248,13 @@ fn getInteractiveElements(cmd: anytype) !void {
const params = (try cmd.params(Params)) orelse Params{};
const bc = cmd.browser_context orelse return error.NoBrowserContext;
- const frame = bc.mainFrame() orelse return error.FrameNotLoaded;
+ const main_frame = bc.mainFrame() orelse return error.FrameNotLoaded;
const root = if (params.nodeId) |nodeId|
(bc.node_registry.lookup_by_id.get(nodeId) orelse return error.InvalidNodeId).dom
else
- frame.document.asNode();
+ main_frame.document.asNode();
+ const frame = root.ownerFrame(main_frame) orelse return error.InvalidNodeId;
const elements = try interactive.collectInteractiveElements(root, cmd.arena, frame);
try interactive.registerNodes(elements, &bc.node_registry);
@@ -671,6 +672,36 @@ test "cdp.lp: getInteractiveElements" {
try testing.expect(result.get("elements") != null);
}
+test "cdp.lp: getInteractiveElements reads the node's own frame" {
+ var ctx = try testing.context();
+ defer ctx.deinit();
+
+ const bc = try ctx.loadBrowserContext(.{ .id = "BID-T", .url = "cdp/interactive_iframe.html", .target_id = "FID-000000000T".* });
+ const root = bc.mainFrame() orelse unreachable;
+ const child = root.child_frames.items[0];
+
+ const html = (child.document.getDocumentElement() orelse unreachable).asNode();
+ const html_id = (try bc.node_registry.register(html)).id;
+
+ try ctx.processMessage(.{ .id = 1, .method = "LP.getInteractiveElements", .params = .{ .nodeId = html_id } });
+ const elements = (try dumpReply(&ctx, 1)).get("result").?.object.get("elements").?.array.items;
+
+ var found_hook = false;
+ var found_link = false;
+ for (elements) |el| {
+ const id = el.object.get("id") orelse continue;
+ if (std.mem.eql(u8, id.string, "child-hook")) {
+ found_hook = true;
+ try testing.expectEqual("listener", el.object.get("type").?.string);
+ } else if (std.mem.eql(u8, id.string, "child-link")) {
+ found_link = true;
+ try testing.expectEqual("http://127.0.0.1:9582/src/browser/tests/cdp/iframe/target.html", el.object.get("href").?.string);
+ }
+ }
+ try testing.expect(found_link);
+ try testing.expect(found_hook);
+}
+
test "cdp.lp: getStructuredData" {
var ctx = try testing.context();
defer ctx.deinit();