Skip to content

Lightpanda: the headless browser designed for AI and automation

cdp: dispatch loaded lifecyle event only for about:blank page.

Pierre Tachoiref87029273d62
diff --git a/src/browser/URL.zig b/src/browser/URL.zig
index a3efc9db6..a3d7c1f33 100644
--- a/src/browser/URL.zig
+++ b/src/browser/URL.zig
@@ -138,6 +138,10 @@ fn shouldPercentEncode(c: u8, comptime encode_set: EncodeSet) bool {
};
}
+pub fn isAboutBlank(url: []const u8) bool {
+ return std.mem.eql(u8, url, "about:blank");
+}
+
pub fn isCompleteHTTPUrl(url: []const u8) bool {
if (url.len < 3) { // Minimum is "x://"
return false;
@@ -726,6 +730,16 @@ test "URL: isCompleteHTTPUrl" {
try testing.expectEqual(false, isCompleteHTTPUrl("about"));
}
+test "URL: isAboutBlank" {
+ try testing.expectEqual(true, isAboutBlank("about:blank"));
+ try testing.expectEqual(false, isAboutBlank("about:srcdoc"));
+ try testing.expectEqual(false, isAboutBlank("about:"));
+ try testing.expectEqual(false, isAboutBlank(""));
+ try testing.expectEqual(false, isAboutBlank("about"));
+ try testing.expectEqual(false, isAboutBlank("http://example.com/about:blank"));
+ try testing.expectEqual(false, isAboutBlank("https://example.com/blob:x"));
+}
+
test "URL: resolve regression (#1093)" {
const Case = struct {
base: [:0]const u8,
diff --git a/src/server/cdp/domains/page.zig b/src/server/cdp/domains/page.zig
index 6ab038a61..d7847b9b2 100644
--- a/src/server/cdp/domains/page.zig
+++ b/src/server/cdp/domains/page.zig
@@ -125,7 +125,7 @@ fn setLifecycleEventsEnabled(cmd: *CDP.Command) !void {
// Like Chrome, report the initial about:blank as loaded. Its state is left
// as is, since the first navigation reuses it (see canNavigateInPlace).
- if (frame._load_state == .waiting) {
+ if (URL.isAboutBlank(frame.url)) {
const frame_id = &id.toFrameId(frame._frame_id);
const loader_id = &id.toLoaderId(frame._loader_id);