Skip to content

Lightpanda: the headless browser designed for AI and automation

cookies: keep a session cookie set with expires -1

Jay Hemnanifbe6bbb6fc36
diff --git a/src/cookies.zig b/src/cookies.zig
index f10431952..15ab01b32 100644
--- a/src/cookies.zig
+++ b/src/cookies.zig
@@ -160,7 +160,8 @@ const JsonCookie = struct {
.value = value,
.domain = domain,
.path = path,
- .expires = self.expires,
+ // A session cookie is written with expires: -1.
+ .expires = if (self.expires) |e| (if (e < 0) null else e) else null,
.secure = self.secure orelse false,
.http_only = self.httpOnly orelse false,
.same_site = same_site orelse .lax,
@@ -431,3 +432,23 @@ test "cookies: load JSON accepts CDP SameSite casing" {
defer cookie.deinit();
try std.testing.expectEqual(Cookie.SameSite.lax, cookie.same_site);
}
+
+test "cookies: load JSON keeps a session cookie with expires -1" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+
+ // Puppeteer's page.cookies() and CDP getCookies write a session cookie
+ // with expires: -1.
+ const parsed = try std.json.parseFromSliceLeaky(
+ []const JsonCookie,
+ arena.allocator(),
+ "[{\"name\":\"sid\",\"value\":\"1\",\"domain\":\"example.com\",\"expires\":-1,\"session\":true}]",
+ .{ .ignore_unknown_fields = true },
+ );
+
+ var jar = Cookie.Jar.init(std.testing.allocator, null);
+ defer jar.deinit();
+ try jar.add(try parsed[0].toCookie(jar.allocator), lp.datetime.timestamp(.real), true);
+ try std.testing.expectEqual(1, jar.cookies.items.len);
+ try std.testing.expectEqual(null, jar.cookies.items[0].expires);
+}
diff --git a/src/server/cdp/domains/storage.zig b/src/server/cdp/domains/storage.zig
index 701fc9b75..e38c7a6f7 100644
--- a/src/server/cdp/domains/storage.zig
+++ b/src/server/cdp/domains/storage.zig
@@ -207,7 +207,8 @@ fn buildCdpCookie(allocator: Allocator, param: CdpCookie) !Cookie {
.value = param.value,
.domain = if (dotted) domain else null,
.path = param.path,
- .expires = param.expires,
+ // As Chrome's MakeCookieFromProtocolValues, a negative expires is a session cookie.
+ .expires = if (param.expires) |e| (if (e < 0) null else e) else null,
.secure = secure,
.http_only = param.httpOnly,
.same_site = parseSameSite(param.sameSite),
@@ -330,6 +331,15 @@ test "cdp.Storage: setCookies takes back the cookies getCookies gave" {
try ctx.expectSentResult(null, .{ .id = 2 });
try testing.expectEqual(0, ctx.cdp().browser_context.?.session.cookie_jar.cookies.items.len);
+ // getCookies reports a session cookie with expires: -1.
+ var session = cookie;
+ session.expires = -1;
+ try ctx.processMessage(.{ .id = 5, .method = "Storage.setCookies", .params = .{ .cookies = &[_]CdpCookie{session} } });
+ try ctx.expectSentResult(null, .{ .id = 5 });
+ const jar = &ctx.cdp().browser_context.?.session.cookie_jar;
+ try testing.expectEqual(1, jar.cookies.items.len);
+ try testing.expectEqual(null, jar.cookies.items[0].expires);
+
// What Chrome refuses among those fields.
var bad_port = cookie;
bad_port.sourcePort = 0;