Skip to content

armgit / burr

Public Imported from GitHub
0

Build applications that make decisions (chatbots, agents, simulations, etc...). Monitor, trace, persist, and execute on your own infrastructure.

Fixes the tracker interface to officially handle logging attributes

elijahbenizzy4b58ea79bf9d
diff --git a/burr/tracking/client.py b/burr/tracking/client.py
index fa3c33d0..02b2039c 100644
--- a/burr/tracking/client.py
+++ b/burr/tracking/client.py
@@ -426,14 +426,14 @@ class LocalTrackingClient(
self,
*,
action: str,
- sequence_id: int,
+ action_sequence_id: int,
span: ActionSpan,
span_dependencies: list[str],
**future_kwargs: Any,
):
begin_span_model = BeginSpanModel(
start_time=datetime.datetime.now(),
- action_sequence_id=sequence_id,
+ action_sequence_id=action_sequence_id,
span_id=span.uid,
parent_span_id=span.parent.uid if span.parent else None,
span_dependencies=span_dependencies,
@@ -445,14 +445,14 @@ class LocalTrackingClient(
self,
*,
action: str,
- sequence_id: int,
+ action_sequence_id: int,
span: ActionSpan,
span_dependencies: list[str],
**future_kwargs: Any,
):
end_span_model = EndSpanModel(
end_time=datetime.datetime.now(),
- action_sequence_id=sequence_id,
+ action_sequence_id=action_sequence_id,
span_id=span.uid,
)
self._append_write_line(end_span_model)
diff --git a/burr/visibility/tracing.py b/burr/visibility/tracing.py
index 01a7667e..439a78a2 100644
--- a/burr/visibility/tracing.py
+++ b/burr/visibility/tracing.py
@@ -133,7 +133,7 @@ class ActionSpanTracer(AbstractContextManager, AbstractAsyncContextManager):
action=self.action,
span=context,
span_dependencies=self.span_dependencies,
- sequence_id=self.action_sequence_id,
+ action_sequence_id=self.action_sequence_id,
app_id=self.app_id,
partition_key=self.partition_key,
)
@@ -144,7 +144,7 @@ class ActionSpanTracer(AbstractContextManager, AbstractAsyncContextManager):
action=self.action,
span=context,
span_dependencies=self.span_dependencies,
- sequence_id=self.action_sequence_id,
+ action_sequence_id=self.action_sequence_id,
app_id=self.app_id,
partition_key=self.partition_key,
)
@@ -155,7 +155,7 @@ class ActionSpanTracer(AbstractContextManager, AbstractAsyncContextManager):
action=self.action,
span=context,
span_dependencies=self.span_dependencies,
- sequence_id=self.action_sequence_id,
+ action_sequence_id=self.action_sequence_id,
app_id=self.app_id,
partition_key=self.partition_key,
)
@@ -187,7 +187,7 @@ class ActionSpanTracer(AbstractContextManager, AbstractAsyncContextManager):
action=self.action,
span=context,
span_dependencies=self.span_dependencies,
- sequence_id=self.action_sequence_id,
+ action_sequence_id=self.action_sequence_id,
app_id=self.app_id,
partition_key=self.partition_key,
)
diff --git a/tests/core/test_application.py b/tests/core/test_application.py
index a4a211b6..68d1c152 100644
--- a/tests/core/test_application.py
+++ b/tests/core/test_application.py
@@ -2482,6 +2482,9 @@ def test_application_builder_initialize_fork_app_id_happy_pth():
class NoOpTracker(SyncTrackingClient):
+ def do_log_attributes(self, **future_kwargs: Any):
+ pass
+
def __init__(self, unique_id: str):
self.unique_id = unique_id